Issues in Application.php (master) - Issues in master - samsoncms/cms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Application.php (19 issues)

Labels

Severity

Minor 19

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace samsoncms\cms;

use samson\core\CompressableExternalModule;
use samson\core\SamsonLocale;
use samsonframework\container\definition\analyzer\annotation\annotation\Service;
use samsonphp\compressor\Compressor;
use samsonphp\event\Event;
use samsonphp\resource\Router;
use samsonphp\router\Module;

/**
 * SamsonCMS external compressible application for integrating
 * @author Vitaly Iegorov <[email protected]>
 * @Service("cms")
 */
class Application extends CompressableExternalModule

{
    const EVENT_IS_CMS = 'samsonsms.is.cms';

    /** @var string Module identifier */
    public $id = 'cms';

    public $baseUrl = 'cms';

    /** @var array Collection of SamsonCMS related modules */
    protected $cmsModuleList = [];

    protected $projectModuleList = [];

    /** @var bool Flag that currently we are woring in SamsonCMS */
    protected $isCMS = false;

    protected $template = '';

    //[PHPCOMPRESSOR(remove,start)]


    protected function prepareModuleList()
    {
        $this->cmsModuleList = $this->system->getContainer()->getServices('module');


        // Gather all project specific modules that do not dependent to SamsonCMS
        $parentDependencies = [];
        foreach ($this->cmsModuleList as $id => $module) {
            // Module dependency at project level composer.json and is not this module
            if (array_key_exists('projectRequireDev', $module->composerParameters) && $module->composerParameters['projectRequireDev'] === true && $id !== $this->id()) {
                $parentDependencies = array_merge($module->composerParameters['required'], [$module->composerParameters['composerName']], $parentDependencies);
            }
        }
        // Remove duplicates
        $parentDependencies = array_unique($parentDependencies);

        // Gather project-only related modules
        $this->projectModuleList = [];
        foreach ($this->cmsModuleList as $id => $module) {
            if (!array_key_exists('composerName', $module->composerParameters)) {
                $this->projectModuleList[$id] = $module;
            } elseif (array_key_exists('composerName', $module->composerParameters) && in_array($module->composerParameters['composerName'], $parentDependencies)) {
                $this->projectModuleList[$id] = $module;
            }
            if (!$this->isModuleDependent($module) && $id !== 'core' && !$this->ifModuleRelated($module)) {
                unset($this->cmsModuleList[$id]);
            }
        }
    }

    /**
     * Remove unnecessary modules list for SamsonCMS from loaded modules
     * and return left modules.
     *
     * @param array $otherModuleList List of SamsonCMS unneeded modules
     */
    public function filterModuleList(&$otherModuleList = [])
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->prepareModuleList();

        $otherModuleList = $this->projectModuleList;

        /**
         * Change modules list between main web-application and SamsonCMS
         */
        // TODO: As this is processed before routing than we just check URL
        if ($this->isCMS() || strpos($_SERVER['REQUEST_URI'], '/'.$this->id.'/') !== false) {
            // Switch module list to SamsonCMS module list
            $otherModuleList = $this->cmsModuleList;
        }
    }


    /** SamsonCMS preparation stage handler */
    public function prepare()
    {
        /**
         * Subscribe for router resource initialization to remove SamsonCMS modules as we will generate
         * SamsonCMS resources manually
         */
        Event::subscribe(Router::EVENT_START_GENERATE_RESOURCES, [$this, 'filterModuleList']);

    }

    /**
     * If module is dependent from current module through composer.json.
     *
     * @param $module Module for checking
     * @return bool True if module dependent
     */
    protected function isModuleDependent($module)
    {
        return isset($module->composerParameters['composerName']) && in_array($module->composerParameters['composerName'], $this->composerParameters['required']);
    }

    public function getModuleList(& $moduleListArray)
    {
        $this->prepareModuleList();
        $moduleListArray[Router::I_MAIN_PROJECT_TEMPLATE] = $this->projectModuleList;
        $moduleListArray[$this->template] = $this->cmsModuleList;
    }

    //[PHPCOMPRESSOR(remove,end)]



    /**
     * Check if passed module is related to SamsonCMS.
     * Also method stores data to flag variable.
     *
     * @param $module
     *
     * @return bool True if module related to SamsonCMS
     */
    public function ifModuleRelated($module)
    {
        // Analyze if module class or one of its parents has samsoncms\ namespace pattern
        return count(preg_grep('/samsoncms\\\\/i', array_merge(array(get_class($module)), class_parents($module))));
    }

    /**
     * SamsonCMS initialization stage handler
     *
     * @param array $params Initialization parameters
     *
     * @return bool Initialization stage result
     */
    public function init(array $params = array())
    {
        // Old applications main page rendering
        Event::subscribe('template.main.rendered', array($this, 'oldMainRenderer'));

        // Old applications menu rendering
        Event::subscribe('template.menu.rendered', array($this, 'oldMenuRenderer'));

        Event::subscribe('samson.url.build', array($this, 'buildUrl'));

        Event::subscribe('samson.url.args.created', array($this, 'parseUrl'));

        Event::subscribe(Module::EVENT_ROUTE_FOUND, array($this, 'activeModuleHandler'));

        Event::subscribe('samsonphp.router.create.module.routes', array($this, 'updateCMSPrefix'));

        Event::subscribe(Compressor::E_CREATE_MODULE_LIST, array($this, 'getModuleList'));

        //url()->parse();

        $this->template = $this->path() . 'app/view/index.php';

        // Generate resources for new module
        //[PHPCOMPRESSOR(remove,start)]

        //$this->system->module('resourcer')->generateResources($this->cmsModuleList, $this->path() . 'app/view/index.php');

        //[PHPCOMPRESSOR(remove,end)]

    }

    public function isCMS()
    {
        return $this->isCMS;
    }

    public function activeModuleHandler($module)
    {
        // Define if routed module is related to SamsonCMS
        if($this->isCMS = $this->ifModuleRelated($module)){
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            // TODO: This should be removed - Reparse url

            url()->parse();

            // Switch template to SamsonCMS
            $this->system->template($this->template, true);

            Event::fire(self::EVENT_IS_CMS, array(&$this));
        }
    }

    /**
     * Callback for adding SamsonCMS related modules prefix to routes.
     *
     * @param $module
     * @param $prefix
     */
    public function updateCMSPrefix($module, &$prefix)
    {
        if (($module->id != $this->id) && $this->ifModuleRelated($module)) {
            $prefix = '/' . $this->baseUrl . $prefix;
        }
    }

    public function buildUrl(&$urlObj, &$httpHost, &$urlParams)
    {
        if ($this->isCMS) {
            if (in_array($urlParams[0], SamsonLocale::get(), true)) {
                array_splice($urlParams, 1, 0, array($this->baseUrl));
                $urlParams = array_values($urlParams);
            } else {
                array_unshift($urlParams, $this->baseUrl);
            }
        }
    }

    public function parseUrl(&$urlObj, &$urlArgs)
    {
        if ($this->isCMS) {
            if (in_array($urlArgs[0], SamsonLocale::get(), true)) {
                unset($urlArgs[1]);
                $urlArgs = array_values($urlArgs);
            } else {
                array_shift($urlArgs);
            }
        }
    }

    public function __base()
    {
        $templateModule = $this->system->module('template');

        // Switch system to SamsonCMS template module
        $this->system->active($templateModule);

        // Call template handler
        $templateModule->__handler();
    }

    public function oldMainRenderer(&$html)
    {
        // Render application main page block
        foreach (\samsoncms\Application::loaded() as $app) {

            // Show only visible apps
            if ($app->hide == false /*&& $app->findView('sub_menu')*/) {

                $html .= $app->main();

            }
        }
    }

    /**
     * @deprecated All application should draw menu block via events
     */
    public function oldMenuRenderer(&$html, &$subMenu)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Iterate loaded samson\cms\application
        foreach (\samsoncms\Application::loaded() as $app) {

            // Show only visible apps
            if ($app->hide == false) {
                // Render application menu item
                $html .= m('template')

                    ->view('menu/item')
                    ->active(url()->module == $app->id() ? 'active' : '')
                    ->app($app)
                    ->icon($app->icon)
                    ->name(isset($app->name{0}) ? $app->name : '')
                    ->output();
            }
        }
        $subMenu = '';
        // Find current SamsonCMS application
        if (\samsoncms\Application::find(url()->module, $app/*@var $app App*/)) {
            // If module has sub_menu view - render it
            if ($app->findView('sub_menu')) {
                // Explode url by symbols '/'
                $url = explode('/', $_SERVER['REQUEST_URI']);
                // If isset url with params search and param page equal 0
                if (isset($url[4]) && $url[3] != 'form') {
                    // Default value for search field
                    $paramSearch = urldecode($url[4]);
                    // Set params search
                    $app->set($paramSearch, 'search');
                }
				
                $subMenu .= $app->view('sub_menu')->set(t($app->name, true), 'appName')->output();
            }
        }
    }

    /**
     * @deprecated
     * @return string Page title
     */
    public function oldGetTitle()
    {
        $local   = m('local');

        $current = m();


        return isset($current['title']) ? $current['title'] :
            (isset($local['title']) ? $local['title'] : '');
    }
}


1			<?php
2			namespace samsoncms\cms;
3
4			use samson\core\CompressableExternalModule;
5			use samson\core\SamsonLocale;
6			use samsonframework\container\definition\analyzer\annotation\annotation\Service;
7			use samsonphp\compressor\Compressor;
8			use samsonphp\event\Event;
9			use samsonphp\resource\Router;
10			use samsonphp\router\Module;
11
12			/**
13			* SamsonCMS external compressible application for integrating
14			* @author Vitaly Iegorov <[email protected]>
15			* @Service("cms")
16			*/
17			class Application extends CompressableExternalModule
			0 ignored issues – show Deprecated Code introduced 2016-01-24 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `samson\core\CompressableExternalModule` has been deprecated with message: Just implement samsonframework\core\CompressInterface This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
18			{
19			const EVENT_IS_CMS = 'samsonsms.is.cms';
20
21			/** @var string Module identifier */
22			public $id = 'cms';
23
24			public $baseUrl = 'cms';
25
26			/** @var array Collection of SamsonCMS related modules */
27			protected $cmsModuleList = [];
28
29			protected $projectModuleList = [];
30
31			/** @var bool Flag that currently we are woring in SamsonCMS */
32			protected $isCMS = false;
33
34			protected $template = '';
35
36			//[PHPCOMPRESSOR(remove,start)]
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-05 17:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
37
38			protected function prepareModuleList()

samsoncms / cms

Issues (19)

Security Analysis not enabled

src/Application.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like