Entity - Code Metrics - Inspection of "fixed filtering" - samsoncms/api - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#28)

unknown
created 2016-02-16 14:54 UTC
Entity C

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	462
Duplicated Lines	0 %
Coupling/Cohesion

Components	1
Dependencies	8
Importance

Changes	18
Bugs	10	Features	6
Metric	Value
wmc	55
c	18
b	10
f	6
lcom	1
cbo	8
dl	0
loc	462
rs	6.8
17 Methods

Rating	Name	Size	Complexity
A	select()	14	4
A	orderBy()	10	2
A	search()	6	1
A	limit()	6	1
A	where()	13	2
B	findEntityIDs()	28	4
A	findByNavigationIDs()	4	1
A	findByAdditionalFields()	20	3
A	applySearch()	18	3
A	applySorting()	18	3
C	findAdditionalFields()	62	10
A	fillEntityFields()	16	4
C	find()	37	7
A	first()	11	2
B	fields()	28	4
A	count()	10	2
A	__construct()	9	2
How to fix Complexity

<?php
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 11.12.15
 * Time: 17:35
 */
namespace samsoncms\api\query;

use samson\activerecord\dbQuery;
use samson\activerecord\materialfield;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use samsonframework\orm\Argument;
use samsonframework\orm\ArgumentInterface;
use samsoncms\api\CMS;
use samsoncms\api\exception\EntityFieldNotFound;
use samsoncms\api\Field;
use samsoncms\api\Material;
use samsonframework\orm\Condition;
use samsonframework\orm\ConditionInterface;
use samsonframework\orm\QueryInterface;

/**
 * Generic SamsonCMS Entity query.
 * @package samsoncms\api\query
 */
class Entity extends Generic
{
    /** @var array Collection of all additional fields names */
    public static $fieldNames = array();

    /** @var array Collection of localized additional fields identifiers */
    protected static $localizedFieldIDs = array();

    /** @var array Collection of NOT localized additional fields identifiers */
    protected static $notLocalizedFieldIDs = array();

    /** @var array Collection of all additional fields identifiers */
    protected static $fieldIDs = array();

    /** @var  @var array Collection of additional fields value column names */
    protected static $fieldValueColumns = array();

    /** @var Condition Collection of entity field filter */
    protected $fieldFilter = array();

    /** @var string Query locale */
    protected $locale = '';

    /** @var array Collection of additional fields for ordering */
    protected $entityOrderBy = array();

    /** @var array Collection of search fields for query */
    protected $searchFilter = array();

    /**
     * Select specified entity fields.
     * If this method is called then only selected entity fields
     * would be return in entity instances.
     *
     * @param mixed $fieldNames Entity field name or collection of names
     * @return $this Chaining
     */
    public function select($fieldNames)
    {
        // Convert argument to array and iterate
        foreach ((!is_array($fieldNames) ? array($fieldNames) : $fieldNames) as $fieldName) {
            // Try to find entity additional field
            $pointer = &static::$fieldNames[$fieldName];
            if (null !== $pointer) {
                // Store selected additional field buy FieldID and Field name
                $this->selectedFields[$pointer] = $fieldName;
            }
        }

        return $this;
    }

    /**
     * Set additional field for sorting.
     *
     * @param string $fieldName Additional field name
     * @param string $order Sorting order
     * @return $this Chaining
     */
    public function orderBy($fieldName, $order = 'ASC')
    {
        if (array_key_exists($fieldName, static::$fieldNames)) {
            $this->entityOrderBy = array($fieldName, $order);
        } else {
            parent::orderBy($fieldName, $order);
        }

        return $this;
    }

    /**
     * Search entity fields by text.
     *
     * @param string $text Searching text
     * @return $this
     */
    public function search($text)
    {
        $this->searchFilter[] = $text;

        return $this;
    }

    /**
     * Set resulting query limits.
     *
     * @param integer $offset Starting index
     * @param integer|null $count Entities count
     * @return $this Chaining
     */
    public function limit($offset, $count = null)
    {
        $this->limit = array($offset, $count);

        return $this;
    }

    /**
     * Add condition to current query.
     *
     * @param string $fieldName Entity field name
     * @param string $fieldValue Value
     * @param string $fieldRelation Entity field to value relation
     * @return $this Chaining
     */
    public function where($fieldName, $fieldValue = null, $fieldRelation = ArgumentInterface::EQUAL)
    {
        // Try to find entity additional field
        $pointer = &static::$fieldNames[$fieldName];
        if (isset($pointer)) {
            // Store additional field filter value
            $this->fieldFilter[$pointer] = (new Condition())->add(static::$fieldValueColumns[$pointer], $fieldValue, $fieldRelation);
        } else {
            parent::where($fieldName, $fieldValue, $fieldRelation);
        }

        return $this;
    }

    /** @return array Collection of entity identifiers */
    protected function findEntityIDs()
    {
        $entityIDs = array();
        if ($this->conditions) {
            $entityIDs = $this->query
                ->entity(Material::ENTITY)
                ->whereCondition($this->conditions)
                ->fields(Material::F_PRIMARY);
        }

        // TODO: Find and describe approach with maximum generic performance
        $entityIDs = $this->findByAdditionalFields(
            $this->fieldFilter,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->findByNavigationIDs($entityIDs)
        );

        // Perform sorting if necessary
        if (count($this->entityOrderBy) === 2) {
            $entityIDs = $this->applySorting($entityIDs, $this->entityOrderBy[0], $this->entityOrderBy[1]);
        }

        // Perform limits if necessary
        if (count($this->limit)) {
            $entityIDs = array_slice($entityIDs, $this->limit[0], $this->limit[1]);
        }

        return $entityIDs;
    }

    /**
     * Get collection of entity identifiers filtered by navigation identifiers.
     *
     * @param array $entityIDs Additional collection of entity identifiers for filtering
     * @return array Collection of material identifiers by navigation identifiers
     */
    protected function findByNavigationIDs($entityIDs = array())
    {
        return (new MaterialNavigation($entityIDs))->idsByRelationID(static::$navigationIDs);
    }

    /**
     * Get collection of entity identifiers filtered by additional field and its value.
     *
     * @param Condition[] $additionalFields Collection of additional field identifiers => values
     * @param array $entityIDs Additional collection of entity identifiers for filtering
     * @return array Collection of material identifiers by navigation identifiers
     */
    protected function findByAdditionalFields($additionalFields, $entityIDs = array())
    {
        /**
         * TODO: We have separate request to materialfield for each field, maybe faster to
         * make one single query with all fields conditions. Performance tests are needed.
         */

        /** @var Condition $fieldCondition Iterate all additional fields needed for filter condition */
        foreach ($additionalFields as $fieldID => $fieldCondition) {
            // Get collection of entity identifiers passing already found identifiers
            $entityIDs = (new MaterialField($entityIDs))->idsByRelationID($fieldID, $fieldCondition, array());


            // Stop execution if we have no entities found at this step
            if (!count($entityIDs)) {
                break;
            }
        }

        return $entityIDs;
    }

    /**
     * @param array $entityIDs
     * @return array
     */
    protected function applySearch(array $entityIDs)
    {
        $condition = new Condition(ConditionInterface::DISJUNCTION);

        foreach ($this->searchFilter as $searchText) {
            foreach (static::$fieldValueColumns as $fieldId => $fieldColumn) {
                $condition->addCondition((new Condition())
                    ->addArgument(new Argument($fieldColumn, '%' . $searchText . '%', ArgumentInterface::LIKE))
                    ->addArgument(new Argument(\samsoncms\api\MaterialField::F_FIELDID, $fieldId)));
            }
        }

        return $this->query
            ->entity(\samsoncms\api\MaterialField::class)
            ->whereCondition($condition)
            ->where(Material::F_PRIMARY, $entityIDs)
            ->fields(Material::F_PRIMARY);
    }

    /**
     * Add sorting to entity identifiers.
     *
     * @param array $entityIDs
     * @param string $fieldName Additional field name for sorting
     * @param string $order Sorting order(ASC|DESC)
     * @return array Collection of entity identifiers ordered by additional field value
     */
    protected function applySorting(array $entityIDs, $fieldName, $order = 'ASC')
    {
        // Get additional field metadata
        $fieldID = &static::$fieldNames[$fieldName];
        $valueColumn = &static::$fieldValueColumns[$fieldID];

        // If this is additional field
        if (null !== $fieldID && null !== $valueColumn) {
            return $this->query
                ->entity(CMS::MATERIAL_FIELD_RELATION_ENTITY)
                ->where(Field::F_PRIMARY, $fieldID)
                ->where(Material::F_PRIMARY, $entityIDs)
                ->orderBy($valueColumn, $order)
                ->fields(Material::F_PRIMARY);
        } else { // Nothing is changed
            return $entityIDs;
        }
    }

    /**
     * Get entities additional field values.
     *
     * @param array $entityIDs Collection of entity identifiers
     * @return array Collection of entities additional fields EntityID => [Additional field name => Value]
     */
    protected function findAdditionalFields($entityIDs)
    {
        $return = array();

        // Copy fields arrays
        $localized = static::$localizedFieldIDs;
        $notLocalized = static::$notLocalizedFieldIDs;

        // If we filter additional fields that we need to receive
        if (count($this->selectedFields)) {
            foreach ($this->selectedFields as $fieldID => $fieldName) {
                // Filter localized and not fields by selected fields
                if (!isset(static::$localizedFieldIDs[$fieldID])) {
                    unset($localized[$fieldID]);
                }

                if (!isset(static::$notLocalizedFieldIDs[$fieldID])) {
                    unset($notLocalized[$fieldID]);
                }
            }
        }

        // Prepare localized additional field query condition
        $condition = new Condition(Condition::DISJUNCTION);
        foreach ($localized as $fieldID => $fieldName) {
            $condition->addCondition(
                (new Condition())
                    ->add(Field::F_PRIMARY, $fieldID)
                    ->add(\samsoncms\api\MaterialField::F_LOCALE, $this->locale)
            );
        }

        // Prepare not localized fields condition
        foreach ($notLocalized as $fieldID => $fieldName) {
            $condition->add(Field::F_PRIMARY, $fieldID);
        }

        // Get additional fields values for current entity identifiers
        foreach ($this->query->entity(CMS::MATERIAL_FIELD_RELATION_ENTITY)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                     ->where(Material::F_PRIMARY, $entityIDs)
                     ->whereCondition($condition)
                     ->where(Material::F_DELETION, true)
                     ->exec() as $additionalField
        ) {
            // Get needed metadata
            $fieldID = $additionalField[Field::F_PRIMARY];
            $materialID = $additionalField[Material::F_PRIMARY];
            $valueField = &static::$fieldValueColumns[$fieldID];
            $fieldName = &static::$fieldIDs[$fieldID];

            // Check if we have this additional field in this entity query
            if (null === $valueField || null === $fieldName) {
                throw new EntityFieldNotFound($fieldID);
            } else { // Add field value to result
                $fieldValue = $additionalField[$valueField];
                // Gather additional fields values by entity identifiers and field name
                $return[$materialID][$fieldName] = $fieldValue;
            }
        }

        return $return;
    }

    /**
     * Fill entity additional fields.
     *
     * @param Entity $entity Entity instance for filling
     * @param array $additionalFields Collection of additional field values
     * @return Entity With filled additional field values
     */
    protected function fillEntityFields($entity, array $additionalFields)
    {
        // If we have list of additional fields that we need
        $fieldIDs = count($this->selectedFields) ? $this->selectedFields : static::$fieldIDs;

        // Iterate all entity additional fields
        foreach ($fieldIDs as $variable) {
            // Set only existing additional fields
            $pointer = &$additionalFields[$entity[Material::F_PRIMARY]][$variable];
            if (isset($pointer)) {
                $entity->$variable = $pointer;
            }
        }

        return $entity;
    }

    /**
     * Perform SamsonCMS query and get collection of entities.
     *
     * @param int $page Page number
     * @param int $size Page size
     *
     * @return \samsoncms\api\Entity[] Collection of entity fields
     */
    public function find($page = null, $size = null)
    {
        $return = array();
        if (count($entityIDs = $this->findEntityIDs())) {
            $additionalFields = $this->findAdditionalFields($entityIDs);

            if (count($this->searchFilter)) {
                $entityIDs = $this->applySearch($entityIDs);

                // Return result if not ids
                if (count($entityIDs) === 0) {
                    return $return;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                }
            }

            // Slice identifier array to match pagination
            if (null !== $page && null !== $size) {
                $entityIDs = array_slice($entityIDs, ($page - 1) * $size, $size);
            }

            // Set entity primary keys
            $this->primary($entityIDs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            //elapsed('End fields values');
            /** @var \samsoncms\api\Entity $item Find entity instances */
            foreach (parent::find() as $item) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $item = $this->fillEntityFields($item, $additionalFields);

                // Store entity by identifier
                $return[$item[Material::F_PRIMARY]] = $item;
            }
        }

        //elapsed('Finish SamsonCMS '.static::$identifier.' query');

        return $return;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Perform SamsonCMS query and get first matching entity.
     *
     * @return \samsoncms\api\Entity Firt matching entity
     */
    public function first()
    {
        $return = array();
        if (count($entityIDs = $this->findEntityIDs())) {
            $this->primary($entityIDs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $additionalFields = $this->findAdditionalFields($entityIDs);
            $return = $this->fillEntityFields(parent::first(), $additionalFields);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $return;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Perform SamsonCMS query and get collection of entities fields.
     *
     * @param string $fieldName Entity field name
     * @return array Collection of entity fields
     * @throws EntityFieldNotFound
     */
    public function fields($fieldName)
    {
        $return = array();
        if (count($entityIDs = $this->findEntityIDs())) {
            // Check if our entity has this field
            $fieldID = &static::$fieldNames[$fieldName];
            if (isset($fieldID)) {
                $return = $this->query
                    ->entity(\samsoncms\api\MaterialField::ENTITY)
                    ->where(Material::F_PRIMARY, $entityIDs)
                    ->where(Field::F_PRIMARY, $fieldID)
                    ->where(\samsoncms\api\MaterialField::F_DELETION, true)
                    ->fields(static::$fieldValueColumns[$fieldID]);
            } elseif (array_key_exists($fieldName, static::$parentFields)) {
                // TODO: Generalize real and virtual entity fields and manipulations with them
                // Set filtered entity identifiers
                $this->where(Material::F_PRIMARY, $entityIDs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                // If this is parent field
                return parent::fields($fieldName);
            } else {
                throw new EntityFieldNotFound($fieldName);
            }
        }

        //elapsed('Finish SamsonCMS '.static::$identifier.' query');

        return $return;
    }

    /**
     * Perform SamsonCMS query and get amount resulting entities.
     *
     * @return int Amount of resulting entities
     */
    public function count()
    {
        $return = 0;

        if (count($entityIDs = $this->findEntityIDs())) {
            $this->primary($entityIDs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $return = parent::count();
        }

        return $return;
    }

    /**
     * Generic constructor.
     *
     * @param QueryInterface $query Database query instance
     * @param string $locale Query localization
     */
    public function __construct(QueryInterface $query = null, $locale = null)
    {
        $this->locale = $locale;

        parent::__construct(null === $query ? new dbQuery() : $query);

        // Work only with active entities
        $this->active(true);
    }
}

samsoncms / api

Pull Request — master (#28)

Entity C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like
