samsoncms\api\FieldsTable::entities()

Complexity

Conditions	3
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	FieldsTable::rowIDs()	0	11	1

<?php
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 09.12.15
 * Time: 09:57
 */
namespace samsoncms\api;

use samsoncms\api\query\FieldNavigation;
use samsoncms\api\query\MaterialNavigation;
use samsonframework\orm\Condition;
use samsonframework\orm\ConditionInterface;
use samsonframework\orm\QueryInterface;

/**
 * Material additional fields table.
 * @package samsoncms\api
 */
class FieldsTable
{
    /** @var integer Navigation identifier for table structure */
    protected $navigationID;

    /** @var integer Table parent material identifier */
    protected $materialID;

    /** @var Field[] Collection field instances that correspond table columns */
    protected $fields;

    /** @var QueryInterface Database query interface */
    protected $query;

    /** @var string Locale identifier */
    protected $locale;

    /** @var array Fields table collection */
    protected $collection;

    /** @return array Get field table column names collection */
    public function columns()
    {
        return array_column($this->fields, Field::F_IDENTIFIER);
    }

    /**
     * Get collection of table column values as array.
     *
     * @param string $fieldID Additional field identifier
     * @return array Collection of table column values as array
     */
    public function values($fieldID)
    {
        $return = array();
        if (isset($this->fields[$fieldID])) {
            $return = array_column($this->collection, $fieldID);
        }
        return $return;
    }

    /**
     * Get field table as multidimensional array.
     *
     * @return array Field table represented as array
     */
    public function toArray()
    {
        return $this->collection;
    }

    /** @return array Collection of table rows(materials) identifiers */
    protected function rowIDs()
    {
        // Get collection of nested materials
        return $this->query
            ->entity(Material::ENTITY)
            ->where(Material::F_DELETION, 1)
            ->where(Material::F_PRIMARY, (new MaterialNavigation())->idsByRelationID($this->navigationID))

(new \samsoncms\api\query\MaterialNavigation())->idsByRelationID($this->navigationID) is of type boolean|object<samsonframework\orm\RecordInterface>, but the function expects a string|null.

            ->where(Material::F_PARENT, $this->materialID)
            ->orderBy(Material::F_PRIORITY)
            ->fields(Material::F_PRIMARY);
    }

    /**
     * Build correct localized field request for retrieving additional fields records.
     *
     * @param Field[] $fields Collection of additional fields
     * @return Condition Built condition for query
     */
    protected function fieldsCondition($fields)
    {
        // Group fields by localization
        $localizedColumns = array();
        $notLocalizedColumns = array();
        /** @var Field $field Iterate table columns(fields) */
        foreach ($fields as $field) {
            if ($field->localized()) {
                $localizedColumns[] = $field->id;
            } else {
                $notLocalizedColumns[] = $field->id;
            }
        }

        // Create field condition
        $fieldsCondition = new Condition(ConditionInterface::DISJUNCTION);
        // Create localized condition
        if (sizeof($localizedColumns)) {
            $localizedCondition = new Condition(ConditionInterface::CONJUNCTION);
            $localizedCondition->add(Field::F_PRIMARY, $localizedColumns)
                ->add(MaterialField::F_LOCALE, $this->locale);

            // Add this condition to condition group
            $fieldsCondition->addCondition($localizedCondition);
        }

        // Create not localized condition
        if (sizeof($notLocalizedColumns)) {
            $fieldsCondition->add(Field::F_PRIMARY, $notLocalizedColumns);
        }

        return $fieldsCondition;
    }

    /**
     * Fill table with data from database.
     */
    protected function load()
    {
        // Get table Fields instances
        $this->fields = (new FieldNavigation())->byRelationID($this->navigationID);

It seems like (new \samsoncms\api\query\FieldNavigation())->byRelationID($this->navigationID) of type array<integer,*> is incompatible with the declared type array<integer,object<samsoncms\api\Field>> of property $fields.

        if (sizeof($rowIDs = $this->rowIDs())) {
            /** @var MaterialField $fieldValue Get additional field value instances */
            foreach ($this->query->entity(CMS::MATERIAL_FIELD_RELATION_ENTITY)

The expression $this->query->entity(\samsoncms\api\CMS::MATERIAL_FIELD_RELATION_ENTITY)->where(\samsoncms\api\Material::F_PRIMARY, $rowIDs)->where(\samsoncms\api\Material::F_DELETION, 1)->whereCondition($this->fieldsCondition($this->fields))->exec() of type boolean|object<samsonframework\orm\RecordInterface> is not guaranteed to be traversable. How about adding an additional type check?

Space found before closing bracket of FOREACH loop

                         // Get only needed rows(materials)
                         ->where(Material::F_PRIMARY, $rowIDs)

$rowIDs is of type boolean|object<samsonframework\orm\RecordInterface>, but the function expects a string|null.

                         ->where(Material::F_DELETION, 1)
                         // Get correct localizes field condition for columns
                         ->whereCondition($this->fieldsCondition($this->fields))
                         ->exec() as $fieldValue
            ) {
                /** @var Field $field Try to find Field instance by identifier */
                $field = &$this->fields[$fieldValue[Field::F_PRIMARY]];
                if (isset($field)) {
                    /**
                     * Store table row(material) as it primary, store columns(Fields)
                     * by field primary. Use correct column for value.
                     */
                    $this->collection[$fieldValue[Material::F_PRIMARY]][$fieldValue[Field::F_PRIMARY]]
                        = $fieldValue[$field->valueFieldName()];
                }
            }
        }
    }

    /**
     * FieldsTable constructor.
     *
     * @param QueryInterface $query Database query interface
     * @param mixed $navigationID Navigation identifier for table structure
     * @param integer $materialID Table parent material identifier
     * @param string $locale Locale identifier
     */
    public function __construct(QueryInterface $query, $navigationID, $materialID, $locale = '')
    {
        $this->query = $query;
        $this->navigationID = $navigationID;
        $this->materialID = $materialID;
        $this->locale = $locale;

        $this->load();
    }
}