samsoncms\api\query\MaterialField

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
B	idsByRelationID()	0	24	3

<?php
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 08.12.15
 * Time: 23:11
 */
namespace samsoncms\api\query;

use samson\activerecord\dbQuery;
use samsoncms\api\Field;

/**
 * Retrieve materials by additional fields.
 * @package samsoncms\api
 */
class MaterialField extends Base
{
    /** MaterialQuery constructor */
    public function __construct()
    {
        parent::__construct(
            new dbQuery(),
            __NAMESPACE__.'\Material',
            Field::$_primary,
            CMS::MATERIAL_FIELD_RELATION_ENTITY
        );
    }

    /**
     * Get current entity identifiers collection by relation identifier ans its value.
     *
     * @param string $relationID Relation entity identifier
     * @param mixed $relationValue Relation entity value
     * @param array $filteringIDs Collection of entity identifiers for filtering query
     * @return array Collection of entity identifiers filtered by navigation identifier.
     */
    public function idsByRelationID($relationID, $relationValue = null, $filteringIDs = null)
    {
        $return = array();

The expression array(); of type array adds the type array to the return on line 60 which is incompatible with the return type of the parent method samsoncms\api\query\Base::idsByRelationID of type boolean|samsonframework\orm\RecordInterface.

        /** @var Field $fieldRecord We need to have field record */
        $fieldRecord = null;
        if (Field::byID($this->query, $relationID, $fieldRecord)) {

$fieldRecord is of type object<samsoncms\api\Field>, but the function expects a null|object<self>.

            // Get material identifiers by field
            $this->query->entity($this->relationIdentifier)
                ->where(self::DELETE_FLAG_FIELD, 1)
                ->where($this->relationIdentifier, $relationID)
                ->where($fieldRecord->valueFieldName(), $relationValue);

            // Add material identifier filter if passed
            if (isset($filteringIDs)) {
                $this->query->where($this->primaryField, $filteringIDs);

$filteringIDs is of type array, but the function expects a string|null.

            }

            // Perform database query and get only material identifiers collection
            $return = $this->query->fields($this->primaryField);
        }

        return $return;
    }
}