Gallery::hasImages() - Code Metrics - Inspection of "Fixed renderable to be more generic" - samsoncms/api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 97e950...f11284 )

by Vitaly

created 2016-03-19 16:04 UTC

Gallery::hasImages() A

↳ Parent: Gallery

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	10
Ratio	55.56 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes	6
Bugs	3	Features	2

Metric	Value
c	6
b	3
f	2
dl	10
loc	18
rs	9.4285
ccs	12
cts	12
cp	1
cc	3
eloc	10
nc	3
nop	0
crap	3

<?php
/**
 * Created by PhpStorm.
 * User: myslyvyi
 * Date: 05.01.2016
 * Time: 15:25
 */
namespace samsoncms\api;

use samson\cms\CMSGallery;
use samsonframework\orm\QueryInterface;

/***
 *  Gallery additional field for material.
 *  This class enables getting all information about additional fields gallery for specific material.
 *  @author [email protected]
 */
class Gallery
{
    /** @var integer materialFieldId Table materialField identifier */
    protected $materialFieldId = null;

    /** @var QueryInterface Database query interface */
    protected $query;

    /**
     * Constructor Gallery.
     * This constructor finds identifier additional field gallery from database record its material and field identifiers.
     *
     * @param QueryInterface $query Database query interface
     * @param integer $materialId material identifier
     * @param integer $fieldId field identifier
     */
    public function __construct(QueryInterface $query, $materialId, $fieldId)
    {
        /** @var object $materialField additional field value database record*/
        $materialField = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //set query interface
        $this->query = $query;

        //Find additional field value database record by its material and field identifiers.
        $materialField = $this->query->entity(MaterialField::ENTITY)
            ->where(Material::F_PRIMARY, $materialId)
            ->where(Field::F_PRIMARY, $fieldId)
            ->where(Material::F_DELETION, 1)
            ->first();

        if ($materialField) {
            //Set materialFieldId
            $this->materialFieldId = $materialField->id;
        }

    }

    /**
     * Getting quantity images in additional field gallery
     *
     * @return integer $count
     */
    public function getCount()
    {
        /**@var integer $count quantity images in additional field gallery */
        $count = 0;

        if ($this->hasImages()) {

            // Getting quantity images for gallery
            $count = $this->query
                ->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
                ->where(Field::F_DELETION, 1)
                ->where(MaterialField::F_PRIMARY, $this->materialFieldId)
                ->count();
        }

        return $count;
    }

    /**
     * Check on empty gallery. If materialFieldId = null and quantity images not more 1 then material not has images.
     *
     * @return boolean
     **/
    public function hasImages()
    {
        /**@var $hasImages */
        $hasImages = false;

        if (isset($this->materialFieldId)) {

            // Getting quantity images, if quantity more 0 then material has images
            if ($this->query
            ->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
            ->where(Field::F_DELETION, 1)
            ->where(MaterialField::F_PRIMARY, $this->materialFieldId)
            ->count() > 0) {
                $hasImages = true;
            }
        }

        return $hasImages;
    }

    /**
     * Get collection of images for material by gallery additional field selector. If none is passed
     * all images from gallery table would be returned empty array.
     *
     * @param integer $currentPage current page with images. Min value = 1
     * @param integer $countView quantity view by page
     *
*@return array
     * @deprecated  Use find()
     */
    public function getImages($currentPage = null, $countView = 20)
    {
        return $this->find($currentPage, $countView);
    }

    /**
     * Perform SamsonCMS query and get entity gallery images.
     *
     * @param int $page Page number
     * @param int $size Page size
     *
     * @return GalleryField[] Collection of entity gallery images
     */
    public function find($page = null, $size = null)
    {
        /** @var GalleryField[] $images Get material images for this gallery */
        $images = array();

        /** @var QueryInterface $query Database query interface*/
        $query = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($this->hasImages()) {
            // Select all images in DB by materialFieldId
            $query = $this->query
                ->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
                ->where(Field::F_DELETION, 1)
                ->where(MaterialField::F_PRIMARY, $this->materialFieldId);

            // Add paging
            if (isset($page) && $page > 0) {
                //Set limit for query
                $query->limit(--$page * $size, $size);
            }

            // Execute query
            $images = $query->exec();
        }

        return $images;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: myslyvyi
5			* Date: 05.01.2016
6			* Time: 15:25
7			*/
8			namespace samsoncms\api;
9
10			use samson\cms\CMSGallery;
11			use samsonframework\orm\QueryInterface;
12
13			/***
14			* Gallery additional field for material.
15			* This class enables getting all information about additional fields gallery for specific material.
16			* @author [email protected]
17			*/
18			class Gallery
19			{
20			/** @var integer materialFieldId Table materialField identifier */
21			protected $materialFieldId = null;
22
23			/** @var QueryInterface Database query interface */
24			protected $query;
25
26			/**
27			* Constructor Gallery.
28			* This constructor finds identifier additional field gallery from database record its material and field identifiers.
29			*
30			* @param QueryInterface $query Database query interface
31			* @param integer $materialId material identifier
32			* @param integer $fieldId field identifier
33			*/
34	3		public function __construct(QueryInterface $query, $materialId, $fieldId)
35			{
36			/** @var object $materialField additional field value database record*/
37	3		$materialField = null;
			0 ignored issues – show Unused Code introduced 2016-01-12 15:27 UTC by Report Bug Copy Issue Report `$materialField` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38
39			//set query interface
40	3		$this->query = $query;
41
42			//Find additional field value database record by its material and field identifiers.
43	3		$materialField = $this->query->entity(MaterialField::ENTITY)
44	3		->where(Material::F_PRIMARY, $materialId)
45	3		->where(Field::F_PRIMARY, $fieldId)
46	3		->where(Material::F_DELETION, 1)
47	3		->first();
48
49	3		if ($materialField) {
50			//Set materialFieldId
51	3		$this->materialFieldId = $materialField->id;
52	3		}
53
54	3		}
55
56			/**
57			* Getting quantity images in additional field gallery
58			*
59			* @return integer $count
60			*/
61	1		public function getCount()
62			{
63			/*@var integer $count quantity images in additional field gallery /
64	1		$count = 0;
65
66	1	View Code Duplication	if ($this->hasImages()) {
			0 ignored issues – show Duplication introduced 2016-01-06 08:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67			// Getting quantity images for gallery
68	1		$count = $this->query
69	1		->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
70	1		->where(Field::F_DELETION, 1)
71	1		->where(MaterialField::F_PRIMARY, $this->materialFieldId)
72	1		->count();
73	1		}
74
75	1		return $count;
76			}
77
78			/**
79			* Check on empty gallery. If materialFieldId = null and quantity images not more 1 then material not has images.
80			*
81			* @return boolean
82			**/
83	3		public function hasImages()
84			{
85			/*@var $hasImages /
86	3		$hasImages = false;
87
88	3	View Code Duplication	if (isset($this->materialFieldId)) {
			0 ignored issues – show Duplication introduced 2016-01-06 08:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89			// Getting quantity images, if quantity more 0 then material has images
90	3		if ($this->query
91	3		->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
92	3		->where(Field::F_DELETION, 1)
93	3		->where(MaterialField::F_PRIMARY, $this->materialFieldId)
94	3		->count() > 0) {
95	3		$hasImages = true;
96	3		}
97	3		}
98
99	3		return $hasImages;
100			}
101
102			/**
103			* Get collection of images for material by gallery additional field selector. If none is passed
104			* all images from gallery table would be returned empty array.
105			*
106			* @param integer $currentPage current page with images. Min value = 1
107			* @param integer $countView quantity view by page
108			*
109			*@return array
110			* @deprecated Use find()
111			*/
112			public function getImages($currentPage = null, $countView = 20)
113			{
114			return $this->find($currentPage, $countView);
115			}
116
117			/**
118			* Perform SamsonCMS query and get entity gallery images.
119			*
120			* @param int $page Page number
121			* @param int $size Page size
122			*
123			* @return GalleryField[] Collection of entity gallery images
124			*/
125	2		public function find($page = null, $size = null)
126			{
127			/** @var GalleryField[] $images Get material images for this gallery */
128	2		$images = array();
129
130			/** @var QueryInterface $query Database query interface*/
131	2		$query = null;
			0 ignored issues – show Unused Code introduced 2016-01-12 11:23 UTC by Report Bug Copy Issue Report `$query` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
132
133	2		if ($this->hasImages()) {
134			// Select all images in DB by materialFieldId
135	2		$query = $this->query
136	2		->entity(CMS::MATERIAL_IMAGES_RELATION_ENTITY)
137	2		->where(Field::F_DELETION, 1)
138	2		->where(MaterialField::F_PRIMARY, $this->materialFieldId);
139
140			// Add paging
141	2		if (isset($page) && $page > 0) {
142			//Set limit for query
143	1		$query->limit(--$page * $size, $size);
144	1		}
145
146			// Execute query
147	2		$images = $query->exec();
148	2		}
149
150	2		return $images;
151			}
152			}
153

samsoncms / api

Push — master ( 97e950...f11284 )

Gallery::hasImages() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like