samsoncms\api\query\Generic

Complexity

Total Complexity

12

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	0	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	where()	0	10	2
A	findByNavigationIDs()	0	4	1
A	findByAdditionalFields()	0	15	3
A	findAdditionalFields()	0	8	2
B	find()	0	22	4

<?php
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 08.12.15
 * Time: 23:11
 */
namespace samsoncms\api\query;

use samson\activerecord\dbQuery;
use samsoncms\api\Material;

This use statement conflicts with another class in this namespace, samsoncms\api\query\Material.

use samsoncms\api\MaterialField;

This use statement conflicts with another class in this namespace, samsoncms\api\query\MaterialField.

use samsonframework\orm\Query;

/**
 * Material with additional fields query.
 * @package samsoncms\api
 */
class Generic
{
    /** @var string Entity identifier */
    protected static $identifier;

    /** @var string Entity navigation identifiers */
    protected static $navigationIDs = array();

    /** @var array Collection of localized additional fields identifiers */
    protected static $localizedFieldIDs = array();

    /** @var array Collection of NOT localized additional fields identifiers */
    protected static $notLocalizedFieldIDs = array();

    /** @var array Collection of entity field filter */
    protected $fieldFilter = array();

    /**
     * Add condition to current query.
     *
     * @param string $fieldName Entity field name
     * @param string $fieldValue Value
     * @return self Chaining
     */
    public function where($fieldName, $fieldValue = null)
    {
        // Try to find entity additional field
        if (property_exists(static::$identifier, $fieldName)) {
            // Store additional field filter value
            $this->fieldFilter[$fieldName] = $fieldValue;
        }

        return $this;
    }

    /**
     * Get collection of entity identifiers filtered by navigation identifiers.
     *
     * @param array $entityIDs Additional collection of entity identifiers for filtering
     * @return array Collection of material identifiers by navigation identifiers
     */
    protected function findByNavigationIDs($entityIDs = array())
    {
        return (new MaterialNavigation($entityIDs))->idsByRelationID(static::$navigationIDs);
    }

    /**
     * Get collection of entity identifiers filtered by additional field and its value.
     *
     * @param array $additionalFields Collection of additional field identifiers => values
     * @param array $entityIDs Additional collection of entity identifiers for filtering
     * @return array Collection of material identifiers by navigation identifiers
     */
    protected function findByAdditionalFields($additionalFields, $entityIDs = array())
    {
        // Iterate all additional fields needed for filter entity
        foreach ($additionalFields as $fieldID => $fieldValue) {
            // Get collection of entity identifiers passing already found identifiers
            $entityIDs = (new MaterialField($entityIDs))->idsByRelationID($fieldID, $fieldValue);

The method idsByRelationID() does not seem to exist on object<samsoncms\api\MaterialField>.

            // Stop execution if we have no entities found at this step
            if (!sizeof($entityIDs)) {
                break;
            }
        }

        return $entityIDs;
    }

    protected function findAdditionalFields($entityIDs)
    {
        $return = array();
        foreach (MaterialField::byFieldIDAndMaterialID(new dbQuery(), array_values(static::$fieldIDs), $entityIDs) as $additionalField) {

array_values(static::$fieldIDs) is of type array, but the function expects a string.

The expression \samsoncms\api\MaterialField::byFieldIDAndMaterialID(new \samson\activerecord\dbQuery(), array_values(static::$fieldIDs), $entityIDs) of type boolean|null|array<integer,object<samsoncms\api\MaterialField>> is not guaranteed to be traversable. How about adding an additional type check?

            $return[$additionalField[Material::F_PRIMARY]] = $additionalField;
        }
        return $return;
    }

    /**
     * Perform SamsonCMS query and get entities collection.
     *
     * @return mixed[] Collection of found entities
     */
    public function find()
    {
        // TODO: Find and describe approach with maximum generic performance
        $entityIDs = $this->findByNavigationIDs();
        $entityIDs = $this->findByAdditionalFields($this->fieldFilter, $entityIDs);

$entityIDs is of type boolean|object<samsonframework\orm\RecordInterface>, but the function expects a array.

        $return = array();
        if (sizeof($entityIDs)) {
            $additionalFields = $this->findAdditionalFields($entityIDs);
            /** @var \samsoncms\api\Entity $item Find entity instances */
            foreach ((new \samsoncms\api\query\Material(static::$identifier))->byIDs($entityIDs, 'exec') as $item) {
                // Iterate all entity additional fields
                foreach (get_class_vars(static::$identifier) as $variable) {
                    $item->$variable = &$additionalFields[$variable];
                }
                // Store entity by identifier
                $return[$item[Material::F_PRIMARY]] = $item;
            }
        }

        return $return;
    }
}