Field::byName() - Code Metrics - Inspection of "Added table prefix" - samsoncms/api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc9b06...645bdc )

by Vitaly

created 2015-11-23 15:36 UTC

Field::byName() A

↳ Parent: Field

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	3

Duplication

Lines	8
Ratio	100 %

Metric	Value
dl	8
loc	8
rs	9.4286
cc	2
eloc	3
nc	2
nop	2

<?php
namespace samsoncms\api;

/**
 * SamsonCMS field table class
 * @package samson\cms
 */
class Field extends \samson\activerecord\field
{
  /**
     * Find field database record by identifier
     * @param string $identifier Field identifier
     * @param self $return Return self instance
     * @return bool|null
     */
    public static function byID($identifier, self & $return = null )

    {
        // Get field record by identiifer column
        $return = static::oneByColumn(new dbQuery(), self::$_primary, $identifier);

        // If only one argument is passed - return null, otherwise bool
        return func_num_args() > 1 ? $return == null : $return;
    }

    /**
     * Find field database record by name
     * @param string $identifier Field identifier
     * @param self $return Return self instance
     * @return bool|null
     */
    public static function byName($identifier, self & $return = null )

    {
        // Get field record by identiifer column
        $return = static::oneByColumn(new dbQuery(), self::$_primary, 'Name');

        // If only one argument is passed - return null, otherwise bool
        return func_num_args() > 1 ? $return == null : $return;
    }
}


1		<?php
2		namespace samsoncms\api;
3
4		/**
5		* SamsonCMS field table class
6		* @package samson\cms
7		*/
8		class Field extends \samson\activerecord\field
9		{
10		/**
11		* Find field database record by identifier
12		* @param string $identifier Field identifier
13		* @param self $return Return self instance
14		* @return bool\|null
15		*/
16	View Code Duplication	public static function byID($identifier, self & $return = null )
		0 ignored issues – show Duplication introduced 2015-11-23 13:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2015-11-23 13:57 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$return" and closing bracket; 1 found Loading history...
17		{
18		// Get field record by identiifer column
19		$return = static::oneByColumn(new dbQuery(), self::$_primary, $identifier);
20
21		// If only one argument is passed - return null, otherwise bool
22		return func_num_args() > 1 ? $return == null : $return;
23		}
24
25		/**
26		* Find field database record by name
27		* @param string $identifier Field identifier
28		* @param self $return Return self instance
29		* @return bool\|null
30		*/
31	View Code Duplication	public static function byName($identifier, self & $return = null )
		0 ignored issues – show Duplication introduced 2015-11-23 13:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2015-11-23 13:57 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$return" and closing bracket; 1 found Loading history...
32		{
33		// Get field record by identiifer column
34		$return = static::oneByColumn(new dbQuery(), self::$_primary, 'Name');
35
36		// If only one argument is passed - return null, otherwise bool
37		return func_num_args() > 1 ? $return == null : $return;
38		}
39		}
40

samsoncms / api

Push — master ( fc9b06...645bdc )

Field::byName() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like