Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Field extends \samson\activerecord\field |
||
9 | { |
||
10 | /** |
||
11 | * Find field database record by identifier |
||
12 | * @param string $identifier Field identifier |
||
13 | * @param self $return Return self instance |
||
14 | * @return bool|null |
||
15 | */ |
||
16 | View Code Duplication | public static function byID($identifier, self & $return = null ) |
|
24 | |||
25 | /** |
||
26 | * Find field database record by name |
||
27 | * @param string $identifier Field identifier |
||
28 | * @param self $return Return self instance |
||
29 | * @return bool|null |
||
30 | */ |
||
31 | View Code Duplication | public static function byName($identifier, self & $return = null ) |
|
39 | } |
||
40 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.