Entity - Code Metrics - Inspection of "Added generic query\Entity for generating Entities..." - samsoncms/api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 646730...43a697 )

by Vitaly

created 2015-12-09 16:25 UTC

Entity A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	5
c	1
b	0
f	1
lcom	1
cbo	3
dl	0
loc	47
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	where()	0	6	2
A	find()	0	16	3

<?php
/**
 * Created by PhpStorm.
 * User: VITALYIEGOROV
 * Date: 08.12.15
 * Time: 23:11
 */
namespace samsoncms\api\query;

use samson\activerecord\dbQuery;

/**
 * Material with additional fields query.
 * @package samsoncms\api
 */
class Entity
{
    /** @var string Entity identifier */
    protected static $identifier;

    /** @var string Entity navigation identifiers */
    protected static $navigationIDs;

    /** @var array Collection of entity field filter */
    protected $fieldFilter;

    /**
     * Set additional entity field condition.
     *
     * @param string $fieldName Field identifier
     * @param string $fieldValue Field value
     * @return self Chaining
     */
    public function where($fieldName, $fieldValue)
    {
        if (property_exists(static::$identifier, $fieldName)) {
            $this->fieldFilter[$fieldName] = $fieldValue;
        }
    }

    /**
     * Perform SamsonCMS query and get entities collection.
     *
     * @return mixed[] Collection of found entities
     */
    public function find()
    {
        $return = array();
        /** @var array $idsByNavigation First step - filter by navigation */
        if (sizeof($idsByNavigation = (new MaterialNavigation())->idsByRelationID(static::$navigationIDs))) {
            // Second step filter by additional field value
            if (sizeof($this->fieldFilter)) {
                $return = (new MaterialField($idsByNavigation))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    ->byRelationID($this->fieldFilter[]);
            } else { // Just return entities filtered by navigation
                return (new Material($idsByNavigation, static::$identifier))->byIDs($idsByNavigation, 'exec');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }
        }

        return $return;
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: VITALYIEGOROV
5			* Date: 08.12.15
6			* Time: 23:11
7			*/
8			namespace samsoncms\api\query;
9
10			use samson\activerecord\dbQuery;
11
12			/**
13			* Material with additional fields query.
14			* @package samsoncms\api
15			*/
16			class Entity
17			{
18			/** @var string Entity identifier */
19			protected static $identifier;
20
21			/** @var string Entity navigation identifiers */
22			protected static $navigationIDs;
23
24			/** @var array Collection of entity field filter */
25			protected $fieldFilter;
26
27			/**
28			* Set additional entity field condition.
29			*
30			* @param string $fieldName Field identifier
31			* @param string $fieldValue Field value
32			* @return self Chaining
33			*/
34			public function where($fieldName, $fieldValue)
35			{
36			if (property_exists(static::$identifier, $fieldName)) {
37			$this->fieldFilter[$fieldName] = $fieldValue;
38			}
39			}
40
41			/**
42			* Perform SamsonCMS query and get entities collection.
43			*
44			* @return mixed[] Collection of found entities
45			*/
46			public function find()
47			{
48			$return = array();
49			/** @var array $idsByNavigation First step - filter by navigation */
50			if (sizeof($idsByNavigation = (new MaterialNavigation())->idsByRelationID(static::$navigationIDs))) {
51			// Second step filter by additional field value
52			if (sizeof($this->fieldFilter)) {
53			$return = (new MaterialField($idsByNavigation))
			0 ignored issues – show Documentation introduced 2015-12-09 16:30 UTC by Report Bug Copy Issue Report `$idsByNavigation` is of type `boolean\|object<samsonfra...rk\orm\RecordInterface>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			->byRelationID($this->fieldFilter[]);
55			} else { // Just return entities filtered by navigation
56			return (new Material($idsByNavigation, static::$identifier))->byIDs($idsByNavigation, 'exec');
			0 ignored issues – show Documentation introduced 2015-12-09 16:30 UTC by Report Bug Copy Issue Report `$idsByNavigation` is of type `boolean\|object<samsonfra...rk\orm\RecordInterface>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-12-09 16:30 UTC by Report Bug Copy Issue Report `$idsByNavigation` is of type `boolean\|object<samsonfra...rk\orm\RecordInterface>`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57			}
58			}
59
60			return $return;
61			}
62			}
63

samsoncms / api

Push — master ( 646730...43a697 )

Entity A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like