Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class RealCollection extends Generic |
||
18 | { |
||
19 | /** |
||
20 | * Query constructor. |
||
21 | * |
||
22 | * @param Generator $generator |
||
23 | * @param $metadata |
||
24 | */ |
||
25 | public function __construct(Generator $generator, $metadata) |
||
32 | |||
33 | /** |
||
34 | * Class uses generation part. |
||
35 | * |
||
36 | * @param RealMetadata $metadata Entity metadata |
||
37 | */ |
||
38 | protected function createUses($metadata) |
||
47 | |||
48 | /** |
||
49 | * Class definition generation part. |
||
50 | * |
||
51 | * @param RealMetadata $metadata Entity metadata |
||
52 | */ |
||
53 | protected function createDefinition($metadata) |
||
65 | |||
66 | /** |
||
67 | * Class constructor generation part. |
||
68 | * |
||
69 | * @param RealMetadata $metadata Entity metadata |
||
70 | */ |
||
71 | View Code Duplication | protected function createConstructor($metadata) |
|
86 | } |
||
87 | //[PHPCOMPRESSOR(remove,end)] |
||
88 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.