Lesson04\MaxProductOfThree

Complexity

Total Complexity

15

Size/Duplication

Total Lines	81
Duplicated Lines	12.35 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getPositives()	5	12	3
B	getNegatives()	5	23	6
B	solution()	0	23	6

<?php

namespace Lesson04;

class MaxProductOfThree
{
    public function solution($A)
    {
        sort($A);
        $allPositives = $this->getPositives($A);
        list($allNegatives, $twoNegatives) = $this->getNegatives($A, $allPositives);

        $maxProduct = null;
        $values = array_merge($allPositives, $allNegatives, $twoNegatives);
        $count = count($values);

        for ($i = 0; $i < $count - 2; $i++) {
            for ($j = $i + 1; $j < $count - 1; $j++) {
                for ($k = $j + 1; $k < $count; $k++) {
                    $product = $values[$i] * $values[$j] * $values[$k];
                    if (empty($maxProduct) || $product > $maxProduct) {
                        $maxProduct = $product;
                    }
                }
            }
        }

        return $maxProduct;
    }

    /**
     * @param $A
     *
     * @return array
     *
     * @internal param $arrayCount
     * @internal param $allPositives
     */
    private function getPositives($A)
    {
        $arrayCount = count($A);
        $allPositives = [];
        for ($i = $arrayCount - 3; $i < $arrayCount; $i++) {

This code seems to be duplicated across your project.

            if ($A[$i] >= 0) {
                $allPositives[] = $A[$i];
            }
        }

        return $allPositives;
    }

    /**
     * @param $A
     * @param $allPositives
     *
     * @return array
     *
     * @internal param $arrayCount
     * @internal param $allNegatives
     * @internal param $twoNegatives
     */
    private function getNegatives($A, $allPositives)
    {
        $arrayCount = count($A);
        $allNegatives = [];
        $twoNegatives = [];
        if (count($allPositives) === 0) {
            for ($i = $arrayCount - 3; $i < $arrayCount; $i++) {

This code seems to be duplicated across your project.

                if ($A[$i] < 0) {
                    $allNegatives[] = $A[$i];
                }
            }

            return [$allNegatives, $twoNegatives];
        } else {
            for ($i = 0; $i < 2; $i++) {
                if ($A[$i] < 0) {
                    $twoNegatives[] = $A[$i];
                }
            }

            return [$allNegatives, $twoNegatives];
        }
    }
}