MpesaController - Code Metrics - samerior/mobile-money - Measure and Improve Code Quality continuously with Scrutinizer

MpesaController A
last analyzed 2020-10-18 13:58 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	120
Duplicated Lines	49.17 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	59
loc	120
ccs	0
cts	35
cp	0
rs	10
c	0
b	0
f	0
wmc	8
lcom	1
cbo	4

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	timeout()	0	11	1
A	result()	11	11	1
A	paymentCallback()	10	10	1
A	confirmation()	10	10	1
A	callback()	9	9	1
A	stkCallback()	10	10	1
A	validatePayment()	9	9	1

How to fix Duplicated Code

<?php

namespace Samerior\MobileMoney\Mpesa\Http\Controllers;

use Samerior\MobileMoney\Mpesa\Events\QueueTimeoutEvent;
use Samerior\MobileMoney\Mpesa\Repositories\Mpesa;
use Illuminate\Http\Request;

/**
 * Class MpesaController
 * @package Samerior\MobileMoney\Http\Controllers
 */
class MpesaController extends Controller
{
    /**
     * @var Mpesa
     */
    private $repository;

    /**
     * MpesaController constructor.
     * @param Mpesa $repository
     */
    public function __construct(Mpesa $repository)
    {
        $this->repository = $repository;
    }

    /**
     * @param Request $request
     * @param string|null $initiator
     * @return \Illuminate\Http\JsonResponse
     */
    public function timeout(Request $request, $initiator = null)
    {
        $this->repository->notification('Queue timeout: *' . $initiator . '*');
        event(new QueueTimeoutEvent($request, $initiator));
        return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
                'ResponseCode' => '00000000',
                'ResponseDesc' => 'success'
            ]
        );
    }

    /**
     * @param string|null $initiator
     * @return \Illuminate\Http\JsonResponse
     */
    public function result($initiator = null)

    {
        $this->repository->notification('Incoming result: *' . $initiator . '*');
        $this->repository->handleResult($initiator);
        return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
                'ResponseCode' => '00000000',
                'ResponseDesc' => 'success'
            ]
        );
    }

    /**
     * @param string|null $initiator
     * @return \Illuminate\Http\JsonResponse
     */
    public function paymentCallback($initiator)

    {
        $this->repository->notification('Incoming payment callback: *' . $initiator . '*');
        return response()->json(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            [
                'ResponseCode' => '00000000',
                'ResponseDesc' => 'success'
            ]
        );
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function confirmation(Request $request)

    {
        $this->repository->notification('MPESA Confirmation: *C2B*', true);
        $this->repository->processConfirmation(json_encode($request->all()));
        $resp = [
            'ResultCode' => 0,
            'ResultDesc' => 'Confirmation received successfully',
        ];
        return response()->json($resp);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @return \Illuminate\Http\JsonResponse
     */
    public function callback()

    {
        $this->repository->notification('MPESA Callback: *C2B*', true);
        $resp = [
            'ResultCode' => 0,
            'ResultDesc' => 'Callback received successfully',
        ];
        return response()->json($resp);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function stkCallback(Request $request)

    {
        $this->repository->notification('MPESA STK Callback: *C2B*', true);
        $this->repository->processStkPushCallback(json_encode($request->Body));
        $resp = [
            'ResultCode' => 0,
            'ResultDesc' => 'STK Callback received successfully',
        ];
        return response()->json($resp);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @return \Illuminate\Http\JsonResponse
     */
    public function validatePayment()

    {
        $this->repository->notification('MPESA Validate Payment URL: *C2B*');
        $resp = [
            'ResultCode' => 0,
            'ResultDesc' => 'Validation passed successfully',
        ];
        return response()->json($resp);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace Samerior\MobileMoney\Mpesa\Http\Controllers;
4
5		use Samerior\MobileMoney\Mpesa\Events\QueueTimeoutEvent;
6		use Samerior\MobileMoney\Mpesa\Repositories\Mpesa;
7		use Illuminate\Http\Request;
8
9		/**
10		* Class MpesaController
11		* @package Samerior\MobileMoney\Http\Controllers
12		*/
13		class MpesaController extends Controller
14		{
15		/**
16		* @var Mpesa
17		*/
18		private $repository;
19
20		/**
21		* MpesaController constructor.
22		* @param Mpesa $repository
23		*/
24		public function __construct(Mpesa $repository)
25		{
26		$this->repository = $repository;
27		}
28
29		/**
30		* @param Request $request
31		* @param string\|null $initiator
32		* @return \Illuminate\Http\JsonResponse
33		*/
34		public function timeout(Request $request, $initiator = null)
35		{
36		$this->repository->notification('Queue timeout: ' . $initiator . '');
37		event(new QueueTimeoutEvent($request, $initiator));
38		return response()->json(
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39		[
40		'ResponseCode' => '00000000',
41		'ResponseDesc' => 'success'
42		]
43		);
44		}
45
46		/**
47		* @param string\|null $initiator
48		* @return \Illuminate\Http\JsonResponse
49		*/
50	View Code Duplication	public function result($initiator = null)
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$this->repository->notification('Incoming result: ' . $initiator . '');
53		$this->repository->handleResult($initiator);
54		return response()->json(
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55		[
56		'ResponseCode' => '00000000',
57		'ResponseDesc' => 'success'
58		]
59		);
60		}
61
62		/**
63		* @param string\|null $initiator
64		* @return \Illuminate\Http\JsonResponse
65		*/
66	View Code Duplication	public function paymentCallback($initiator)
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		$this->repository->notification('Incoming payment callback: ' . $initiator . '');
69		return response()->json(
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
70		[
71		'ResponseCode' => '00000000',
72		'ResponseDesc' => 'success'
73		]
74		);
75		}
76
77		/**
78		* @param Request $request
79		* @return \Illuminate\Http\JsonResponse
80		*/
81	View Code Duplication	public function confirmation(Request $request)
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$this->repository->notification('MPESA Confirmation: C2B', true);
84		$this->repository->processConfirmation(json_encode($request->all()));
85		$resp = [
86		'ResultCode' => 0,
87		'ResultDesc' => 'Confirmation received successfully',
88		];
89		return response()->json($resp);
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
90		}
91
92		/**
93		* @return \Illuminate\Http\JsonResponse
94		*/
95	View Code Duplication	public function callback()
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		{
97		$this->repository->notification('MPESA Callback: C2B', true);
98		$resp = [
99		'ResultCode' => 0,
100		'ResultDesc' => 'Callback received successfully',
101		];
102		return response()->json($resp);
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
103		}
104
105		/**
106		* @param Request $request
107		* @return \Illuminate\Http\JsonResponse
108		*/
109	View Code Duplication	public function stkCallback(Request $request)
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$this->repository->notification('MPESA STK Callback: C2B', true);
112		$this->repository->processStkPushCallback(json_encode($request->Body));
113		$resp = [
114		'ResultCode' => 0,
115		'ResultDesc' => 'STK Callback received successfully',
116		];
117		return response()->json($resp);
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
118		}
119
120		/**
121		* @return \Illuminate\Http\JsonResponse
122		*/
123	View Code Duplication	public function validatePayment()
		0 ignored issues – show Duplication introduced 2018-05-10 19:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124		{
125		$this->repository->notification('MPESA Validate Payment URL: C2B');
126		$resp = [
127		'ResultCode' => 0,
128		'ResultDesc' => 'Validation passed successfully',
129		];
130		return response()->json($resp);
		0 ignored issues – show Bug introduced 2019-06-06 19:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
131		}
132		}
133

samerior / mobile-money

MpesaController A last analyzed 2020-10-18 13:58 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

MpesaController A
last analyzed 2020-10-18 13:58 UTC