func.image-watermark.php ➔ watermark() - Code Metrics - Inspection of "add changes made into changelog" - samayo/bulletproof - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a42ab4)

by samayo

created 2017-07-28 22:36 UTC

func.image-watermark.php ➔ watermark() D

↳ Parent: Project

Complexity

Conditions	13
Paths	125

Size

Total Lines	86
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	62
nc	125
nop	8
dl	0
loc	86
rs	4.6605
c	0
b	0
f	0

How to fix Long Method Complexity Many Parameters

<?php
/**
 * Image Watermark Function.
 *
 * @author     D, Simon <[email protected]>
 * @link       https://github.com/samayo/bulletproof
 * @copyright  Copyright (c) 2015 Simon Daniel
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 */
namespace Bulletproof;

function watermark($image, $mimeType, $imgWidth, $imgHeight, $watermark, $watermarkHeight, $watermarkWidth, $position = "center")
{

    // Calculate the watermark position
    switch ($position) {
        case "center":
            $marginBottom = round($imgHeight / 2);
            $marginRight = round($imgWidth / 2) - round($watermarkWidth / 2);
            break;

        case "top-left":
            $marginBottom = round($imgHeight - $watermarkHeight);
            $marginRight = round($imgWidth - $watermarkWidth);
            break;

        case "bottom-left":
            $marginBottom = 5;
            $marginRight = round($imgWidth - $watermarkWidth);
            break;

        case "top-right":
            $marginBottom = round($imgHeight - $watermarkHeight);
            $marginRight = 5;
            break;

        default:
            $marginBottom = 2;
            $marginRight = 2;
            break;
    }


    $watermark = imagecreatefrompng($watermark);

    switch ($mimeType) {
        case "jpeg":
        case "jpg":
            $createImage = imagecreatefromjpeg($image);
            break;

        case "png":
            $createImage = imagecreatefrompng($image);
            break;

        case "gif":
            $createImage = imagecreatefromgif($image);
            break;

        default:
            $createImage = imagecreatefromjpeg($image);
            break;
    }

    $sx = imagesx($watermark);
    $sy = imagesy($watermark);
    imagecopy(
        $createImage,
        $watermark,
        imagesx($createImage) - $sx - $marginRight,
        imagesy($createImage) - $sy - $marginBottom,
        0,
        0,
        imagesx($watermark),
        imagesy($watermark)
    );


    switch ($mimeType) {
        case "jpeg":
        case "jpg":
            imagejpeg($createImage, $image);
            break;

        case "png":
            imagepng($createImage, $image);
            break;

        case "gif":
            imagegif($createImage, $image);
            break;

        default:
            throw new \Exception("A watermark can only be applied to: jpeg, jpg, gif, png images ");
            break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
}

1			<?php
2			/**
3			* Image Watermark Function.
4			*
5			* @author D, Simon <[email protected]>
6			* @link https://github.com/samayo/bulletproof
7			* @copyright Copyright (c) 2015 Simon Daniel
8			* @license http://www.opensource.org/licenses/mit-license.html MIT License
9			*/
10			namespace Bulletproof;
11
12			function watermark($image, $mimeType, $imgWidth, $imgHeight, $watermark, $watermarkHeight, $watermarkWidth, $position = "center")
13			{
14
15			// Calculate the watermark position
16			switch ($position) {
17			case "center":
18			$marginBottom = round($imgHeight / 2);
19			$marginRight = round($imgWidth / 2) - round($watermarkWidth / 2);
20			break;
21
22			case "top-left":
23			$marginBottom = round($imgHeight - $watermarkHeight);
24			$marginRight = round($imgWidth - $watermarkWidth);
25			break;
26
27			case "bottom-left":
28			$marginBottom = 5;
29			$marginRight = round($imgWidth - $watermarkWidth);
30			break;
31
32			case "top-right":
33			$marginBottom = round($imgHeight - $watermarkHeight);
34			$marginRight = 5;
35			break;
36
37			default:
38			$marginBottom = 2;
39			$marginRight = 2;
40			break;
41			}
42
43
44			$watermark = imagecreatefrompng($watermark);
45
46			switch ($mimeType) {
47			case "jpeg":
48			case "jpg":
49			$createImage = imagecreatefromjpeg($image);
50			break;
51
52			case "png":
53			$createImage = imagecreatefrompng($image);
54			break;
55
56			case "gif":
57			$createImage = imagecreatefromgif($image);
58			break;
59
60			default:
61			$createImage = imagecreatefromjpeg($image);
62			break;
63			}
64
65			$sx = imagesx($watermark);
66			$sy = imagesy($watermark);
67			imagecopy(
68			$createImage,
69			$watermark,
70			imagesx($createImage) - $sx - $marginRight,
71			imagesy($createImage) - $sy - $marginBottom,
72			0,
73			0,
74			imagesx($watermark),
75			imagesy($watermark)
76			);
77
78
79			switch ($mimeType) {
80			case "jpeg":
81			case "jpg":
82			imagejpeg($createImage, $image);
83			break;
84
85			case "png":
86			imagepng($createImage, $image);
87			break;
88
89			case "gif":
90			imagegif($createImage, $image);
91			break;
92
93			default:
94			throw new \Exception("A watermark can only be applied to: jpeg, jpg, gif, png images ");
95			break;
			0 ignored issues – show Unused Code introduced 2015-11-21 00:26 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
96			}
97			}

samayo / bulletproof

Branch — master (a42ab4)

func.image-watermark.php ➔ watermark() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like