func.image-watermark.php ➔ watermark() - Code Metrics - Inspection of "fix: reverse the order of variables passed to list..." - samayo/bulletproof - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d09fc3...fde49e )

by samayo

created 2016-06-29 15:19 UTC

func.image-watermark.php ➔ watermark() D

↳ Parent: Project

Complexity

Conditions	13
Paths	125

Size

Total Lines	85
Code Lines	62

Duplication

Lines	18
Ratio	21.18 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	13
eloc	62
c	1
b	0
f	1
nc	125
nop	8
dl	18
loc	85
rs	4.6605

How to fix Long Method Complexity Many Parameters

<?php
/**
 * Image Watermark Function. 
 *
 * @author     D, Simon <[email protected]>
 * @link       https://github.com/samayo/bulletproof
 * @copyright  Copyright (c) 2015 Simon Daniel
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 */
namespace Bulletproof;

 function watermark($image, $mimeType, $imgWidth, $imgHeight, $watermark, $watermarkHeight, $watermarkWidth, $position = "center"){

    // Calculate the watermark position
    switch ($position) {
        case "center":
            $marginBottom  = round($imgHeight / 2);
            $marginRight   = round($imgWidth / 2) - round($watermarkWidth / 2);
            break;

        case "top-left":
            $marginBottom  = round($imgHeight - $watermarkHeight);
            $marginRight   = round($imgWidth - $watermarkWidth);
            break;

        case "bottom-left":
            $marginBottom  = 5;
            $marginRight   = round($imgWidth - $watermarkWidth);
            break;

        case "top-right":
            $marginBottom  = round($imgHeight - $watermarkHeight);
            $marginRight   = 5;
            break;

        default:
            $marginBottom  = 2;
            $marginRight   = 2;
            break;
    }


    $watermark = imagecreatefrompng($watermark);

    switch ($mimeType) {
        case "jpeg":
        case "jpg":
            $createImage = imagecreatefromjpeg($image);
            break;

        case "png":
            $createImage = imagecreatefrompng($image);
            break;

        case "gif":
            $createImage = imagecreatefromgif($image);
            break;

        default:
            $createImage = imagecreatefromjpeg($image);
            break;
    }

    $sx = imagesx($watermark);
    $sy = imagesy($watermark);
    imagecopy(
        $createImage,
        $watermark,
        imagesx($createImage) - $sx - $marginRight,
        imagesy($createImage) - $sy - $marginBottom,
        0,
        0,
        imagesx($watermark),
        imagesy($watermark)
    );


    switch ($mimeType) {

        case "jpeg":
        case "jpg":
             imagejpeg($createImage, $image);
            break;

        case "png":
             imagepng($createImage, $image);
            break;

        case "gif":
             imagegif($createImage, $image);
            break;

        default:
            throw new \Exception("A watermark can only be applied to: jpeg, jpg, gif, png images ");
            break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
}

1		<?php
2		/**
3		* Image Watermark Function.
4		*
5		* @author D, Simon <[email protected]>
6		* @link https://github.com/samayo/bulletproof
7		* @copyright Copyright (c) 2015 Simon Daniel
8		* @license http://www.opensource.org/licenses/mit-license.html MIT License
9		*/
10		namespace Bulletproof;
11
12		function watermark($image, $mimeType, $imgWidth, $imgHeight, $watermark, $watermarkHeight, $watermarkWidth, $position = "center"){
13
14		// Calculate the watermark position
15		switch ($position) {
16		case "center":
17		$marginBottom = round($imgHeight / 2);
18		$marginRight = round($imgWidth / 2) - round($watermarkWidth / 2);
19		break;
20
21		case "top-left":
22		$marginBottom = round($imgHeight - $watermarkHeight);
23		$marginRight = round($imgWidth - $watermarkWidth);
24		break;
25
26		case "bottom-left":
27		$marginBottom = 5;
28		$marginRight = round($imgWidth - $watermarkWidth);
29		break;
30
31		case "top-right":
32		$marginBottom = round($imgHeight - $watermarkHeight);
33		$marginRight = 5;
34		break;
35
36		default:
37		$marginBottom = 2;
38		$marginRight = 2;
39		break;
40		}
41
42
43		$watermark = imagecreatefrompng($watermark);
44
45		switch ($mimeType) {
46		case "jpeg":
47		case "jpg":
48		$createImage = imagecreatefromjpeg($image);
49		break;
50
51		case "png":
52		$createImage = imagecreatefrompng($image);
53		break;
54
55		case "gif":
56		$createImage = imagecreatefromgif($image);
57		break;
58
59		default:
60		$createImage = imagecreatefromjpeg($image);
61		break;
62		}
63
64		$sx = imagesx($watermark);
65		$sy = imagesy($watermark);
66		imagecopy(
67		$createImage,
68		$watermark,
69		imagesx($createImage) - $sx - $marginRight,
70		imagesy($createImage) - $sy - $marginBottom,
71		0,
72		0,
73		imagesx($watermark),
74		imagesy($watermark)
75		);
76
77
78	View Code Duplication	switch ($mimeType) {
		0 ignored issues – show Duplication introduced 2015-11-21 00:26 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		case "jpeg":
80		case "jpg":
81		imagejpeg($createImage, $image);
82		break;
83
84		case "png":
85		imagepng($createImage, $image);
86		break;
87
88		case "gif":
89		imagegif($createImage, $image);
90		break;
91
92		default:
93		throw new \Exception("A watermark can only be applied to: jpeg, jpg, gif, png images ");
94		break;
		0 ignored issues – show Unused Code introduced 2015-11-21 00:26 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
95		}
96		}

samayo / bulletproof

Push — master ( d09fc3...fde49e )

func.image-watermark.php ➔ watermark() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like