ShortListItem

Complexity

Total Complexity

1

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getActualRecord()	0	4	1

<?php

/*
 * @file ShortListItem.php
 *
 * An item that gets added to a shortlist.
 *
 * Any DataObject that is attached to a ShortListItem **MUST**:
 *
 * * Provide Link() & AbsoluteLink() functions.
 * * Provide a preview for the item with forTemplate()
 *
 **/
class ShortListItem extends DataObject
{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

Tabs must be used to indent lines; spaces are not allowed

        'ItemType'  => 'Varchar(128)',

Tabs must be used to indent lines; spaces are not allowed

        'ItemID'    => 'Varchar(12)'

Tabs must be used to indent lines; spaces are not allowed

    );

Tabs must be used to indent lines; spaces are not allowed

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

Tabs must be used to indent lines; spaces are not allowed

        'ShortList' => 'ShortList'

Tabs must be used to indent lines; spaces are not allowed

    );

Tabs must be used to indent lines; spaces are not allowed

    public function getActualRecord()

Tabs must be used to indent lines; spaces are not allowed

    {

Opening brace should be on the same line as the declaration

Tabs must be used to indent lines; spaces are not allowed

        return DataObject::get_by_id($this->ItemType, $this->ItemID);

The property ItemType does not exist on object<ShortListItem>. Since you implemented __get, maybe consider adding a @property annotation.

The property ItemID does not exist on object<ShortListItem>. Since you implemented __get, maybe consider adding a @property annotation.

Tabs must be used to indent lines; spaces are not allowed

    }

Tabs must be used to indent lines; spaces are not allowed

}