CustomBlockPermission

Complexity

Total Complexity

9

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	canConfigPageAndType()	0	3	1
A	canConfigMemberVisibility()	0	3	1
A	providePermissions()	0	12	3
A	getClassList()	0	12	4

<?php 

class CustomBlockPermission extends DataExtension implements PermissionProvider {
	public function canConfigPageAndType($member = false) {

The parameter $member is not used and could be removed.

		return Permission::check(get_class($this->owner) . '_config_page_and_type');
	}
	
	public function canConfigMemberVisibility($member = false) {

The parameter $member is not used and could be removed.

		return Permission::check(get_class($this->owner) . '_config_member_visibility');
	}
	
	public function providePermissions() {
		$permissions = array();
		foreach ($this->getClassList() as $class) {
			foreach (array(
				'config_page_and_type',
				'config_member_visibility'
			) as $name) {
				$permissions[$class . '_' . $name] = $class . '_' . $name;
			}
		}
		return $permissions;
	}
	
	private function getClassList() {
		$classes = array();
		foreach (ClassInfo::subclassesFor('DataObject') as $class => $file) {

The expression \ClassInfo::subclassesFor('DataObject') of type null|array is not guaranteed to be traversable. How about adding an additional type check?

			$extensions = Config::inst()->get($class, 'extensions');
			if (!is_null($extensions)) {
				if (in_array(get_class($this), $extensions)) {
					$classes[] = $class;
				}
			}
		}
		return $classes;
	}
}