VersionedForm_ItemRequest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	ItemEditForm()	0	18	4
A	doUnpublish()	0	6	1
A	doPublish()	0	9	1

<?php

use SaltedHerring\Debugger as Debugger;

class VersionedForm extends GridFieldDetailForm {
	
}

class VersionedForm_ItemRequest extends GridFieldDetailForm_ItemRequest {
	private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

		'edit',
		'view',
		'ItemEditForm',
		'doPublish',
		'doUnpublish'
	);
		
	public function ItemEditForm() {
		$form = parent::ItemEditForm();
		if ($form instanceof Form) {
			$actions = $form->Actions();
			$record = $this->record;
			$actions->insertBefore('action_doDelete', $btnPublish = FormAction::create('doPublish','Save & Publish'));
			$btnPublish->addExtraClass('ss-ui-action-constructive');
			if (!empty($record->ID)) {
				if ($record->isPublished()) {
					$actions->removeByName('action_doDelete');
					$actions->push(FormAction::create('doUnpublish', 'Unpublish')->addExtraClass('ss-ui-action-destructive'));
				}
			}
			
			$form->setActions($actions);

It seems like $actions defined by $form->Actions() on line 21 can be null; however, Form::setActions() does not accept null, maybe add an additional type check?

		}
		return $form;
	}
	
	public function doUnpublish($data, $form) {

The parameter $data is not used and could be removed.

		$this->record->deleteFromStage('Live');
		$controller = Controller::curr();
		$form->sessionMessage('Block unpublished', 'good', false);
		return $this->edit($controller->getRequest());
	}
	
	public function doPublish($data, $form) {

The parameter $data is not used and could be removed.

		$form->saveInto($this->record);
		$this->record->write();
		$this->record->byPass = true;
		$this->record->doPublish();
		$form->sessionMessage('Block published', 'good', false);
		$controller = Controller::curr();
		return $this->edit($controller->getRequest());
	}
}