Dicom_Web_Access

Complexity

Total Complexity

21

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getUID()	0	8	3
A	getDecision()	0	6	1
B	getRelatedVisitID()	0	13	7
B	isAccessAllowedForUser()	0	21	7
A	endsWith()	0	2	1
A	__construct()	0	8	2

<?php
/**
 Copyright (C) 2018-2020 KANOUN Salim
 This program is free software; you can redistribute it and/or modify
 it under the terms of the Affero GNU General Public v.3 License as published by
 the Free Software Foundation;
 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 Affero GNU General Public Public for more details.
 You should have received a copy of the Affero GNU General Public Public along
 with this program; if not, write to the Free Software Foundation, Inc.,
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 */

/**
 * Check access for each call of the DICOMWeb Protocol (for OHIF / Viewer integration)
 * @author salim
 *
 */
class Dicom_Web_Access {

	private $isStudyMetadataRequested;
	private $isSerieRequested;
	private $requestedURI;
	private $userObject;
	private $userRole;
	private $linkpdo;
    
	public function __construct(string $requestedURI, User $userObject, string $userRole, PDO $linkpdo) {
		$this->requestedURI=$requestedURI;
		$this->userObject=$userObject;
		$this->userRole=$userRole;
		$this->linkpdo=$linkpdo;
        
		if ($this->endsWith($requestedURI, "/series")) $this->isStudyMetadataRequested=true; 
		else $this->isSerieRequested=true;
        
	}
    
	/**
	 * Output the decision for access allowance
	 * @return boolean
	 */
	public function getDecision() {
		//Get related visit ID of the called ressource
		$id_visit=$this->getRelatedVisitID($this->getUID());
        
		//Return test of acess allowance
		return $this->isAccessAllowedForUser($id_visit);
	}
    
	/**
	 * Isolate the called Study or Series Instance UID 
	 * @return string
	 */
	private function getUID() {
		if ($this->isSerieRequested) $level="series";
		else if ($this->isStudyMetadataRequested) $level="studies";
		$studySubString=strstr($this->requestedURI, "/".$level."/");

The variable $level does not seem to be defined for all execution paths leading up to this point.

		$studySubString=str_replace("/".$level."/", "", $studySubString);
		$endStudyUIDPosition=strpos($studySubString, "/");
		$studyUID=substr($studySubString, 0, $endStudyUIDPosition);
		return $studyUID;
	}
    
	/**
	 * Check if called ressource is allowed for current user
	 * @param string $uid
	 * @return string
	 */
	private function getRelatedVisitID(string $uid) {
       
		if ($this->isSerieRequested) {
			$seriesObject=Series_Details::getSerieObjectByUID($uid, $this->linkpdo);
			if ($this->userRole != User::SUPERVISOR && $seriesObject->deleted) throw new Exception('Deleted Series');
			$studyObject=$seriesObject->studyDetailsObject;
            
		}else if ($this->isStudyMetadataRequested) {
			$studyObject=Study_Details::getStudyObjectByUID($uid, $this->linkpdo);
			if ($this->userRole != User::SUPERVISOR && $studyObject->deleted) throw new Exception('Deleted Study');
		}
        
		return $studyObject->idVisit;

The variable $studyObject does not seem to be defined for all execution paths leading up to this point.

        
	}
    
	/**
	 * Check that visit is granter for the calling user (still awaiting review or still awaiting QC)
	 * @param string $id_visit
	 * @return boolean
	 */
	private function isAccessAllowedForUser(string $id_visit) {
        
		$visitObject=new Visit($id_visit, $this->linkpdo);
        
		//Check Visit Availability of the calling user
		if ($this->userRole == User::REVIEWER || ($this->userRole == User::INVESTIGATOR && $visitObject->uploadStatus == Visit::DONE)) {
			//Check that visit is in patient that is still awaiting for some reviews
			$visitCheck=$this->userObject->isVisitAllowed($id_visit, $this->userRole);
		}else if ($this->userRole == User::CONTROLLER) {
			//Check that QC status still require an action from Controller
			if (in_array($visitObject->stateQualityControl, array(Visit::QC_WAIT_DEFINITVE_CONCLUSION, Visit::QC_NOT_DONE))) {
				$visitCheck=$this->userObject->isVisitAllowed($id_visit, $this->userRole);
			}
		}else if ($this->userRole == User::SUPERVISOR) {
			$visitCheck=$this->userObject->isVisitAllowed($id_visit, $this->userRole);
		}else {
			//Other roles can't have access to images
			$visitCheck=false;
		}
        
		return $visitCheck;

The variable $visitCheck does not seem to be defined for all execution paths leading up to this point.

        
	}

	private function endsWith($haystack, $needle) {
		return substr_compare($haystack, $needle, -strlen($needle)) === 0;
	}

}