Subscription::getStartDate() - Code Metrics - Inspection of "Merge pull request #1 from sagitarius29/develop" - sagitarius29/laravel-subscriptions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e68c06...8ce3f9 )

by Adolfo

created 2019-10-29 02:57 UTC

Subscription::getStartDate() A

↳ Parent: Subscription

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Sagitarius29\LaravelSubscriptions\Entities;

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;
use Sagitarius29\LaravelSubscriptions\Contracts\PlanContract;
use Sagitarius29\LaravelSubscriptions\Contracts\SubscriptionContact;

class Subscription extends Model implements SubscriptionContact
{
    protected $table = 'subscriptions';

    protected $fillable = [
        'plan_id', 'start_at', 'end_at',
    ];

    public function scopeCurrent(Builder $q, Carbon $date)
    {
        return $q->where('start_at', '<', $date)
            ->where('end_at', '>', $date);
    }

    public function isPerpetual(): bool
    {
        return $this->end_at == null;
    }

    public function getDaysLeft(): int
    {
        // TODO: Implement getDaysLeft() method.
    }

    public function getElapsedDays(): int
    {
        // TODO: Implement getElapsedDays() method.
    }

    public function getExpirationDate(): ?Carbon
    {
        // TODO: Implement getExpirationDate() method.
    }

    public function getStartDate(): ?Carbon
    {
        // TODO: Implement getStartDate() method.
    }

    public function subscriber()
    {
        // TODO: Implement subscriber() method.
    }

    public static function make(PlanContract $plan, Carbon $start_at, Carbon $end_at = null): Model
    {
        return new self([
            'plan_id'   => $plan->id,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'start_at'  => $start_at,
            'end_at'    => $end_at,
        ]);
    }
}


1			<?php
2
3			namespace Sagitarius29\LaravelSubscriptions\Entities;
4
5			use Carbon\Carbon;
6			use Illuminate\Database\Eloquent\Model;
7			use Illuminate\Database\Eloquent\Builder;
8			use Sagitarius29\LaravelSubscriptions\Contracts\PlanContract;
9			use Sagitarius29\LaravelSubscriptions\Contracts\SubscriptionContact;
10
11			class Subscription extends Model implements SubscriptionContact
12			{
13			protected $table = 'subscriptions';
14
15			protected $fillable = [
16			'plan_id', 'start_at', 'end_at',
17			];
18
19			public function scopeCurrent(Builder $q, Carbon $date)
20			{
21			return $q->where('start_at', '<', $date)
22			->where('end_at', '>', $date);
23			}
24
25			public function isPerpetual(): bool
26			{
27			return $this->end_at == null;
28			}
29
30			public function getDaysLeft(): int
31			{
32			// TODO: Implement getDaysLeft() method.
33			}
34
35			public function getElapsedDays(): int
36			{
37			// TODO: Implement getElapsedDays() method.
38			}
39
40			public function getExpirationDate(): ?Carbon
41			{
42			// TODO: Implement getExpirationDate() method.
43			}
44
45			public function getStartDate(): ?Carbon
46			{
47			// TODO: Implement getStartDate() method.
48			}
49
50			public function subscriber()
51			{
52			// TODO: Implement subscriber() method.
53			}
54
55			public static function make(PlanContract $plan, Carbon $start_at, Carbon $end_at = null): Model
56			{
57			return new self([
58			'plan_id' => $plan->id,
			0 ignored issues – show Bug introduced 2019-10-29 02:10 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Sagitarius29\LaravelSubs...\Contracts\PlanContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59			'start_at' => $start_at,
60			'end_at' => $end_at,
61			]);
62			}
63			}
64

sagitarius29 / laravel-subscriptions

Push — master ( e68c06...8ce3f9 )

Subscription::getStartDate() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like