HasFeatures::addFeatures() - Code Metrics - Inspection of "Merge pull request #7 from sagitarius29/develop" - sagitarius29/laravel-subscriptions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c4859...5ed06f )

by Adolfo

created 2019-11-12 21:34 UTC

HasFeatures::addFeatures() A

↳ Parent: HasFeatures

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Sagitarius29\LaravelSubscriptions\Traits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Sagitarius29\LaravelSubscriptions\PlanFeature;

trait HasFeatures
{
    /**
     * @param  PlanFeature|Model  $feature
     */
    public function addFeature(PlanFeature $feature)
    {
        $this->features()->save($feature);
    }

    public function features(): HasMany
    {
        return $this->hasMany(config('subscriptions.entities.plan_feature'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function addFeatures(array $features)
    {
        $this->features()->saveMany($features);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getFeatureByCode($featureCode)
    {
        return $this->features()->whereCode($featureCode)->first();
    }

    public function hasFeatures(): bool
    {
        return $this->features()->exists();
    }
}


1			<?php
2
3			namespace Sagitarius29\LaravelSubscriptions\Traits;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Database\Eloquent\Relations\HasMany;
7			use Sagitarius29\LaravelSubscriptions\PlanFeature;
8
9			trait HasFeatures
10			{
11			/**
12			* @param PlanFeature\|Model $feature
13			*/
14			public function addFeature(PlanFeature $feature)
15			{
16			$this->features()->save($feature);
17			}
18
19			public function features(): HasMany
20			{
21			return $this->hasMany(config('subscriptions.entities.plan_feature'));
			0 ignored issues – show Bug introduced 2019-11-12 19:25 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			}
23
24			public function addFeatures(array $features)
25			{
26			$this->features()->saveMany($features);
			0 ignored issues – show Documentation introduced 2019-11-12 14:41 UTC by Report Bug Copy Issue Report `$features` is of type `array`, but the function expects a `object<Illuminate\Databa...ent\Relations\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			}
28
29			public function getFeatureByCode($featureCode)
30			{
31			return $this->features()->whereCode($featureCode)->first();
32			}
33
34			public function hasFeatures(): bool
35			{
36			return $this->features()->exists();
37			}
38			}
39

sagitarius29 / laravel-subscriptions

Push — master ( 2c4859...5ed06f )

HasFeatures::addFeatures() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like