HasSubscriptions::subscribeTo() - Code Metrics - Inspection of "Added test for subscriptions" - sagitarius29/laravel-subscriptions - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 6deca1...bf40a6 )

by Adolfo

created 2019-10-29 02:09 UTC

HasSubscriptions::subscribeTo() A

↳ Parent: HasSubscriptions

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0
cc	3
nc	4
nop	1

<?php


namespace Sagitarius29\LaravelSubscriptions\Traits;


use Sagitarius29\LaravelSubscriptions\Contracts\PlanContract;
use Sagitarius29\LaravelSubscriptions\Contracts\SubscribableContract;
use Sagitarius29\LaravelSubscriptions\Contracts\SubscriptionContact;
use Sagitarius29\LaravelSubscriptions\Entities\Plan;
use Sagitarius29\LaravelSubscriptions\Entities\Subscription;

trait HasSubscriptions
{
    public function subscriptions()
    {
        return $this->morphMany(config('subscriptions.entities.plan_subscription'), 'subscriber');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function subscribeTo(PlanContract $plan)
    {
        $currentSubscription = $this->getCurrentSubscription();
        $start_at = null;
        $end_at = null;

        if($currentSubscription == null) {
            $start_at = now();
        }

        if($plan->isFree()) {
            $end_at = null;
        }

        $subscription = Subscription::make($plan, $start_at, $end_at);
        $subscription = $this->subscriptions()->save($subscription);

        return $subscription;
    }

    public function changePlanTo(PlanContract $plan)

    {

    }

    public function renewSubscription(): bool
    {

    }

    public function cancelSubscription(): bool
    {

    }

    public function getCurrentSubscription(): ?SubscriptionContact
    {
        return $this->subscriptions()
            ->current(now())
            ->first();
    }

    public function getConsumables()
    {

    }
}


1			<?php
2
3
4			namespace Sagitarius29\LaravelSubscriptions\Traits;
5
6
7			use Sagitarius29\LaravelSubscriptions\Contracts\PlanContract;
8			use Sagitarius29\LaravelSubscriptions\Contracts\SubscribableContract;
9			use Sagitarius29\LaravelSubscriptions\Contracts\SubscriptionContact;
10			use Sagitarius29\LaravelSubscriptions\Entities\Plan;
11			use Sagitarius29\LaravelSubscriptions\Entities\Subscription;
12
13			trait HasSubscriptions
14			{
15			public function subscriptions()
16			{
17			return $this->morphMany(config('subscriptions.entities.plan_subscription'), 'subscriber');
			0 ignored issues – show Bug introduced 2019-10-29 02:10 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			}
19
20			public function subscribeTo(PlanContract $plan)
21			{
22			$currentSubscription = $this->getCurrentSubscription();
23			$start_at = null;
24			$end_at = null;
25
26			if($currentSubscription == null) {
27			$start_at = now();
28			}
29
30			if($plan->isFree()) {
31			$end_at = null;
32			}
33
34			$subscription = Subscription::make($plan, $start_at, $end_at);
35			$subscription = $this->subscriptions()->save($subscription);
36
37			return $subscription;
38			}
39
40			public function changePlanTo(PlanContract $plan)
			0 ignored issues – show Unused Code introduced 2019-10-29 02:10 UTC by Report Bug Copy Issue Report The parameter `$plan` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
41			{
42
43			}
44
45			public function renewSubscription(): bool
46			{
47
48			}
49
50			public function cancelSubscription(): bool
51			{
52
53			}
54
55			public function getCurrentSubscription(): ?SubscriptionContact
56			{
57			return $this->subscriptions()
58			->current(now())
59			->first();
60			}
61
62			public function getConsumables()
63			{
64
65			}
66			}
67

sagitarius29 / laravel-subscriptions

Push — develop ( 6deca1...bf40a6 )

HasSubscriptions::subscribeTo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like