MakeCrud::generate() - Code Metrics - Inspection of "crud-maker-bundle-13 unimplemented abstract method..." - sadikoff/crud-maker-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f62883...154da5 )

by Vladimir

created 2018-02-24 13:01 UTC

MakeCrud::generate() B

↳ Parent: MakeCrud

Complexity

Conditions	2
Paths	2

Size

Total Lines	111
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	80
nc	2
nop	3
dl	0
loc	111
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Koff\Bundle\CrudMakerBundle\Maker;

use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
filter:
    dependency_paths: ["lib/*"]
use Doctrine\Common\Inflector\Inflector;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Mapping\Column;
use Koff\Bundle\CrudMakerBundle\GeneratorHelper;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Bundle\MakerBundle\ConsoleStyle;
use Symfony\Bundle\MakerBundle\DependencyBuilder;
use Symfony\Bundle\MakerBundle\Generator;
use Symfony\Bundle\MakerBundle\InputConfiguration;
use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
use Symfony\Bundle\MakerBundle\Str;
use Symfony\Bundle\MakerBundle\Validator;
use Symfony\Bundle\TwigBundle\TwigBundle;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Form\AbstractType;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Security\Csrf\CsrfTokenManager;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\Validator\Validation;
filter:
    dependency_paths: ["lib/*"]

/**
 * @author Sadicov Vladimir <[email protected]>
 */
final class MakeCrud extends AbstractMaker
{
    private $entityManager;

    public function __construct(EntityManagerInterface $entityManager)
    {
        $this->entityManager = $entityManager;
    }

    public static function getCommandName(): string
    {
        return 'make:crud';
    }

    /**
     * {@inheritdoc}
     */
    public function configureCommand(Command $command, InputConfiguration $inputConfig)
    {
        $command
            ->setDescription('Creates crud for Doctrine entity class')
            ->addArgument('entity-class', InputArgument::OPTIONAL, sprintf('The class name of the entity to create crud (e.g. <fg=yellow>%s</>)', Str::asClassName(Str::getRandomTerm())))
            ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeCrud.txt'))
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function configureDependencies(DependencyBuilder $dependencies)
    {
        $dependencies->addClassDependency(
            Route::class,
            'annotations'
        );

        $dependencies->addClassDependency(
            AbstractType::class,
            'form'
        );

        $dependencies->addClassDependency(
            Validation::class,
            'validator'
        );

        $dependencies->addClassDependency(
            TwigBundle::class,
            'twig-bundle'
        );

        $dependencies->addClassDependency(
            DoctrineBundle::class,
            'orm'
        );

        $dependencies->addClassDependency(
            Column::class,
            'orm'
        );

        $dependencies->addClassDependency(
            CsrfTokenManager::class,
            'security-csrf'
        );
    }

    public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
    {
        $entityClassNameDetails = $generator->createClassNameDetails(
            $input->getArgument('entity-class'),
            'Entity\\'
        );

        $controllerClassNameDetails = $generator->createClassNameDetails(
            $entityClassNameDetails->getRelativeNameWithoutSuffix(),
            'Controller\\',
            'Controller'
        );

        $formClassNameDetails = $generator->createClassNameDetails(
            $entityClassNameDetails->getRelativeNameWithoutSuffix(),
            'Form\\',
            'Type'
        );

        $metadata = $this->entityManager->getClassMetadata($entityClassNameDetails->getFullName());
        $entityVarPlural = lcfirst(Inflector::pluralize($entityClassNameDetails->getShortName()));
        $entityVarSingular = lcfirst(Inflector::singularize($entityClassNameDetails->getShortName()));
        $routeName = Str::asRouteName($controllerClassNameDetails->getRelativeNameWithoutSuffix());

        $generator->generateClass(
            $controllerClassNameDetails->getFullName(),
            'crud/controller/Controller.tpl.php',
            [
                'entity_full_class_name' => $entityClassNameDetails->getFullName(),
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'form_full_class_name' => $formClassNameDetails->getFullName(),
                'form_class_name' => $formClassNameDetails->getShortName(),
                'route_path' => Str::asRoutePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
                'route_name' => $routeName,
                'entity_var_plural' => $entityVarPlural,
                'entity_var_singular' => $entityVarSingular,
                'entity_identifier' => $metadata->identifier[0],

            ]
        );

        $helper = new GeneratorHelper();

        $generator->generateClass(
            $formClassNameDetails->getFullName(),
            'form/crud/Type.tpl.php',
            [
                'entity_class_exists' => true,
                'entity_full_class_name' => $entityClassNameDetails->getFullName(),
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'entity_fields' => $metadata->fieldMappings,

                'helper' => $helper,
            ]
        );

        $baseLayoutExists = true;
        $templatesPath = Str::asFilePath($controllerClassNameDetails->getRelativeNameWithoutSuffix());

        $templates = [
            '_delete_form' => [
                'route_name' => $routeName,
                'entity_identifier' => $metadata->identifier[0],
            ],
            '_form' => [],
            'edit' => [
                'helper' => $helper,
                'base_layout_exists' => $baseLayoutExists,
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'entity_var_singular' => $entityVarSingular,
                'entity_identifier' => $metadata->identifier[0],
                'route_name' => $routeName,
            ],
            'index' => [
                'helper' => $helper,
                'base_layout_exists' => $baseLayoutExists,
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'entity_var_plural' => $entityVarPlural,
                'entity_var_singular' => $entityVarSingular,
                'entity_identifier' => $metadata->identifier[0],
                'entity_fields' => $metadata->fieldMappings,
                'route_name' => $routeName,
            ],
            'new' => [
                'helper' => $helper,
                'base_layout_exists' => $baseLayoutExists,
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'route_name' => $routeName,
            ],
            'show' => [
                'helper' => $helper,
                'base_layout_exists' => $baseLayoutExists,
                'entity_class_name' => $entityClassNameDetails->getShortName(),
                'entity_var_singular' => $entityVarSingular,
                'entity_identifier' => $metadata->identifier[0],
                'entity_fields' => $metadata->fieldMappings,
                'route_name' => $routeName,
            ],
        ];

        foreach ($templates as $template => $variables) {
            $generator->generateFile(
                'templates/'.$templatesPath.'/'.$template.'.html.twig',
                'crud/templates/'.$template.'.tpl.php',
                $variables
            );
        }

        $generator->writeChanges();

        $this->writeSuccessMessage($io);

        $io->text('Next: Check your new crud!');
    }
}


1			<?php
2
3			namespace Koff\Bundle\CrudMakerBundle\Maker;
4
5			use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
			0 ignored issues – show Bug introduced 2018-02-13 20:05 UTC by Report Bug Copy Issue Report The type `Doctrine\Bundle\DoctrineBundle\DoctrineBundle` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
6			use Doctrine\Common\Inflector\Inflector;
7			use Doctrine\ORM\EntityManagerInterface;
8			use Doctrine\ORM\Mapping\Column;
9			use Koff\Bundle\CrudMakerBundle\GeneratorHelper;
10			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
			0 ignored issues – show Bug introduced 2018-02-12 21:34 UTC by Report Bug Copy Issue Report The type `Sensio\Bundle\FrameworkE...dle\Configuration\Route` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Symfony\Bundle\MakerBundle\ConsoleStyle;
12			use Symfony\Bundle\MakerBundle\DependencyBuilder;
13			use Symfony\Bundle\MakerBundle\Generator;
14			use Symfony\Bundle\MakerBundle\InputConfiguration;
15			use Symfony\Bundle\MakerBundle\Maker\AbstractMaker;
16			use Symfony\Bundle\MakerBundle\Str;
17			use Symfony\Bundle\MakerBundle\Validator;
18			use Symfony\Bundle\TwigBundle\TwigBundle;
			0 ignored issues – show Bug introduced 2018-02-12 21:34 UTC by Report Bug Copy Issue Report The type `Symfony\Bundle\TwigBundle\TwigBundle` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19			use Symfony\Component\Console\Command\Command;
20			use Symfony\Component\Console\Input\InputArgument;
21			use Symfony\Component\Console\Input\InputInterface;
22			use Symfony\Component\Form\AbstractType;
			0 ignored issues – show Bug introduced 2018-02-13 20:05 UTC by Report Bug Copy Issue Report The type `Symfony\Component\Form\AbstractType` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
23			use Symfony\Component\Security\Csrf\CsrfTokenManager;
			0 ignored issues – show Bug introduced 2018-02-16 14:36 UTC by Report Bug Copy Issue Report The type `Symfony\Component\Security\Csrf\CsrfTokenManager` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
24			use Symfony\Component\Validator\Validation;
			0 ignored issues – show Bug introduced 2018-02-13 20:05 UTC by Report Bug Copy Issue Report The type `Symfony\Component\Validator\Validation` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
25
26			/**
27			* @author Sadicov Vladimir <[email protected]>
28			*/
29			final class MakeCrud extends AbstractMaker
30			{
31			private $entityManager;
32
33			public function __construct(EntityManagerInterface $entityManager)
34			{
35			$this->entityManager = $entityManager;
36			}
37
38			public static function getCommandName(): string
39			{
40			return 'make:crud';
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function configureCommand(Command $command, InputConfiguration $inputConfig)
47			{
48			$command
49			->setDescription('Creates crud for Doctrine entity class')
50			->addArgument('entity-class', InputArgument::OPTIONAL, sprintf('The class name of the entity to create crud (e.g. <fg=yellow>%s</>)', Str::asClassName(Str::getRandomTerm())))
51			->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeCrud.txt'))
52			;
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function configureDependencies(DependencyBuilder $dependencies)
59			{
60			$dependencies->addClassDependency(
61			Route::class,
62			'annotations'
63			);
64
65			$dependencies->addClassDependency(
66			AbstractType::class,
67			'form'
68			);
69
70			$dependencies->addClassDependency(
71			Validation::class,
72			'validator'
73			);
74
75			$dependencies->addClassDependency(
76			TwigBundle::class,
77			'twig-bundle'
78			);
79
80			$dependencies->addClassDependency(
81			DoctrineBundle::class,
82			'orm'
83			);
84
85			$dependencies->addClassDependency(
86			Column::class,
87			'orm'
88			);
89
90			$dependencies->addClassDependency(
91			CsrfTokenManager::class,
92			'security-csrf'
93			);
94			}
95
96			public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
97			{
98			$entityClassNameDetails = $generator->createClassNameDetails(
99			$input->getArgument('entity-class'),
100			'Entity\\'
101			);
102
103			$controllerClassNameDetails = $generator->createClassNameDetails(
104			$entityClassNameDetails->getRelativeNameWithoutSuffix(),
105			'Controller\\',
106			'Controller'
107			);
108
109			$formClassNameDetails = $generator->createClassNameDetails(
110			$entityClassNameDetails->getRelativeNameWithoutSuffix(),
111			'Form\\',
112			'Type'
113			);
114
115			$metadata = $this->entityManager->getClassMetadata($entityClassNameDetails->getFullName());
116			$entityVarPlural = lcfirst(Inflector::pluralize($entityClassNameDetails->getShortName()));
117			$entityVarSingular = lcfirst(Inflector::singularize($entityClassNameDetails->getShortName()));
118			$routeName = Str::asRouteName($controllerClassNameDetails->getRelativeNameWithoutSuffix());
119
120			$generator->generateClass(
121			$controllerClassNameDetails->getFullName(),
122			'crud/controller/Controller.tpl.php',
123			[
124			'entity_full_class_name' => $entityClassNameDetails->getFullName(),
125			'entity_class_name' => $entityClassNameDetails->getShortName(),
126			'form_full_class_name' => $formClassNameDetails->getFullName(),
127			'form_class_name' => $formClassNameDetails->getShortName(),
128			'route_path' => Str::asRoutePath($controllerClassNameDetails->getRelativeNameWithoutSuffix()),
129			'route_name' => $routeName,
130			'entity_var_plural' => $entityVarPlural,
131			'entity_var_singular' => $entityVarSingular,
132			'entity_identifier' => $metadata->identifier[0],
			0 ignored issues – show Bug introduced 2018-02-12 21:34 UTC by Report Bug Copy Issue Report Accessing `identifier` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
133			]
134			);
135
136			$helper = new GeneratorHelper();
137
138			$generator->generateClass(
139			$formClassNameDetails->getFullName(),
140			'form/crud/Type.tpl.php',
141			[
142			'entity_class_exists' => true,
143			'entity_full_class_name' => $entityClassNameDetails->getFullName(),
144			'entity_class_name' => $entityClassNameDetails->getShortName(),
145			'entity_fields' => $metadata->fieldMappings,
			0 ignored issues – show Bug introduced 2018-02-12 21:34 UTC by Report Bug Copy Issue Report Accessing `fieldMappings` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
146			'helper' => $helper,
147			]
148			);
149
150			$baseLayoutExists = true;
151			$templatesPath = Str::asFilePath($controllerClassNameDetails->getRelativeNameWithoutSuffix());
152
153			$templates = [
154			'_delete_form' => [
155			'route_name' => $routeName,
156			'entity_identifier' => $metadata->identifier[0],
157			],
158			'_form' => [],
159			'edit' => [
160			'helper' => $helper,
161			'base_layout_exists' => $baseLayoutExists,
162			'entity_class_name' => $entityClassNameDetails->getShortName(),
163			'entity_var_singular' => $entityVarSingular,
164			'entity_identifier' => $metadata->identifier[0],
165			'route_name' => $routeName,
166			],
167			'index' => [
168			'helper' => $helper,
169			'base_layout_exists' => $baseLayoutExists,
170			'entity_class_name' => $entityClassNameDetails->getShortName(),
171			'entity_var_plural' => $entityVarPlural,
172			'entity_var_singular' => $entityVarSingular,
173			'entity_identifier' => $metadata->identifier[0],
174			'entity_fields' => $metadata->fieldMappings,
175			'route_name' => $routeName,
176			],
177			'new' => [
178			'helper' => $helper,
179			'base_layout_exists' => $baseLayoutExists,
180			'entity_class_name' => $entityClassNameDetails->getShortName(),
181			'route_name' => $routeName,
182			],
183			'show' => [
184			'helper' => $helper,
185			'base_layout_exists' => $baseLayoutExists,
186			'entity_class_name' => $entityClassNameDetails->getShortName(),
187			'entity_var_singular' => $entityVarSingular,
188			'entity_identifier' => $metadata->identifier[0],
189			'entity_fields' => $metadata->fieldMappings,
190			'route_name' => $routeName,
191			],
192			];
193
194			foreach ($templates as $template => $variables) {
195			$generator->generateFile(
196			'templates/'.$templatesPath.'/'.$template.'.html.twig',
197			'crud/templates/'.$template.'.tpl.php',
198			$variables
199			);
200			}
201
202			$generator->writeChanges();
203
204			$this->writeSuccessMessage($io);
205
206			$io->text('Next: Check your new crud!');
207			}
208			}
209

sadikoff / crud-maker-bundle

Push — master ( f62883...154da5 )

MakeCrud::generate() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like