OnlineMinifier::getHttpClient() - Code Metrics - Inspection of "Set headers unconditionally in native HTTP client" - s9e/TextFormatter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0c606d...0489bb )

by Josh

created 2016-01-12 16:39 UTC

OnlineMinifier::getHttpClient() A

↳ Parent: OnlineMinifier

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.6667
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

/**
* @package   s9e\TextFormatter
* @copyright Copyright (c) 2010-2016 The s9e Authors
* @license   http://www.opensource.org/licenses/mit-license.php The MIT License
*/
namespace s9e\TextFormatter\Configurator\JavaScript;

use s9e\TextFormatter\Configurator\Helpers\Http;

abstract class OnlineMinifier extends Minifier
{
	/**
	* @var \s9e\TextFormatter\Configurator\Http\Client Client used to perform HTTP request
	*/
	public $client;

	/**
	* @var integer Timeout in seconds
	*/
	public $timeout = 10;

	/**
	* Return a cached instance of the HTTP client
	*
	* @return \s9e\TextFormatter\Configurator\Http\Client
	*/
	protected function getHttpClient()
	{
		if (!isset($this->client))
		{
			$this->client = Http::getClient();

		}

		return $this->client;
	}
}

1			<?php
2
3			/**
4			* @package s9e\TextFormatter
5			* @copyright Copyright (c) 2010-2016 The s9e Authors
6			* @license http://www.opensource.org/licenses/mit-license.php The MIT License
7			*/
8			namespace s9e\TextFormatter\Configurator\JavaScript;
9
10			use s9e\TextFormatter\Configurator\Helpers\Http;
11
12			abstract class OnlineMinifier extends Minifier
13			{
14			/**
15			* @var \s9e\TextFormatter\Configurator\Http\Client Client used to perform HTTP request
16			*/
17			public $client;
18
19			/**
20			* @var integer Timeout in seconds
21			*/
22			public $timeout = 10;
23
24			/**
25			* Return a cached instance of the HTTP client
26			*
27			* @return \s9e\TextFormatter\Configurator\Http\Client
28			*/
29			protected function getHttpClient()
30			{
31			if (!isset($this->client))
32			{
33			$this->client = Http::getClient();
			0 ignored issues – show Documentation Bug introduced 2016-01-12 16:57 UTC by Report Bug Copy Issue Report It seems like `\s9e\TextFormatter\Confi...lpers\Http::getClient()` of type `object<s9e\TextFormatter...pers\Http\Clients\Curl>` or `object<s9e\TextFormatter...rs\Http\Clients\Native>` is incompatible with the declared type `object<s9e\TextFormatter...nfigurator\Http\Client>` of property `$client`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
34			}
35
36			return $this->client;
37			}
38			}

s9e / TextFormatter

Push — master ( 0c606d...0489bb )

OnlineMinifier::getHttpClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like