MergeSuffix::processStrings() - Code Metrics - Inspection of "MergeSuffix: reorganized the code that handles ear..." - s9e/RegexpBuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 390f8f...6f977d )

by Josh

created 2016-09-13 06:50 UTC

MergeSuffix::processStrings() A

↳ Parent: MergeSuffix

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	11
cts	11
cp	1
rs	9.0534
c	0
b	0
f	0
cc	4
eloc	11
nc	4
nop	1
crap	4

<?php

/**
* @package   s9e\RegexpBuilder
* @copyright Copyright (c) 2016 The s9e Authors
* @license   http://www.opensource.org/licenses/mit-license.php The MIT License
*/
namespace s9e\RegexpBuilder\Passes;

class MergeSuffix extends AbstractPass
{
	/**
	* {@inheritdoc}
	*/
	protected function processStrings(array $strings)
	{
		if (!$this->isEligible($strings))
		{
			return $strings;
		}

		$newString = [];
		while ($this->hasMatchingSuffix($strings))
		{
			array_unshift($newString, end($strings[0]));
			$i = count($strings);
			while (--$i >= 0)
			{
				array_pop($strings[$i]);
			}
		}
		array_unshift($newString, $strings);

		return [$newString];
	}

	/**
	* Test whether all given strings have the same last element
	*
	* @param  array[] $strings
	* @return bool
	*/
	protected function hasMatchingSuffix(array $strings)
	{
		$suffix = end($strings[1]);
		foreach ($strings as $string)
		{
			if (end($string) !== $suffix)
			{
				return false;
			}
		}

		return ($suffix !== false);
	}

	/**
	* Test whether this pass can be run on given list of strings
	*
	* @param  array[] $strings
	* @return bool
	*/
	protected function isEligible(array $strings)
	{
		return (count($strings) > 1 && $this->hasMatchingSuffix($strings));
	}
}

1		<?php
2
3		/**
4		* @package s9e\RegexpBuilder
5		* @copyright Copyright (c) 2016 The s9e Authors
6		* @license http://www.opensource.org/licenses/mit-license.php The MIT License
7		*/
8		namespace s9e\RegexpBuilder\Passes;
9
10		class MergeSuffix extends AbstractPass
11		{
12		/**
13		* {@inheritdoc}
14		*/
15	8	protected function processStrings(array $strings)
16		{
17	8	if (!$this->isEligible($strings))
18		{
19	3	return $strings;
20		}
21
22	5	$newString = [];
23	5	while ($this->hasMatchingSuffix($strings))
24		{
25	5	array_unshift($newString, end($strings[0]));
26	5	$i = count($strings);
27	5	while (--$i >= 0)
28		{
29	5	array_pop($strings[$i]);
30		}
31		}
32	5	array_unshift($newString, $strings);
33
34	5	return [$newString];
35		}
36
37		/**
38		* Test whether all given strings have the same last element
39		*
40		* @param array[] $strings
41		* @return bool
42		*/
43	7	protected function hasMatchingSuffix(array $strings)
44		{
45	7	$suffix = end($strings[1]);
46	7	foreach ($strings as $string)
47		{
48	7	if (end($string) !== $suffix)
49		{
50	7	return false;
51		}
52		}
53
54	5	return ($suffix !== false);
55		}
56
57		/**
58		* Test whether this pass can be run on given list of strings
59		*
60		* @param array[] $strings
61		* @return bool
62		*/
63	8	protected function isEligible(array $strings)
64		{
65	8	return (count($strings) > 1 && $this->hasMatchingSuffix($strings));
66		}
67		}

s9e / RegexpBuilder

Push — master ( 390f8f...6f977d )

MergeSuffix::processStrings() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like