Conditions | 10 |
Total Lines | 59 |
Lines | 59 |
Ratio | 100 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like Netstat.check() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | # -*- coding: utf-8 -*- |
||
65 | View Code Duplication | def check(self): |
|
1 ignored issue
–
show
|
|||
66 | """Return detailed network statitistics proc file net/netstat. |
||
67 | |||
68 | Note: add entries to the configuration value 'proc_netstat_record' |
||
69 | to record them. See /proc/net/netstat for a list of available metrics. |
||
70 | |||
71 | Note: ECT1Pkts and ECT0Pkts relate to ECT congestion notifications. |
||
72 | |||
73 | :rtype: plumd.Result |
||
74 | """ |
||
75 | # what metrics do we want to record? |
||
76 | record = self.config.get('proc_netstat_record') |
||
77 | result = plumd.Result("netstat") |
||
78 | |||
79 | # read the proc file |
||
80 | dat = None |
||
81 | with open(self.proc_file, 'r') as f: |
||
82 | try: |
||
83 | dat = f.read().strip().split("\n") |
||
84 | except Exception as e: |
||
85 | self.log.error("failed to read {0}".format(self.proc_file)) |
||
86 | return result |
||
87 | |||
88 | # timestamp for Differential calculations |
||
89 | ts = time.time() |
||
90 | |||
91 | # should always have a header row and value row, ie. divisible by 2 |
||
92 | if len(dat) % 2 != 0: |
||
93 | self.log.error("netstat: cannot parse {0}".format(self.proc_file)) |
||
94 | return result |
||
95 | |||
96 | # split values into lists |
||
97 | dlist = deque() |
||
98 | for entry in dat: |
||
99 | dlist.append(entry.split()) |
||
100 | |||
101 | # put lists into key: value dict |
||
102 | metrics = {} |
||
103 | while dlist: |
||
104 | headers = dlist.popleft() |
||
105 | values = dlist.popleft() |
||
106 | # { 'IpExt': {'InNoRoutes': 0, ...} } - [:-1] on IpExt: removes : |
||
107 | metrics[headers[0][:-1]] = dict(zip(headers, values)) |
||
108 | |||
109 | # now, we have a list of items to record, just need to record them |
||
110 | for ext, mnames in record.items(): |
||
111 | if ext not in metrics: |
||
112 | self.log.warn("netstat: unknown extension: {0}".format(ext)) |
||
113 | continue |
||
114 | values = metrics[ext] |
||
115 | for mname in mnames: |
||
116 | if mname in values: |
||
117 | mstr = "{0}.{1}".format(ext, mname) |
||
118 | mval = self.calc.per_second(mstr, int(values[mname]), ts) |
||
119 | result.add(plumd.Int(mstr, mval)) |
||
120 | else: |
||
121 | self.log.warn("netstat: unknown metric {0}".format(mname)) |
||
122 | |||
123 | return [result] |
||
124 |