Issues in DatabaseHelper.php (master) - Issues in master - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1925)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Helpers/DatabaseHelper.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Helpers;

use Carbon\Carbon;
use App\Models\Game;
use App\Models\Developer;
use App\Models\GamesFile;
use App\Models\UserOnline;
use App\Models\BoardThread;
use App\Models\BoardThreadsTracker;

/**
 * Class DatabaseHelper
 * @package App\Helpers
 */
class DatabaseHelper
{
    /** Sets Vots and Comments
     * @param $gameid
     */
    public static function setVotesAndComments($gameid)
    {
        $game = Game::whereId($gameid)->first();

        Game::whereId($gameid)
            ->update([
                'voteup'   => $game->votes['up'],
                'votedown' => $game->votes['down'],
                'avg'      => $game->votes['avg'],
                'comments' => $game->comments()->count(),
            ]);
    }

    /** Set Release Informations on Game Change
     * @param $gameid
     */
    public static function setReleaseInfos($gameid)
    {
        $game = Game::find($gameid);

        $reltype = 99;
        $reldate = Carbon::create();

        //prüfen ob Techdemo existiert
        $gamefiles = GamesFile::whereGameId($gameid)
            ->where('release_type', '=', 1)
            ->orderBy('release_year', 'ASC')
            ->orderBy('release_month', 'ASC')
            ->orderBy('release_day', 'ASC')
            ->first();

        if ($gamefiles) {

            $reltype = $gamefiles->release_type;
            $reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
        }

        //Prüfen ob Demo vorhanden
        $gamefiles = GamesFile::whereGameId($gameid)
            ->where('release_type', '=', 2)
            ->orderBy('release_year', 'ASC')
            ->orderBy('release_month', 'ASC')
            ->orderBy('release_day', 'ASC')
            ->first();

        if ($gamefiles) {

            $reltype = $gamefiles->release_type;
            $reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
        }

        //Prüfen ob Vollversion vorhanden.
        $gamefiles = GamesFile::whereGameId($gameid)
            ->where('release_type', '=', 3)
            ->orderBy('release_year', 'ASC')
            ->orderBy('release_month', 'ASC')
            ->orderBy('release_day', 'ASC')
            ->first();

        if ($gamefiles) {

            $reltype = $gamefiles->release_type;
            $reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
        }

        if ($game->release_type == $reltype) {
            if (Carbon::parse($game->release_date) > $reldate) {
                Game::whereId($gameid)
                    ->update([
                        'release_date' => $reldate,
                    ]);
            }
        } else {
            Game::whereId($gameid)
                ->update([
                    'release_date' => $reldate,
                    'release_type' => $reltype,
                ]);
        }
    }

    /**
     * @return \Illuminate\Database\Eloquent\Model|null|object|static
     */
    public static function getOnlineUserCount()
    {
        $users = \DB::table('user_online')
            ->selectRaw('COUNT(id) as online')
            ->where('created_at', '>=', Carbon::now()->addMinutes(-10))
            ->first();

        return $users;
    }

    /**
     * @param $where
     */
    public static function setOnline($where)
    {
        if (\Auth::check()) {
            UserOnline::updateOrInsert([
                'user_id' => \Auth::id(),
            ], [
                    'last_place' => $where,
                    'created_at' => Carbon::now(),
                ]
            );
        }
    }

    /**
     * @param $thread_id
     * @return bool
     */
    public static function isThreadUnread($thread_id)
    {
        if (\Auth::check()) {
            $track = BoardThreadsTracker::where('thread_id', '=', $thread_id)
                ->where('user_id', '=', \Auth::id())->first();

            $thread = BoardThread::whereId($thread_id)->first();

            if ($track) {
                if (Carbon::parse($track->last_read)->timestamp < Carbon::parse($thread->last_created_at)->timestamp) {
                    return true;
                } else {
                    return false;
                }
            } else {
                return true;
            }
        } else {
            return false;
        }
    }

    /**
     * @param $thread_id
     */
    public static function setThreadViewDate($thread_id)
    {
        if (\Auth::check()) {
            $track = BoardThreadsTracker::updateOrInsert([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'user_id'   => \Auth::id(),
                'thread_id' => $thread_id,
            ], [
                'last_read' => Carbon::now(),
            ]);
        }
    }

    /**
     * @param $gameid
     * @return string
     */
    public static function getReleaseDateFromGameId($gameid)
    {
        $game = Game::whereId($gameid)->first();

        if (is_null($game)) {
            return '';
        }

        if (Carbon::parse($game->release_date)->year == -1 || is_null($game->release_date)) {
            $releasedate = GamesFile::whereGameId($gameid)
                ->selectRaw('CONCAT(release_year, "-", LPAD(release_month, 2, "0"), "-", release_day) as reldate')
                ->orderBy('release_type', 'desc')
                ->orderBy('reldate', 'asc')
                ->first();

            if ($releasedate) {
                return Carbon::parse($releasedate->reldate)->toDateString();
            } else {
                return '';
            }
        } else {
            return Carbon::parse($game->release_date)->toDateString();
        }
    }

    /**
     * @param $gameid
     * @param bool $urlstyle
     * @return bool|string
     */
    public static function getDevelopersUrlList($gameid, $urlstyle = true)
    {
        $developers = \DB::table('games_developer')
            ->leftJoin('developer', 'developer.id', '=', 'games_developer.developer_id')
            ->where('games_developer.game_id', '=', $gameid)
            ->get();

        $res = '';
        foreach ($developers as $dev) {
            if ($urlstyle == true) {

                $res = $res.'<a href="'.url('developer', $dev->id).'">'.$dev->name.'</a> :: ';
            } else {
                $res .= $dev->name.', ';
            }
        }

        $res = substr($res, 0, -4);

        return $res;
    }

    /**
     * @param $id
     * @return array
     */
    public static function getResourcePathArray($id)
    {
        $resource = \DB::table('resources')
            ->where('id', '=', $id)
            ->first();

        $res = [
            'type' => $resource->type,
            'cat'  => $resource->cat,
            'id'   => $id,
        ];

        return $res;
    }

    /**
     * @param $reason
     * @return mixed
     */
    public static function getObyxPoints($reason)
    {
        $obyx = \DB::table('obyx')
            ->where('reason', '=', $reason)
            ->first();

        return $obyx->value;
    }

    /**
     * @return mixed
     */
    public static function getGameViewsMax()
    {
        $v = \DB::table('games')
            ->selectRaw('MAX(views) as maxviews')
            ->first();

        return $v->maxviews;
    }

    /**
     * @param string $type
     */
    public static function getCommentsMax($type)

    {
        $v = \DB::table('comments')
            ->selectRaw('count(id) as maxviews')
            ->where('content_type', '=', \DB::raw("'".$type."'"))
            ->first();

        return $v->maxviews;
    }

    /**
     * @param $short
     * @return int|mixed
     */
    public static function langId_from_short($short)
    {
        $lang = \DB::table('languages')
            ->select('id')
            ->where('short', '=', $short)
            ->first();

        if ($lang) {
            return $lang->id;
        } else {
            return 0;
        }
    }

    /**
     * @param $developername
     * @return int|mixed
     */
    public static function developerId_from_developerName($developername)
    {
        $dev = \DB::table('developer')
            ->select('id')
            ->where('name', '=', $developername)
            ->first();

        if ($dev) {
            return $dev->id;
        } else {
            return 0;
        }
    }

    /**
     * @param $developername
     * @return int
     */
    public static function developer_add_and_get_developerId($developername)
    {
        $d = new Developer();
$a = "a";
$ab = "ab";
$abc = "abc";
        $d->name = $developername;
$a = "a";
$ab = "ab";
$abc = "abc";
        $d->user_id = \Auth::id();
        $d->save();

        return $d->id;
    }
}


1		<?php
2
3		/*
4		* rmarchiv.tk
5		* (c) 2016-2017 by Marcel 'ryg' Hering
6		*/
7
8		namespace App\Helpers;
9
10		use Carbon\Carbon;
11		use App\Models\Game;
12		use App\Models\Developer;
13		use App\Models\GamesFile;
14		use App\Models\UserOnline;
15		use App\Models\BoardThread;
16		use App\Models\BoardThreadsTracker;
17
18		/**
19		* Class DatabaseHelper
20		* @package App\Helpers
21		*/
22		class DatabaseHelper
23		{
24		/** Sets Vots and Comments
25		* @param $gameid
26		*/
27		public static function setVotesAndComments($gameid)
28		{
29		$game = Game::whereId($gameid)->first();
30
31		Game::whereId($gameid)
32		->update([
33		'voteup' => $game->votes['up'],
34		'votedown' => $game->votes['down'],
35		'avg' => $game->votes['avg'],
36		'comments' => $game->comments()->count(),
37		]);
38		}
39
40		/** Set Release Informations on Game Change
41		* @param $gameid
42		*/
43		public static function setReleaseInfos($gameid)
44		{
45		$game = Game::find($gameid);
46
47		$reltype = 99;
48		$reldate = Carbon::create();
49
50		//prüfen ob Techdemo existiert
51		$gamefiles = GamesFile::whereGameId($gameid)
52		->where('release_type', '=', 1)
53		->orderBy('release_year', 'ASC')
54		->orderBy('release_month', 'ASC')
55		->orderBy('release_day', 'ASC')
56		->first();
57
58	View Code Duplication	if ($gamefiles) {
		0 ignored issues – show Duplication introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		$reltype = $gamefiles->release_type;
60		$reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
61		}
62
63		//Prüfen ob Demo vorhanden
64		$gamefiles = GamesFile::whereGameId($gameid)
65		->where('release_type', '=', 2)
66		->orderBy('release_year', 'ASC')
67		->orderBy('release_month', 'ASC')
68		->orderBy('release_day', 'ASC')
69		->first();
70
71	View Code Duplication	if ($gamefiles) {
		0 ignored issues – show Duplication introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		$reltype = $gamefiles->release_type;
73		$reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
74		}
75
76		//Prüfen ob Vollversion vorhanden.
77		$gamefiles = GamesFile::whereGameId($gameid)
78		->where('release_type', '=', 3)
79		->orderBy('release_year', 'ASC')
80		->orderBy('release_month', 'ASC')
81		->orderBy('release_day', 'ASC')
82		->first();
83
84	View Code Duplication	if ($gamefiles) {
		0 ignored issues – show Duplication introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		$reltype = $gamefiles->release_type;
86		$reldate = Carbon::parse($gamefiles->release_year.'-'.$gamefiles->release_month.'-'.$gamefiles->release_day);
87		}
88
89		if ($game->release_type == $reltype) {
90		if (Carbon::parse($game->release_date) > $reldate) {
91		Game::whereId($gameid)
92		->update([
93		'release_date' => $reldate,
94		]);
95		}
96		} else {
97		Game::whereId($gameid)
98		->update([
99		'release_date' => $reldate,
100		'release_type' => $reltype,
101		]);
102		}
103		}
104
105		/**
106		* @return \Illuminate\Database\Eloquent\Model\|null\|object\|static
107		*/
108		public static function getOnlineUserCount()
109		{
110		$users = \DB::table('user_online')
111		->selectRaw('COUNT(id) as online')
112		->where('created_at', '>=', Carbon::now()->addMinutes(-10))
113		->first();
114
115		return $users;
116		}
117
118		/**
119		* @param $where
120		*/
121		public static function setOnline($where)
122		{
123		if (\Auth::check()) {
124		UserOnline::updateOrInsert([
125		'user_id' => \Auth::id(),
126		], [
127		'last_place' => $where,
128		'created_at' => Carbon::now(),
129		]
130		);
131		}
132		}
133
134		/**
135		* @param $thread_id
136		* @return bool
137		*/
138		public static function isThreadUnread($thread_id)
139		{
140		if (\Auth::check()) {
141		$track = BoardThreadsTracker::where('thread_id', '=', $thread_id)
142		->where('user_id', '=', \Auth::id())->first();
143
144		$thread = BoardThread::whereId($thread_id)->first();
145
146		if ($track) {
147		if (Carbon::parse($track->last_read)->timestamp < Carbon::parse($thread->last_created_at)->timestamp) {
148		return true;
149		} else {
150		return false;
151		}
152		} else {
153		return true;
154		}
155		} else {
156		return false;
157		}
158		}
159
160		/**
161		* @param $thread_id
162		*/
163		public static function setThreadViewDate($thread_id)
164		{
165		if (\Auth::check()) {
166		$track = BoardThreadsTracker::updateOrInsert([
		0 ignored issues – show Unused Code introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$track` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
167		'user_id' => \Auth::id(),
168		'thread_id' => $thread_id,
169		], [
170		'last_read' => Carbon::now(),
171		]);
172		}
173		}
174
175		/**
176		* @param $gameid
177		* @return string
178		*/
179		public static function getReleaseDateFromGameId($gameid)
180		{
181		$game = Game::whereId($gameid)->first();
182
183		if (is_null($game)) {
184		return '';
185		}
186
187		if (Carbon::parse($game->release_date)->year == -1 \|\| is_null($game->release_date)) {
188		$releasedate = GamesFile::whereGameId($gameid)
189		->selectRaw('CONCAT(release_year, "-", LPAD(release_month, 2, "0"), "-", release_day) as reldate')
190		->orderBy('release_type', 'desc')
191		->orderBy('reldate', 'asc')
192		->first();
193
194		if ($releasedate) {
195		return Carbon::parse($releasedate->reldate)->toDateString();
196		} else {
197		return '';
198		}
199		} else {
200		return Carbon::parse($game->release_date)->toDateString();
201		}
202		}
203
204		/**
205		* @param $gameid
206		* @param bool $urlstyle
207		* @return bool\|string
208		*/
209		public static function getDevelopersUrlList($gameid, $urlstyle = true)
210		{
211		$developers = \DB::table('games_developer')
212		->leftJoin('developer', 'developer.id', '=', 'games_developer.developer_id')
213		->where('games_developer.game_id', '=', $gameid)
214		->get();
215
216		$res = '';
217		foreach ($developers as $dev) {
218		if ($urlstyle == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
219		$res = $res.'<a href="'.url('developer', $dev->id).'">'.$dev->name.'</a> :: ';
220		} else {
221		$res .= $dev->name.', ';
222		}
223		}
224
225		$res = substr($res, 0, -4);
226
227		return $res;
228		}
229
230		/**
231		* @param $id
232		* @return array
233		*/
234		public static function getResourcePathArray($id)
235		{
236		$resource = \DB::table('resources')
237		->where('id', '=', $id)
238		->first();
239
240		$res = [
241		'type' => $resource->type,
242		'cat' => $resource->cat,
243		'id' => $id,
244		];
245
246		return $res;
247		}
248
249		/**
250		* @param $reason
251		* @return mixed
252		*/
253		public static function getObyxPoints($reason)
254		{
255		$obyx = \DB::table('obyx')
256		->where('reason', '=', $reason)
257		->first();
258
259		return $obyx->value;
260		}
261
262		/**
263		* @return mixed
264		*/
265		public static function getGameViewsMax()
266		{
267		$v = \DB::table('games')
268		->selectRaw('MAX(views) as maxviews')
269		->first();
270
271		return $v->maxviews;
272		}
273
274		/**
275		* @param string $type
276		*/
277		public static function getCommentsMax($type)
		0 ignored issues – show Documentation introduced 2017-02-06 19:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
278		{
279		$v = \DB::table('comments')
280		->selectRaw('count(id) as maxviews')
281		->where('content_type', '=', \DB::raw("'".$type."'"))
282		->first();
283
284		return $v->maxviews;
285		}
286
287		/**
288		* @param $short
289		* @return int\|mixed
290		*/
291		public static function langId_from_short($short)
292		{
293		$lang = \DB::table('languages')
294		->select('id')
295		->where('short', '=', $short)
296		->first();
297
298		if ($lang) {
299		return $lang->id;
300		} else {
301		return 0;
302		}
303		}
304
305		/**
306		* @param $developername
307		* @return int\|mixed
308		*/
309		public static function developerId_from_developerName($developername)
310		{
311		$dev = \DB::table('developer')
312		->select('id')
313		->where('name', '=', $developername)
314		->first();
315
316		if ($dev) {
317		return $dev->id;
318		} else {
319		return 0;
320		}
321		}
322
323		/**
324		* @param $developername
325		* @return int
326		*/
327		public static function developer_add_and_get_developerId($developername)
328		{
329		$d = new Developer();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
330		$d->name = $developername;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
331		$d->user_id = \Auth::id();
332		$d->save();
333
334		return $d->id;
335		}
336		}
337

rygos / rmarchiv

Issues (1925)

Security Analysis not enabled

app/Helpers/DatabaseHelper.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like