rygos / rmarchiv

app/Console/Commands/PlayerRar2Zip.php

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 *
 * Get all rar gamefiles and repack with zip
 */

namespace App\Console\Commands;

use App\Models\GamesFile;
use Illuminate\Console\Command;

class PlayerRar2Zip extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'player:rar2zip';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'convert rar files to zip';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        //get all rar files from database
        $files = GamesFile::whereExtension('rar')->orderBy('filesize', 'asc')->get();

The method orderBy does only exist in Illuminate\Database\Query\Builder, but not in App\Models\GamesFile.

        foreach ($files as $f) {
            //Check for maker engine 2=rm2k, 3=rm2k3, 9=rm2k3 Steam Edition
            if (! array_search($f->game->maker_id, [2, 3, 6, 9, 11]) === false) {
                echo "Gamefile: $f->filename";

As per coding-style, please use concatenation or sprintf for the variable $f instead of interpolation.

                //prepare the path variables
                $pathrar = storage_path('app/public/'.$f->filename); // Path to original rar file

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $pathzip = storage_path('app/public/'.str_replace('.rar', '.zip', $f->filename)); //Path to zip destination

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $pathdest = storage_path('app/public/games/'.$f->id.'/'); //destination for unrared files

                //delete old temp files (just in case.)
                $this->Delete($pathdest);

                // unrar the rar archive
                $command = 'unrar x \''.$pathrar.'\' '.$pathdest;
                exec($command);

                $handle = opendir($pathdest); // erm??

$handle is not used, you could remove the assignment.

                //zip previous decompressed files
                $this->Zip($pathdest, $pathzip);

                // Check for zip file
                if(!file_exists($pathzip)){
                    // zip file does not exist. debug & die.
                    dd($pathzip);
                }

                //delete decomressed files
                $this->Delete($pathdest);

                //Update the Database
                $upd = GamesFile::whereId($f->id)->first();

Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space

                $upd->extension = 'zip';
                $upd->filename = str_replace('.rar', '.zip', $f->filename);

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $upd->save();

                //delete rar file
                unlink($pathrar);

                echo " - done\n";
            }
        }
    }

    public function Delete($path)
    {
        // check for directory is not a file
        if (is_dir($path) === true) {
            // get all files and directorys recursive from all directorys
            $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path), \RecursiveIteratorIterator::CHILD_FIRST);

            foreach ($files as $file) {
                // if file is . or .. skip
                if (in_array($file->getBasename(), ['.', '..']) !== true) {
                    // if $file is a directory
                    if ($file->isDir() === true) {
                        // delete directory
                        rmdir($file->getPathName());
                    } elseif (($file->isFile() === true) || ($file->isLink() === true)) { // or a file
                        // delete file
                        unlink($file->getPathname());
                    }
                }
            }

            return rmdir($path);
        } elseif ((is_file($path) === true) || (is_link($path) === true)) {
            return unlink($path);
        }

        return false;
    }

    public function Zip($source, $destination)

The return type could not be reliably inferred; please add a @return annotation.

    {
        // check for php_zip extension and file existance
        if (! extension_loaded('zip') || ! file_exists($source)) {
            return false;
        }

        // create ZipArchive Object
        $zip = new \ZipArchive();

        // Create a new ZIP
        if (! $zip->open($destination, \ZIPARCHIVE::CREATE)) {
            return false;
        }

        $source = str_replace('\\', '/', realpath($source));

        if (is_dir($source) === true) {
            $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($source), \RecursiveIteratorIterator::SELF_FIRST);

            foreach ($files as $file) {
                $file = str_replace('\\', '/', $file);

                // Ignore "." and ".." folders
                if (in_array(substr($file, strrpos($file, '/') + 1), ['.', '..'])) {
                    continue;
                }

                $file = realpath($file);

                if (is_dir($file) === true) {
                    $zip->addEmptyDir(str_replace($source.'/', '', $file.'/'));
                } elseif (is_file($file) === true) {
                    $zip->addFromString(str_replace($source.'/', '', $file), file_get_contents($file));
                }
            }
        } elseif (is_file($source) === true) {
            $zip->addFromString(basename($source), file_get_contents($source));
        }

        return $zip->close();
    }
}