rygos / rmarchiv

app/Console/Commands/PlayerCreateInfo.php

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Console\Commands;

use App\Models\GamesFile;
use App\Models\PlayerIndexjson;
use Illuminate\Console\Command;

class PlayerCreateInfo extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'player:createinfo';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'creates index.json data for easyrpg';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->info('Lade Gamefiles ohne index.json');

        $gamefiles = GamesFile::with('game')->get();

        $counter = 0;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $toindexed = [];

        foreach ($gamefiles as $gamefile) {
            if ($gamefile->game) {
                $makerid = $gamefile->game->maker_id;
                //echo $makerid.' - '.$gamefile->id.PHP_EOL;

50% of this comment could be valid code. Did you maybe forget this after debugging?

                if ($makerid == 2 or

Using logical operators such as or instead of || is generally not recommended.

                    $makerid == 3 or

Using logical operators such as or instead of || is generally not recommended.

                    $makerid == 6 or

Using logical operators such as or instead of || is generally not recommended.

                    $makerid == 9 or

Using logical operators such as or instead of || is generally not recommended.

                    $makerid == 11) {
                    // RPG2k/2k3/MV
                    if ($gamefile->playerIndex()->count() == 0) {
                        $toindexed[] = $gamefile;
                        $this->info('ADD '.$gamefile->game->title);
                        $counter += 1;
                    }
                }
            }
        }

        $this->info('Es wurden '.$counter.' Gamefiles gefunden.');

        $bar = $this->output->createProgressBar(count($toindexed));
        $bar->setFormat(" \033[44;37m %title:-37s% \033[0m\n %current%/%max% %bar% %percent:3s%%\n %remaining:-10s% %memory:37s%");
        $bar->setBarCharacter($done = "\033[32m●\033[0m");

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

        $bar->setEmptyBarCharacter($empty = "\033[31m●\033[0m");

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $bar->setProgressCharacter($progress = "\033[32m➤ \033[0m");
        $bar->setMessage('Starte indizierung der Gamefiles', 'title');
        $bar->start();

        $i = 0;

$i is not used, you could remove the assignment.

        foreach ($toindexed as $toindex) {
            $bar->setMessage('Entpacken von: '.$toindex->game_id.'/'.$toindex->id, 'title');
            \Log::info('Entpacken von '.$toindex->game_id.'/'.$toindex->id);
            $path = storage_path('app/public/'.$toindex->filename);
            if ($toindex->extension == 'zip') {
                $zip = new \ZipArchive();
                $zip->open($path);
                $makerid = $toindex->game->maker_id;
                if ($makerid == 6) {
                    // RPG Maker MV
                    // Nur Pfad zum "www/" Ordner noetig
                    for ($i = 0; $i < $zip->numFiles; $i++) {
                        $filename = $zip->getNameIndex($i);
                        $this->info('Saved XXX basepath: '.$filename);
                        if (ends_with($filename, 'www/')) {
                            $pl = new PlayerIndexjson();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

                            $pl->gamefile_id = $toindex->id;
                            $pl->key = 'www';

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

                            $pl->value = $filename;

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

                            $pl->filename = $filename;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

                            $pl->save();

                            \Log::info('Saved basepath: '.$filename);
                            break;
                        }
                    }
                } else {
                    // RPG Maker 2k/2k3
                    for ($i = 0; $i < $zip->numFiles; $i++) {
                        $filename = $zip->getNameIndex($i);

                        if (! ends_with($filename, '/') and ! starts_with($filename, '_MACOSX')) {

Using logical operators such as and instead of && is generally not recommended.

                            $imp = $this->search_for_base_path($filename);

                            if (! $imp == '') {
                                $pl = new PlayerIndexjson();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

                                $pl->gamefile_id = $toindex->id;
                                if (! ends_with(strtolower($imp), ['.exe', '.lmu', '.ldb', 'ini', '.dll', 'lmt', 'lsd'])) {

This code seems to be duplicated across your project.

                                    $pl->key = preg_replace('/(\.\w+$)/', '', strtolower($imp));
                                } else {
                                    $pl->key = strtolower($imp);
                                }
                                $pl->value = $imp;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

                                $pl->filename = 'www';
                                $pl->save();

                                \Log::info('Saved basepath: '.$filename);
                            } else {
                                \Log::info('Empty basepath: '.$filename);
                            }
                        }
                    }
                }
                @$zip->close();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            } else {
                continue;
            }

            //return;
            $bar->advance();
        }

        $bar->finish();

        $this->info('Fertig.');
    }

    public function search_for_base_path($filepath)

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $dirarray = [
            'backdrop',
            'battle',
            'battle2',
            'battlecharset',
            'battleweapon',
            'charset',
            'chipset',
            'faceset',
            'frame',
            'gameover',
            'monster',
            'panorama',
            'picture',
            'system',
            'system2',
            'title',
            'music',
            'sound',
        ];

        $rootarray = [
            'harmony.dll',
            'rpg_rt.exe',
            'rpg_rt.ini',
            'rpg_rt.ldb',
            'rpg_rt.lmt',
            'rpg_rt.dat',
        ];

        $mapparray = [];
        for ($i = 0; $i < 2000; $i++) {
            $mapparray[] = 'map'.sprintf('%04d', $i).'.lmu';
        }

        $filearray = array_merge($rootarray, $mapparray);

        $searcharray = array_merge($dirarray, $filearray);

        if (starts_with(strtolower($filepath), $searcharray)) {
            $imp = str_replace('/', '\\/', $filepath);
        } else {
            if (str_contains(strtolower($filepath), $searcharray)) {
                $exp = explode('/', $filepath);
                $res = array_shift($exp);

$res is not used, you could remove the assignment.

                $imp = implode('/', $exp);
                $imp = $this->search_for_base_path($imp);
            } else {
                $imp = '';
            }
        }

        if ($imp != '') {
            if (array_search(strtolower($imp), $filearray)) {
                $imp = '.\\/'.$imp;
            }
        }

        return $imp;
    }
}