ReportController::close_ticket() - Code Metrics - Inspection of "Spiele können nun gemeldet werden." - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( d7ada5...35b385 )

by Marcel

created 2017-02-06 13:48 UTC

ReportController::close_ticket() A

↳ Parent: ReportController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	1

<?php

namespace App\Http\Controllers;

use App\Models\Game;
use App\Models\UserReport;
use Carbon\Carbon;
use Illuminate\Http\Request;

class ReportController extends Controller
{
    public function index() {
        $r = UserReport::all();

        return view('reports.index', [
            'reports' => $r,
        ]);
    }

    public function create_game_report($gameid) {
        $g = Game::whereId($gameid)->first();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return view('reports.create', [
            'game' => $g,
        ]);
    }

    public function store_game_report(Request $request, $gameid) {
        $r = new UserReport;
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->content_id = $gameid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->content_type = 'game';
        $r->reason = $request->get('msg');
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->save();

        return redirect()->action('ReportController@index_user');
    }

    public function index_user() {
        if(\Auth::check()){
            if(\Auth::user()->can('admin-games')){
                $ur = UserReport::all();
            }else{
                $ur = UserReport::whereUserId(\Auth::id());
            }
        }else{
            $ur = null;
        }

        return view('reports.index', [
            'reports' => $ur,
        ]);
    }

    public function close_ticket($id){

        $t = UserReport::whereId($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_at = Carbon::now();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_user_id = \Auth::id();
        $t->save();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return redirect()->action('ReportController@index_user');
    }

    public function open_ticket($id){

        $t = UserReport::whereId($id);
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_at = Carbon::now();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_user_id = \Auth::id();
        $t->save();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return redirect()->action('ReportController@index_user');
    }

    public function remark_ticket($id){


    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Models\Game;
6		use App\Models\UserReport;
7		use Carbon\Carbon;
8		use Illuminate\Http\Request;
9
10		class ReportController extends Controller
11		{
12		public function index() {
13		$r = UserReport::all();
14
15		return view('reports.index', [
16		'reports' => $r,
17		]);
18		}
19
20		public function create_game_report($gameid) {
21		$g = Game::whereId($gameid)->first();
		1 ignored issue – show Bug introduced 2017-02-06 08:17 UTC by Report Bug Copy Issue Report The method `first` does only exist in `Illuminate\Database\Query\Builder`, but not in `App\Models\Game`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22
23		return view('reports.create', [
24		'game' => $g,
25		]);
26		}
27
28		public function store_game_report(Request $request, $gameid) {
29		$r = new UserReport;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30		$r->content_id = $gameid;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31		$r->content_type = 'game';
32		$r->reason = $request->get('msg');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33		$r->user_id = \Auth::id();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34		$r->save();
35
36		return redirect()->action('ReportController@index_user');
37		}
38
39		public function index_user() {
40		if(\Auth::check()){
41		if(\Auth::user()->can('admin-games')){
42		$ur = UserReport::all();
43		}else{
44		$ur = UserReport::whereUserId(\Auth::id());
45		}
46		}else{
47		$ur = null;
48		}
49
50		return view('reports.index', [
51		'reports' => $ur,
52		]);
53		}
54
55	View Code Duplication	public function close_ticket($id){
		1 ignored issue – show Duplication introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		$t = UserReport::whereId($id);
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
57		$t->closed = 1;
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
58		$t->closed_at = Carbon::now();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
59		$t->closed_user_id = \Auth::id();
60		$t->save();
		0 ignored issues – show Bug introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report The method `save` does only exist in `App\Models\UserReport`, but not in `Illuminate\Database\Query\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
61
62		return redirect()->action('ReportController@index_user');
63		}
64
65	View Code Duplication	public function open_ticket($id){
		1 ignored issue – show Duplication introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		$t = UserReport::whereId($id);
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
67		$t->closed = 0;
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
68		$t->closed_at = Carbon::now();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69		$t->closed_user_id = \Auth::id();
70		$t->save();
		0 ignored issues – show Bug introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report The method `save` does only exist in `App\Models\UserReport`, but not in `Illuminate\Database\Query\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71
72		return redirect()->action('ReportController@index_user');
73		}
74
75		public function remark_ticket($id){
		0 ignored issues – show Unused Code introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76
77		}
78		}
79

rygos / rmarchiv

Push — master ( d7ada5...35b385 )

ReportController::close_ticket() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like