SubmitController::logo_add() - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

SubmitController::logo_add() B
last analyzed 2018-05-01 08:16 UTC

↳ Parent: SubmitController

Complexity

Conditions	1
Paths	1

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	27
rs	8.8571
cc	1
eloc	16
nc	1
nop	1

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use App\Events\Obyx;
use App\Models\Logo;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;

class SubmitController extends Controller
{
    public function index()
    {
        //Zeige Submit View
        return view('submit.index');
    }

    public function logo_index()
    {
        //Zeige View zum Einsenden eines Logos
        return view('submit.logo.index');
    }

    public function logo_add(Request $request)
    {
        $this->validate($request, [
            'file'     => 'required|image|mimes:jpeg,png,jpg,gif,svg|max:2048',
            'logoname' => 'required',
        ]);

        $file = $request->file('file');
$a = "a";
$ab = "ab";
$abc = "abc";
        $extorig = $file->getExtension();

        $imageName = \Storage::putFile('logos', new UploadedFile($file->path(), $file->getClientOriginalName()));
        //dd($file);



        $l = new Logo();
$a = "a";
$ab = "ab";
$abc = "abc";
        $l->extension = \Storage::mimeType($imageName);
        $imageName = str_replace('logos', 'logo', $imageName);
$a = "a";
$ab = "ab";
$abc = "abc";
        $l->filename = str_replace($extorig, '', $imageName);
$a = "a";
$ab = "ab";
$abc = "abc";
        $l->title = $request->get('logoname');
$a = "a";
$ab = "ab";
$abc = "abc";
        $l->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
        $l->save();

        event(new Obyx('logo-add', \Auth::id()));

        return redirect()->route('submit.logo.success');
    }

    public function attachment_submit(Request $request)

    {
        \Debugbar::disable();

        $file = $request->file('editormd-image-file');

        $imageName = \Storage::putFile('attachments', new UploadedFile($file->path(), $file->getClientOriginalName()));

        $response['url'] = url('/').'/storage/'.$imageName;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $response['success'] = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $response['message'] = 'Bild wurde erfolgreich hochgeladen.';
$a = "a";
$ab = "ab";
$abc = "abc";
        $response['filename'] = url('/').'/storage/'.$imageName;

        return json_encode($response);
    }
}


1			<?php
2
3			/*
4			* rmarchiv.tk
5			* (c) 2016-2017 by Marcel 'ryg' Hering
6			*/
7
8			namespace App\Http\Controllers;
9
10			use App\Events\Obyx;
11			use App\Models\Logo;
12			use Illuminate\Http\Request;
13			use Illuminate\Http\UploadedFile;
14
15			class SubmitController extends Controller
16			{
17			public function index()
18			{
19			//Zeige Submit View
20			return view('submit.index');
21			}
22
23			public function logo_index()
24			{
25			//Zeige View zum Einsenden eines Logos
26			return view('submit.logo.index');
27			}
28
29			public function logo_add(Request $request)
30			{
31			$this->validate($request, [
32			'file' => 'required\|image\|mimes:jpeg,png,jpg,gif,svg\|max:2048',
33			'logoname' => 'required',
34			]);
35
36			$file = $request->file('file');
			0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37			$extorig = $file->getExtension();
38
39			$imageName = \Storage::putFile('logos', new UploadedFile($file->path(), $file->getClientOriginalName()));
40			//dd($file);
41
42
43
44			$l = new Logo();
			0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
45			$l->extension = \Storage::mimeType($imageName);
46			$imageName = str_replace('logos', 'logo', $imageName);
			0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
47			$l->filename = str_replace($extorig, '', $imageName);
			0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48			$l->title = $request->get('logoname');
			0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
49			$l->user_id = \Auth::id();
			0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
50			$l->save();
51
52			event(new Obyx('logo-add', \Auth::id()));
53
54			return redirect()->route('submit.logo.success');
55			}
56
57			public function attachment_submit(Request $request)
			0 ignored issues – show Documentation introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
58			{
59			\Debugbar::disable();
60
61			$file = $request->file('editormd-image-file');
62
63			$imageName = \Storage::putFile('attachments', new UploadedFile($file->path(), $file->getClientOriginalName()));
64
65			$response['url'] = url('/').'/storage/'.$imageName;
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-17 11:52 UTC by Report Bug Copy Issue Report `$response` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$response = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Coding Style introduced 2017-03-17 11:52 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
66			$response['success'] = 1;
			0 ignored issues – show Coding Style introduced 2017-03-17 11:52 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
67			$response['message'] = 'Bild wurde erfolgreich hochgeladen.';
			0 ignored issues – show Coding Style introduced 2017-03-17 11:52 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
68			$response['filename'] = url('/').'/storage/'.$imageName;
69
70			return json_encode($response);
71			}
72			}
73

rygos / rmarchiv

SubmitController::logo_add() B last analyzed 2018-05-01 08:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SubmitController::logo_add() B
last analyzed 2018-05-01 08:16 UTC