PlayerMvController::deliver() - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

PlayerMvController::deliver() B
last analyzed 2018-05-01 08:16 UTC

↳ Parent: PlayerMvController

Complexity

Conditions	4
Paths	4

Size

Total Lines	28
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	28
rs	8.5806
cc	4
eloc	16
nc	4
nop	2

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 * (c) 2018 by Gabriel 'Ghabry' Kind
 */

namespace App\Http\Controllers;

use App\Models\Game;
use App\Models\GamesFile;
use App\Models\PlayerIndexjson;

class PlayerMvController extends Controller
{
    public function index($gamefileid)
    {
        if (\Auth::check()) {
            $gamefile = GamesFile::whereId($gamefileid)->first();
            $path = storage_path('app/public/'.$gamefile->filename);
$a = "a";
$ab = "ab";
$abc = "abc";
            $game = Game::whereId($gamefile->game_id)->first();
$a = "a";
$ab = "ab";
$abc = "abc";

            $index = PlayerIndexjson::whereGamefileId($gamefileid)->first();
            $zip = new \ZipArchive();
$a = "a";
$ab = "ab";
$abc = "abc";
            $zip->open($path);
            $fp = $zip->getFromName($index->value.'index.html');

            return view('playermv.index', [
                'gamefileid' => $gamefileid,
                'game'       => $game,
                'index'      => $fp,
            ]);
        } else {
            return redirect()->action('IndexController@index');
        }
    }

    public function deliver($gamefileid, $filename)

    {
        // OrangeMouseData is broken outside of Chrome browser -_-
        if ($filename == 'js/plugins/OrangeMouseData.js') {
            $path = public_path('mv/'.$filename);

            return response()->download($path);
        }

        $gf = GamesFile::whereId($gamefileid)->first();
$a = "a";
$ab = "ab";
$abc = "abc";
        $index = PlayerIndexjson::whereGamefileId($gamefileid)->first();

        $path = storage_path('app/public/'.$gf->filename);

        $zip = new \ZipArchive();
        $zip->open($path);
        $fp = $zip->getFromName($index->value.$filename);

        $t = 'application/octet-stream';
        // Loading fails when js or css have wrong mimetype
        if (ends_with($filename, '.js') == true) {

            $t = 'application/javascript';
        } elseif (ends_with($filename, '.css') == true) {

            $t = 'text/css';
        }

        return response($fp, 200)->header('Content-Type', $t);

    }
}


1			<?php
2
3			/*
4			* rmarchiv.tk
5			* (c) 2016-2017 by Marcel 'ryg' Hering
6			* (c) 2018 by Gabriel 'Ghabry' Kind
7			*/
8
9			namespace App\Http\Controllers;
10
11			use App\Models\Game;
12			use App\Models\GamesFile;
13			use App\Models\PlayerIndexjson;
14
15			class PlayerMvController extends Controller
16			{
17			public function index($gamefileid)
18			{
19			if (\Auth::check()) {
20			$gamefile = GamesFile::whereId($gamefileid)->first();
21			$path = storage_path('app/public/'.$gamefile->filename);
			0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$game = Game::whereId($gamefile->game_id)->first();
			0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23
24			$index = PlayerIndexjson::whereGamefileId($gamefileid)->first();
25			$zip = new \ZipArchive();
			0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			$zip->open($path);
27			$fp = $zip->getFromName($index->value.'index.html');
28
29			return view('playermv.index', [
30			'gamefileid' => $gamefileid,
31			'game' => $game,
32			'index' => $fp,
33			]);
34			} else {
35			return redirect()->action('IndexController@index');
36			}
37			}
38
39			public function deliver($gamefileid, $filename)
			0 ignored issues – show Documentation introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
40			{
41			// OrangeMouseData is broken outside of Chrome browser -_-
42			if ($filename == 'js/plugins/OrangeMouseData.js') {
43			$path = public_path('mv/'.$filename);
44
45			return response()->download($path);
46			}
47
48			$gf = GamesFile::whereId($gamefileid)->first();
			0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
49			$index = PlayerIndexjson::whereGamefileId($gamefileid)->first();
50
51			$path = storage_path('app/public/'.$gf->filename);
52
53			$zip = new \ZipArchive();
54			$zip->open($path);
55			$fp = $zip->getFromName($index->value.$filename);
56
57			$t = 'application/octet-stream';
58			// Loading fails when js or css have wrong mimetype
59			if (ends_with($filename, '.js') == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
60			$t = 'application/javascript';
61			} elseif (ends_with($filename, '.css') == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
62			$t = 'text/css';
63			}
64
65			return response($fp, 200)->header('Content-Type', $t);
			0 ignored issues – show Bug introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The method `header()` does not exist on `Symfony\Component\HttpFoundation\Response`. Did you maybe mean `sendHeaders()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
66			}
67			}
68

rygos / rmarchiv

PlayerMvController::deliver() B last analyzed 2018-05-01 08:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PlayerMvController::deliver() B
last analyzed 2018-05-01 08:16 UTC