App\Http\Controllers\SavegameController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	87
Duplicated Lines	29.89 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	3	1
A	show()	0	3	1
A	api_load()	0	15	2
B	api_save()	13	31	3
B	api_save_slot()	13	28	2

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\GamesSavegame;

class SavegameController extends Controller
{
    public function index($gamefileid)

The parameter $gamefileid is not used and could be removed.

    {
    }

    public function show($gamefileid, $slotid)

The parameter $gamefileid is not used and could be removed.

The parameter $slotid is not used and could be removed.

    {
    }

    public function api_load($gamefileid)
    {
        //Load Savegame Data from Database
        $savegames = GamesSavegame::whereGamefileId($gamefileid)
            ->where('user_id', '=', \Auth::id())
            ->get();

        $ret = [];

        foreach ($savegames as $s) {
            $ret[$s->slot_id] = $s->save_data;
        }

        return response()->json($ret);
    }

    public function api_save(Request $request, $gamefileid)

The parameter $request is not used and could be removed.

    {
        $payLoad = json_decode(request()->getContent(), true);

        \Log::info('savegamecount: '.count($payLoad));

        foreach ($payLoad as $key=>$value) {
            \Log::info('slot: '.$key);
            \Log::info('data: '.$value);
            $save = GamesSavegame::where([

Equals sign not aligned with surrounding assignments; expected 22 spaces but found 1 space

                'user_id'     => $user = \Auth::id(),
                'gamefile_id' => $gamefileid,
                'slot_id'     => $key,
                ])
                ->first();

            if (! $save) {

This code seems to be duplicated across your project.

                $s = new GamesSavegame();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

                $s->save_data = $value;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

                $s->slot_id = $key;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

                $s->gamefile_id = $gamefileid;
                $s->user_id = \Auth::id();

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

                $s->save();
                \Log::info('created');
            } else {
                $save->save_data = $value;
                $save->save();
                \Log::info('updated');
            }
        }
    }

    public function api_save_slot(Request $request, $gamefileid, $slot)

The parameter $request is not used and could be removed.

    {
        $value = request()->getContent();
        $key = $slot;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        \Log::info('slot: '.$key);
        \Log::info('data: '.$value);
        $save = GamesSavegame::where([

Equals sign not aligned with surrounding assignments; expected 22 spaces but found 1 space

            'user_id'     => $user = \Auth::id(),
            'gamefile_id' => $gamefileid,
            'slot_id'     => $key,
            ])
            ->first();

        if (! $save) {

This code seems to be duplicated across your project.

            $s = new GamesSavegame();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

            $s->save_data = $value;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $s->slot_id = $key;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

            $s->gamefile_id = $gamefileid;
            $s->user_id = \Auth::id();

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

            $s->save();
            \Log::info('created');
        } else {
            $save->save_data = $value;
            $save->save();
            \Log::info('updated');
        }
    }
}