ReportController - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

ReportController A
last analyzed 2018-05-01 08:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	75
Duplicated Lines	24 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

Metric	Value
wmc	9
c	0
b	0
f	0
lcom	0
cbo	6
dl	18
loc	75
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	close_ticket()	9	10	1
A	open_ticket()	9	10	1
A	remark_ticket()	0	3	1
A	index()	0	8	1
A	create_game_report()	0	8	1
A	store_game_report()	0	11	1
A	index_user()	0	16	3

How to fix Duplicated Code

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use Carbon\Carbon;
use App\Models\Game;
use App\Models\UserReport;
use Illuminate\Http\Request;

class ReportController extends Controller
{
    public function index()
    {
        $r = UserReport::all();

        return view('reports.index', [
            'reports' => $r,
        ]);
    }

    public function create_game_report($gameid)
    {
        $g = Game::whereId($gameid)->first();

        return view('reports.create', [
            'game' => $g,
        ]);
    }

    public function store_game_report(Request $request, $gameid)
    {
        $r = new UserReport();
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->content_id = $gameid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->content_type = 'game';
        $r->reason = $request->get('msg');
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
        $r->save();

        return redirect()->action('ReportController@index_user');
    }

    public function index_user()
    {
        if (\Auth::check()) {
            if (\Auth::user()->can('admin-games')) {
                $ur = UserReport::all();
            } else {
                $ur = UserReport::whereUserId(\Auth::id());
            }
        } else {
            $ur = null;
        }

        return view('reports.index', [
            'reports' => $ur,
        ]);
    }

    public function close_ticket($id)

    {
        $t = UserReport::whereId($id)->first();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed = 1;
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_at = Carbon::now();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_user_id = \Auth::id();
        $t->save();

        return redirect()->action('ReportController@index_user');
    }

    public function open_ticket($id)

    {
        $t = UserReport::whereId($id)->first();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_at = Carbon::now();
$a = "a";
$ab = "ab";
$abc = "abc";
        $t->closed_user_id = \Auth::id();
        $t->save();

        return redirect()->action('ReportController@index_user');
    }

    public function remark_ticket($id)

    {
    }
}


1		<?php
2
3		/*
4		* rmarchiv.tk
5		* (c) 2016-2017 by Marcel 'ryg' Hering
6		*/
7
8		namespace App\Http\Controllers;
9
10		use Carbon\Carbon;
11		use App\Models\Game;
12		use App\Models\UserReport;
13		use Illuminate\Http\Request;
14
15		class ReportController extends Controller
16		{
17		public function index()
18		{
19		$r = UserReport::all();
20
21		return view('reports.index', [
22		'reports' => $r,
23		]);
24		}
25
26		public function create_game_report($gameid)
27		{
28		$g = Game::whereId($gameid)->first();
29
30		return view('reports.create', [
31		'game' => $g,
32		]);
33		}
34
35		public function store_game_report(Request $request, $gameid)
36		{
37		$r = new UserReport();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
38		$r->content_id = $gameid;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
39		$r->content_type = 'game';
40		$r->reason = $request->get('msg');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41		$r->user_id = \Auth::id();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
42		$r->save();
43
44		return redirect()->action('ReportController@index_user');
45		}
46
47		public function index_user()
48		{
49		if (\Auth::check()) {
50		if (\Auth::user()->can('admin-games')) {
51		$ur = UserReport::all();
52		} else {
53		$ur = UserReport::whereUserId(\Auth::id());
54		}
55		} else {
56		$ur = null;
57		}
58
59		return view('reports.index', [
60		'reports' => $ur,
61		]);
62		}
63
64	View Code Duplication	public function close_ticket($id)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$t = UserReport::whereId($id)->first();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
67		$t->closed = 1;
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
68		$t->closed_at = Carbon::now();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69		$t->closed_user_id = \Auth::id();
70		$t->save();
71
72		return redirect()->action('ReportController@index_user');
73		}
74
75	View Code Duplication	public function open_ticket($id)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		$t = UserReport::whereId($id)->first();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
78		$t->closed = 0;
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
79		$t->closed_at = Carbon::now();
		0 ignored issues – show Coding Style introduced 2017-02-06 13:51 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80		$t->closed_user_id = \Auth::id();
81		$t->save();
82
83		return redirect()->action('ReportController@index_user');
84		}
85
86		public function remark_ticket($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
87		{
88		}
89		}
90

rygos / rmarchiv

ReportController A last analyzed 2018-05-01 08:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ReportController A
last analyzed 2018-05-01 08:16 UTC