EventController - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

EventController A
last analyzed 2018-05-01 08:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	180
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

Metric	Value
wmc	25
c	0
b	0
f	0
lcom	0
cbo	7
dl	20
loc	180
rs	10

20 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	8	1
A	update()	0	23	2
A	register()	10	10	1
A	meeting_index()	0	3	1
A	meeting_show()	0	3	1
A	meeting_create()	0	3	1
A	meeting_store()	0	3	1
A	meeting_edit()	0	3	1
A	meeting_update()	0	3	1
A	picture_index()	0	3	1
A	picture_show()	0	3	1
A	picture_create()	0	3	1
A	picture_store()	0	3	1
A	picture_edit()	0	3	1
A	picture_update()	0	3	1
A	index()	0	8	1
A	show()	10	10	1
A	create()	0	4	1
B	store()	0	36	2
A	register_store()	0	17	4

How to fix Duplicated Code

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use App\Models\Event;
use App\Models\EventSetting;
use Illuminate\Http\Request;
use App\Models\EventUserRegistered;
use Illuminate\Support\Facades\Input;

class EventController extends Controller
{
    //-------------------------------------------------
    // Events
    public function index()
    {
        $events = Event::orderBy('start_date', 'desc')->get();

        return view('events.index', [
            'events' => $events,
        ]);
    }

    public function show($id)

    {
        $event = Event::whereId($id)->first();
        $reg = EventUserRegistered::whereEventId($id)->where('user_id', '=', \Auth::id())->get();
$a = "a";
$ab = "ab";
$abc = "abc";

        return view('events.show', [
            'event'    => $event,
            'reg_user' => $reg,
        ]);
    }

    public function create()
    {
        return view('events.create');
    }

    public function store(Request $request)
    {
        $this->validate($request, [
            'title'          => 'required',
            'desc'           => 'required',
            'start'          => 'required|date',
            'end'            => 'required|date',
            'slots'          => 'required|numeric',
            'reg_start_date' => 'date',
            'reg_end_date'   => 'date',
            'price'          => 'numeric',
        ]);

        $e = new Event();
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->title = $request->get('title');
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->description = $request->get('desc');
        $e->start_date = $request->get('start');
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->end_date = $request->get('end');
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->save();

        $es = new EventSetting();
$a = "a";
$ab = "ab";
$abc = "abc";
        $es->event_id = $e->id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $es->slots = $request->get('slots');
$a = "a";
$ab = "ab";
$abc = "abc";
        $es->reg_price = $request->get('price');
$a = "a";
$ab = "ab";
$abc = "abc";
        $es->reg_start_date = $request->get('reg_start');
        $es->reg_end_date = $request->get('reg_end');
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($request->get('reg_allowed') == 'on') {
            $es->reg_allowed = 1;
        } else {
            $es->reg_allowed = 0;
        }
        $es->save();

        return redirect()->action('EventController@show', [$e->id]);
    }

    public function edit($id)
    {
        $event = Event::whereId($id)->first();

        return view('events.edit', [
            'event' => $event,
        ]);
    }

    public function update($id)
    {
        $e = Event::whereId($id)->first();
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->title = Input::get('title');
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->description = Input::get('desc');
        $e->start_date = Input::get('start');
$a = "a";
$ab = "ab";
$abc = "abc";
        $e->end_date = Input::get('end');
$a = "a";
$ab = "ab";
$abc = "abc";

        $settings = EventSetting::whereEventId($id)->first();
$a = "a";
$ab = "ab";
$abc = "abc";
        $settings->slots = Input::get('slots');
$a = "a";
$ab = "ab";
$abc = "abc";
        $settings->reg_price = Input::get('price');
$a = "a";
$ab = "ab";
$abc = "abc";
        $settings->reg_start_date = Input::get('reg_start');
        $settings->reg_end_date = Input::get('reg_end');
$a = "a";
$ab = "ab";
$abc = "abc";
        $settings->reg_allowed = Input::get('reg_allowed');
$a = "a";
$ab = "ab";
$abc = "abc";
        if (Input::get('reg_allowed') == 'on') {
            $settings->reg_allowed = 1;
        } else {
            $settings->reg_allowed = 0;
        }
        $settings->save();

        return redirect()->action('EventController@show', $e->id);
    }

    public function register($eventid)

    {
        $event = Event::whereId($eventid)->first();
        $reg = EventUserRegistered::whereEventId($eventid)->where('user_id', '=', \Auth::id())->get();
$a = "a";
$ab = "ab";
$abc = "abc";

        return view('events.register', [
            'event'    => $event,
            'reg_user' => $reg,
        ]);
    }

    public function register_store($eventid)
    {
        $event = Event::whereId($eventid)->first();

        if ($event->settings->reg_allowed == 1 && $event->settings->slots > $event->users_registered->count()) {
            if (EventUserRegistered::whereEventId($eventid)->where('user_id', '=', \Auth::id())->count() == 0) {
                EventUserRegistered::firstOrNew([
                    'event_id'        => $eventid,
                    'user_id'         => \Auth::id(),
                    'reg_price_payed' => 0,
                    'reg_state'       => 0,
                ])->save();
            }
        }

        return redirect()->action('EventController@show', $eventid);
    }

    //-------------------------------------------------
    // Meetings
    public function meeting_index($eventid)

    {
    }

    public function meeting_show($id)

    {
    }

    public function meeting_create()
    {
    }

    public function meeting_store()
    {
    }

    public function meeting_edit($id)

    {
    }

    public function meeting_update($id)

    {
    }

    //-------------------------------------------------
    // Pictures
    public function picture_index()
    {
    }

    public function picture_show($id)

    {
    }

    public function picture_create()
    {
    }

    public function picture_store()
    {
    }

    public function picture_edit($id)

    {
    }

    public function picture_update($id)

    {
    }
}


1		<?php
2
3		/*
4		* rmarchiv.tk
5		* (c) 2016-2017 by Marcel 'ryg' Hering
6		*/
7
8		namespace App\Http\Controllers;
9
10		use App\Models\Event;
11		use App\Models\EventSetting;
12		use Illuminate\Http\Request;
13		use App\Models\EventUserRegistered;
14		use Illuminate\Support\Facades\Input;
15
16		class EventController extends Controller
17		{
18		//-------------------------------------------------
19		// Events
20		public function index()
21		{
22		$events = Event::orderBy('start_date', 'desc')->get();
23
24		return view('events.index', [
25		'events' => $events,
26		]);
27		}
28
29	View Code Duplication	public function show($id)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		{
31		$event = Event::whereId($id)->first();
32		$reg = EventUserRegistered::whereEventId($id)->where('user_id', '=', \Auth::id())->get();
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33
34		return view('events.show', [
35		'event' => $event,
36		'reg_user' => $reg,
37		]);
38		}
39
40		public function create()
41		{
42		return view('events.create');
43		}
44
45		public function store(Request $request)
46		{
47		$this->validate($request, [
48		'title' => 'required',
49		'desc' => 'required',
50		'start' => 'required\|date',
51		'end' => 'required\|date',
52		'slots' => 'required\|numeric',
53		'reg_start_date' => 'date',
54		'reg_end_date' => 'date',
55		'price' => 'numeric',
56		]);
57
58		$e = new Event();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
59		$e->title = $request->get('title');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
60		$e->description = $request->get('desc');
61		$e->start_date = $request->get('start');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
62		$e->end_date = $request->get('end');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
63		$e->user_id = \Auth::id();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
64		$e->save();
65
66		$es = new EventSetting();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
67		$es->event_id = $e->id;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
68		$es->slots = $request->get('slots');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
69		$es->reg_price = $request->get('price');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
70		$es->reg_start_date = $request->get('reg_start');
71		$es->reg_end_date = $request->get('reg_end');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
72		if ($request->get('reg_allowed') == 'on') {
73		$es->reg_allowed = 1;
74		} else {
75		$es->reg_allowed = 0;
76		}
77		$es->save();
78
79		return redirect()->action('EventController@show', [$e->id]);
80		}
81
82		public function edit($id)
83		{
84		$event = Event::whereId($id)->first();
85
86		return view('events.edit', [
87		'event' => $event,
88		]);
89		}
90
91		public function update($id)
92		{
93		$e = Event::whereId($id)->first();
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
94		$e->title = Input::get('title');
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
95		$e->description = Input::get('desc');
96		$e->start_date = Input::get('start');
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
97		$e->end_date = Input::get('end');
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
98
99		$settings = EventSetting::whereEventId($id)->first();
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
100		$settings->slots = Input::get('slots');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
101		$settings->reg_price = Input::get('price');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
102		$settings->reg_start_date = Input::get('reg_start');
103		$settings->reg_end_date = Input::get('reg_end');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
104		$settings->reg_allowed = Input::get('reg_allowed');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
105		if (Input::get('reg_allowed') == 'on') {
106		$settings->reg_allowed = 1;
107		} else {
108		$settings->reg_allowed = 0;
109		}
110		$settings->save();
111
112		return redirect()->action('EventController@show', $e->id);
113		}
114
115	View Code Duplication	public function register($eventid)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		$event = Event::whereId($eventid)->first();
118		$reg = EventUserRegistered::whereEventId($eventid)->where('user_id', '=', \Auth::id())->get();
		0 ignored issues – show Coding Style introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
119
120		return view('events.register', [
121		'event' => $event,
122		'reg_user' => $reg,
123		]);
124		}
125
126		public function register_store($eventid)
127		{
128		$event = Event::whereId($eventid)->first();
129
130		if ($event->settings->reg_allowed == 1 && $event->settings->slots > $event->users_registered->count()) {
131		if (EventUserRegistered::whereEventId($eventid)->where('user_id', '=', \Auth::id())->count() == 0) {
132		EventUserRegistered::firstOrNew([
133		'event_id' => $eventid,
134		'user_id' => \Auth::id(),
135		'reg_price_payed' => 0,
136		'reg_state' => 0,
137		])->save();
138		}
139		}
140
141		return redirect()->action('EventController@show', $eventid);
142		}
143
144		//-------------------------------------------------
145		// Meetings
146		public function meeting_index($eventid)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$eventid` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
147		{
148		}
149
150		public function meeting_show($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
151		{
152		}
153
154		public function meeting_create()
155		{
156		}
157
158		public function meeting_store()
159		{
160		}
161
162		public function meeting_edit($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
163		{
164		}
165
166		public function meeting_update($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
167		{
168		}
169
170		//-------------------------------------------------
171		// Pictures
172		public function picture_index()
173		{
174		}
175
176		public function picture_show($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
177		{
178		}
179
180		public function picture_create()
181		{
182		}
183
184		public function picture_store()
185		{
186		}
187
188		public function picture_edit($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
189		{
190		}
191
192		public function picture_update($id)
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
193		{
194		}
195		}
196

rygos / rmarchiv

EventController A last analyzed 2018-05-01 08:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

EventController A
last analyzed 2018-05-01 08:16 UTC