App\Http\Controllers\Api\v1\GameController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	11	1
B	show()	0	32	2
B	show_app()	0	26	1

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers\Api\v1;

use Carbon\Carbon;
use App\Models\Game;
use App\Models\GamesDeveloper;
use Dingo\Api\Routing\Helpers;
use App\Http\Controllers\Controller;

class GameController extends Controller
{
    use Helpers;

    public function index()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $games = Game::select([
            'id',
            'title',
            'subtitle',
            ])
            ->get();

        return $games;
    }

    public function show($id)
    {
        //Lade Spielinformationen
        $game = Game::whereId($id)->first();

        //Fülle Array
        $array = [
            'type'      => 'RpgGame',
            'version'   => 'rmapi_v1',
            'data_date' => Carbon::now()->toDateTimeString(),
            'game'      => [
                'title'        => $game->title,
                'subtitle'     => $game->subtitle,
                'release_date' => $game->release_date,
                'developers'   => '',
                'language'     => $game->language->short,
                'engine'       => $game->maker->short,
            ],
        ];

        //Lade Entwickler
        $developer = GamesDeveloper::whereGameId($id)->get();

The method get does only exist in Illuminate\Database\Query\Builder, but not in App\Models\GamesDeveloper.

        $t = [];

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

        foreach ($developer as $dev) {
            $t[] = $dev->developer->name;
        }
        $array['game']['developer'] = $t;

        //Lade Tags

        return $array;
    }

    public function show_app()
    {
        $games = Game::with('developers', 'user', 'maker', 'screenshots')->orderBy('created_at')->limit(25)->get();

$games is not used, you could remove the assignment.

        $jason = [
            '$jason' => [
                'head' => [
                    'title'       => 'rmarchiv',
                    'description' => 'description',
                    'offline'     => true,
                    'body'        => [
                        'type'  => 'label',
                        'text'  => 'Dies ist Zeile 1',
                        'style' => [
                            'font'    => 'HelveticaNeue',
                            'size'    => 20,
                            'color'   => '#ff0000',
                            'padding' => '10',
                        ],
                    ],
                ],
            ],
        ];

        return $jason;
    }
}