SearchFilterHelper - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

SearchFilterHelper A
last analyzed 2018-05-01 08:16 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	56.76 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
c	0
b	0
f	0
lcom	0
cbo	1
dl	21
loc	37
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	searchFilter()	21	34	4

How to fix Duplicated Code

<?php
/**
 * Created by PhpStorm.
 * User: ryg
 * Date: 21.08.17
 * Time: 09:04.
 */

namespace App\Helpers;

use App\Models\Game;

class SearchFilterHelper
{
    public static function searchFilter($searchterm)
    {
        $result = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $result['searchterm'] = $searchterm;

        preg_match_all('/maps:([0-9]+)/', $searchterm, $match);
        foreach ($match[1] as $item) {

            $game = Game::whereId($item)->first();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $t['type'] = 'maps';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $t['value'] = $item;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['filter'][] = $t;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
        }

        preg_match_all('/maps-min:([0-9]+)/', $searchterm, $match);
        foreach ($match[1] as $item) {

            $game = Game::whereId($item)->first();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $t['type'] = 'maps-min';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $t['value'] = $item;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['filter'][] = $t;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
        }

        preg_match_all('/maps-max:([0-9]+)/', $searchterm, $match);
        foreach ($match[1] as $item) {

            $game = Game::whereId($item)->first();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $t['type'] = 'maps-max';
$a = "a";
$ab = "ab";
$abc = "abc";
            $t['value'] = $item;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['filter'][] = $t;
$a = "a";
$ab = "ab";
$abc = "abc";
            $result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
        }

        return $result;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: ryg
5		* Date: 21.08.17
6		* Time: 09:04.
7		*/
8
9		namespace App\Helpers;
10
11		use App\Models\Game;
12
13		class SearchFilterHelper
14		{
15		public static function searchFilter($searchterm)
16		{
17		$result = [];
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
18		$result['searchterm'] = $searchterm;
19
20		preg_match_all('/maps:([0-9]+)/', $searchterm, $match);
21	View Code Duplication	foreach ($match[1] as $item) {
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		$game = Game::whereId($item)->first();
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `$game` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23		$t['type'] = 'maps';
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `$t` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$t = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24		$t['value'] = $item;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25		$result['filter'][] = $t;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26		$result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
27		}
28
29		preg_match_all('/maps-min:([0-9]+)/', $searchterm, $match);
30	View Code Duplication	foreach ($match[1] as $item) {
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		$game = Game::whereId($item)->first();
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `$game` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32		$t['type'] = 'maps-min';
		0 ignored issues – show Bug introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report The variable `$t` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33		$t['value'] = $item;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34		$result['filter'][] = $t;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35		$result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
36		}
37
38		preg_match_all('/maps-max:([0-9]+)/', $searchterm, $match);
39	View Code Duplication	foreach ($match[1] as $item) {
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		$game = Game::whereId($item)->first();
		0 ignored issues – show Unused Code introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `$game` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41		$t['type'] = 'maps-max';
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
42		$t['value'] = $item;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43		$result['filter'][] = $t;
		0 ignored issues – show Coding Style introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
44		$result['searchterm'] = str_replace($t['type'].':'.$t['value'], '', $result['searchterm']);
45		}
46
47		return $result;
48		}
49		}
50

rygos / rmarchiv

SearchFilterHelper A last analyzed 2018-05-01 08:16 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

SearchFilterHelper A
last analyzed 2018-05-01 08:16 UTC