App\Helpers\PlayerHelper

Complexity

Total Complexity

8

Size/Duplication

Total Lines	81
Duplicated Lines	76.54 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSavegameValidation()	0	15	2
B	getZipRootPath()	62	62	6

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Helpers;

use PhpBinaryReader\BinaryReader;

class PlayerHelper
{
    public static function getSavegameValidation($data)
    {
        $br = new BinaryReader($data);

        $br->setPosition(0);

        $datalength = $br->readInt8();
        $returned = $br->readString($datalength);

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        if ($returned == 'LcfSaveData') {
            return true;
        } else {
            return false;
        }
    }

    public function getZipRootPath($zipfilepath)

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        $dirarray = [
            'backdrop',
            'battle',
            'battle2',
            'battlecharset',
            'battleweapon',
            'charset',
            'chipset',
            'faceset',
            'frame',
            'gameover',
            'monster',
            'panorama',
            'picture',
            'system',
            'system2',
            'title',
            'music',
            'sound',
        ];

        $rootarray = [
            'harmony.dll',
            'rpg_rt.exe',
            'rpg_rt.ini',
            'rpg_rt.ldb',
            'rpg_rt.lmt',
            'rpg_rt.dat',
        ];

        $mapparray = [];
        for ($i = 0; $i < 2000; $i++) {
            $mapparray[] = 'map'.sprintf('%04d', $i).'.lmu';
        }

        $filearray = array_merge($rootarray, $mapparray);

        $searcharray = array_merge($dirarray, $filearray);

        if (starts_with(strtolower($zipfilepath), $searcharray)) {
            $imp = str_replace('/', '\\/', $zipfilepath);
        } else {
            if (str_contains(strtolower($zipfilepath), $searcharray)) {
                $exp = explode('/', $zipfilepath);
                $res = array_shift($exp);

$res is not used, you could remove the assignment.

                $imp = implode('/', $exp);
                $imp = $this->getZipRootPath($imp);
            } else {
                $imp = '';
            }
        }

        if ($imp != '') {
            if (array_search(strtolower($imp), $filearray)) {
                $imp = '.\\/'.$imp;
            }
        }

        return $imp;
    }
}