DeferredExtension::resolve() - Code Metrics - Inspection of "Add Twig 3 support" - rybakit/twig-deferred-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Eugene

created 2020-06-02 17:33 UTC

DeferredExtension::resolve() A

↳ Parent: DeferredExtension

Complexity

Conditions	4
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.6
c	0
b	0
f	0
cc	4
nc	5
nop	3

<?php

namespace Twig\DeferredExtension;

use Twig\Extension\AbstractExtension;
use Twig\Template;

final class DeferredExtension extends AbstractExtension
{
    private $blocks = [];

    public function getTokenParsers()
    {
        return [new DeferredTokenParser()];
    }

    public function getNodeVisitors()
    {
        return [new DeferredNodeVisitor()];
    }

    public function defer(Template $template, $blockName)
    {
        $templateName = $template->getTemplateName();
        $this->blocks[$templateName][] = $blockName;
        ob_start();
    }

    public function resolve(Template $template, array $context, array $blocks)
    {
        $templateName = $template->getTemplateName();
        if (empty($this->blocks[$templateName])) {
            return;
        }

        while ($blockName = array_pop($this->blocks[$templateName])) {
            $buffer = ob_get_clean();

            $blocks[$blockName] = [$template, 'block_'.$blockName.'_deferred'];
            $template->displayBlock($blockName, $context, $blocks);

            echo $buffer;
        }

        if ($parent = $template->getParent($context)) {
            $this->resolve($parent, $context, $blocks);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
    }
}


1			<?php
2
3			namespace Twig\DeferredExtension;
4
5			use Twig\Extension\AbstractExtension;
6			use Twig\Template;
7
8			final class DeferredExtension extends AbstractExtension
9			{
10			private $blocks = [];
11
12			public function getTokenParsers()
13			{
14			return [new DeferredTokenParser()];
15			}
16
17			public function getNodeVisitors()
18			{
19			return [new DeferredNodeVisitor()];
20			}
21
22			public function defer(Template $template, $blockName)
23			{
24			$templateName = $template->getTemplateName();
25			$this->blocks[$templateName][] = $blockName;
26			ob_start();
27			}
28
29			public function resolve(Template $template, array $context, array $blocks)
30			{
31			$templateName = $template->getTemplateName();
32			if (empty($this->blocks[$templateName])) {
33			return;
34			}
35
36			while ($blockName = array_pop($this->blocks[$templateName])) {
37			$buffer = ob_get_clean();
38
39			$blocks[$blockName] = [$template, 'block_'.$blockName.'_deferred'];
40			$template->displayBlock($blockName, $context, $blocks);
41
42			echo $buffer;
43			}
44
45			if ($parent = $template->getParent($context)) {
46			$this->resolve($parent, $context, $blocks);
			0 ignored issues – show Bug introduced 2020-06-02 17:36 UTC by Report Bug Copy Issue Report It seems like `$parent` defined by `$template->getParent($context)` on line `45` can also be of type `object<Twig\TemplateWrapper>`; however, `Twig\DeferredExtension\D...redExtension::resolve()` does only seem to accept `object<Twig\Template>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
47			}
48			}
49			}
50

rybakit / twig-deferred-extension

Pull Request — master (#9)

DeferredExtension::resolve() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like