DeferredNodeVisitor::leaveNode() - Code Metrics - Inspection of "Add Twig 3 support" - rybakit/twig-deferred-extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Eugene

created 2020-06-02 17:32 UTC

DeferredNodeVisitor::leaveNode() A

↳ Parent: DeferredNodeVisitor

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	3
nc	2
nop	2

<?php

namespace Twig\DeferredExtension;

use Twig\Environment;
use Twig\Node\ModuleNode;
use Twig\Node\Node;
use Twig\NodeVisitor\NodeVisitorInterface;

final class DeferredNodeVisitor implements NodeVisitorInterface
{
    private $hasDeferred = false;

    public function enterNode(Node $node, Environment $env): Node
    {
        if (!$this->hasDeferred && $node instanceof DeferredBlockNode) {
            $this->hasDeferred = true;
        }

        return $node;
    }

    public function leaveNode(Node $node, Environment $env): ?Node
    {
        if ($this->hasDeferred && $node instanceof ModuleNode) {
            $node->setNode('display_end', new Node([new DeferredNode(), $node->getNode('display_end')]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->hasDeferred = false;
        }

        return $node;
    }

    public function getPriority()
    {
        return 0;
    }
}


1			<?php
2
3			namespace Twig\DeferredExtension;
4
5			use Twig\Environment;
6			use Twig\Node\ModuleNode;
7			use Twig\Node\Node;
8			use Twig\NodeVisitor\NodeVisitorInterface;
9
10			final class DeferredNodeVisitor implements NodeVisitorInterface
11			{
12			private $hasDeferred = false;
13
14			public function enterNode(Node $node, Environment $env): Node
15			{
16			if (!$this->hasDeferred && $node instanceof DeferredBlockNode) {
17			$this->hasDeferred = true;
18			}
19
20			return $node;
21			}
22
23			public function leaveNode(Node $node, Environment $env): ?Node
24			{
25			if ($this->hasDeferred && $node instanceof ModuleNode) {
26			$node->setNode('display_end', new Node([new DeferredNode(), $node->getNode('display_end')]));
			0 ignored issues – show Documentation introduced 2020-06-02 17:36 UTC by Report Bug Copy Issue Report `new \Twig\Node\Node(arra...etNode('display_end')))` is of type `object<Twig\Node\Node>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			$this->hasDeferred = false;
28			}
29
30			return $node;
31			}
32
33			public function getPriority()
34			{
35			return 0;
36			}
37			}
38

rybakit / twig-deferred-extension

Pull Request — master (#9)

DeferredNodeVisitor::leaveNode() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like