Phive\Queue\Tests\Queue\Concurrency

Complexity

Total Complexity

9

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testConcurrency()	0	49	8
A	getConcurrencyQueueSize()	0	4	1

<?php

/*
 * This file is part of the Phive Queue package.
 *
 * (c) Eugene Leonovich <gen.work@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Phive\Queue\Tests\Queue;

trait Concurrency
{
    use Persistence;

    /**
     * @group concurrency
     */
    public function testConcurrency()
    {
        if (!class_exists('GearmanClient', false)) {
            $this->markTestSkipped('pecl/gearman is required for this test to run.');

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        $client = new \GearmanClient();
        $client->addServer();

        $workerIds = [];
        $poppedItems = [];
        $client->setCompleteCallback(function (\GearmanTask $task) use (&$workerIds, &$poppedItems) {
            $data = explode(':', $task->data(), 2);
            if (!is_array($data) || 2 !== count($data)) {
                return;
            }

            list($workerId, $item) = $data;

            $workerIds[$workerId] = true;

            if (!isset($poppedItems[$item])) {
                $poppedItems[$item] = true;
            }
        });

        $queueSize = $this->getConcurrencyQueueSize();
        $this->assertGreaterThan(10, $queueSize, 'Queue size is too small to test concurrency.');

It seems like assertGreaterThan() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $workload = serialize(self::getHandler());
        for ($i = 1; $i <= $queueSize; $i++) {
            $this->queue->push($i);

The property queue does not exist. Did you maybe forget to declare it?

            $client->addTask('pop', $workload);
        }

        try {
            // run the tasks in parallel (assuming multiple workers)
            $result = $client->runTasks();
        } catch (\GearmanException $e) {

The class GearmanException does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $result = false;
        }

        if (!$result) {
            $this->markTestSkipped('Unable to run gearman tasks. Check if gearman server is running.');

It seems like markTestSkipped() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        $this->assertEquals($queueSize, count($poppedItems));

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertGreaterThan(1, count($workerIds), 'Not enough workers to test concurrency.');

It seems like assertGreaterThan() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    protected function getConcurrencyQueueSize()
    {
        return (int) getenv('PHIVE_CONCUR_QUEUE_SIZE');
    }
}