ArrayIteratorTransformer::unpack() - Code Metrics - Inspection of "Enhance type transformers" - rybakit/msgpack.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Eugene

created 2018-04-03 21:23 UTC

ArrayIteratorTransformer::unpack() B

↳ Parent: ArrayIteratorTransformer

Complexity

Conditions	5
Paths	6

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	6
nop	2

<?php

namespace App\MessagePack;

use MessagePack\BufferUnpacker;
use MessagePack\Packer;
use MessagePack\TypeTransformer\Extension;

class ArrayIteratorTransformer implements Extension
{
    private $type;

    public function __construct($type)
    {
        $this->type = $type;
    }

    public function getType()
    {
        return $this->type;
    }

    public function pack(Packer $packer, $value)
    {
        if (!$value instanceof \ArrayIterator) {
            return null;
        }

        $size = 0;
        $data = '';
        foreach ($value as $item) {
            $data .= $packer->pack($item);
            ++$size;
        }

        if ($size <= 0xf) {
            $data = \chr(0x90 | $size).$data;
        } elseif ($size <= 0xffff) {
            $data = "\xdc".\chr($size >> 8).\chr($size).$data;
        } else {
            $data = \pack('CN', 0xdd, $size).$data;
        }

        return $packer->packExt($this->type, $data);
    }

    public function unpack(BufferUnpacker $unpacker, $length)
    {
        $c = $unpacker->unpackUint8();

        if ($c >= 0x90 && $c <= 0x9f) {
            $size = $c & 0xf;
        } elseif (0xdc === $c) {
            $size = $unpacker->unpackUint16();
        } else {
            $size = $unpacker->unpackUint32();
        }

        while ($size--) {
            yield $unpacker->unpack();
        }
    }
}


1			<?php
2
3			namespace App\MessagePack;
4
5			use MessagePack\BufferUnpacker;
6			use MessagePack\Packer;
7			use MessagePack\TypeTransformer\Extension;
8
9			class ArrayIteratorTransformer implements Extension
10			{
11			private $type;
12
13			public function __construct($type)
14			{
15			$this->type = $type;
16			}
17
18			public function getType()
19			{
20			return $this->type;
21			}
22
23			public function pack(Packer $packer, $value)
24			{
25			if (!$value instanceof \ArrayIterator) {
26			return null;
27			}
28
29			$size = 0;
30			$data = '';
31			foreach ($value as $item) {
32			$data .= $packer->pack($item);
33			++$size;
34			}
35
36			if ($size <= 0xf) {
37			$data = \chr(0x90 \| $size).$data;
38			} elseif ($size <= 0xffff) {
39			$data = "\xdc".\chr($size >> 8).\chr($size).$data;
40			} else {
41			$data = \pack('CN', 0xdd, $size).$data;
42			}
43
44			return $packer->packExt($this->type, $data);
45			}
46
47			public function unpack(BufferUnpacker $unpacker, $length)
48			{
49			$c = $unpacker->unpackUint8();
50
51			if ($c >= 0x90 && $c <= 0x9f) {
52			$size = $c & 0xf;
53			} elseif (0xdc === $c) {
54			$size = $unpacker->unpackUint16();
55			} else {
56			$size = $unpacker->unpackUint32();
57			}
58
59			while ($size--) {
60			yield $unpacker->unpack();
61			}
62			}
63			}
64

rybakit / msgpack.php

Pull Request — master (#21)

ArrayIteratorTransformer::unpack() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like