rybakit /
msgpack.php
| Conditions | 23 |
| Paths | 1 |
| Total Lines | 34 |
| Code Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 26 |
| CRAP Score | 23 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | 68 | public static function invalidMapKeyType(int $code) : self |
|
| 27 | { |
||
| 28 | 68 | $type = (static function () use ($code) : ?string { |
|
| 29 | 68 | if ($code >= 0x90 && $code <= 0x9f) { |
|
| 30 | 8 | return 'array'; |
|
| 31 | } |
||
| 32 | 60 | if ($code >= 0x80 && $code <= 0x8f) { |
|
| 33 | 12 | return 'map'; |
|
| 34 | } |
||
| 35 | |||
| 36 | switch ($code) { |
||
| 37 | 48 | case 0xc0: return 'nil'; |
|
| 38 | 46 | case 0xc2: |
|
| 39 | 46 | case 0xc3: return 'bool'; |
|
| 40 | 42 | case 0xca: |
|
| 41 | 42 | case 0xcb: return 'float'; |
|
| 42 | 32 | case 0xdc: |
|
| 43 | 32 | case 0xdd: return 'array'; |
|
| 44 | 26 | case 0xde: |
|
| 45 | 26 | case 0xdf: return 'map'; |
|
| 46 | 18 | case 0xd4: |
|
| 47 | 16 | case 0xd5: |
|
| 48 | 14 | case 0xd6: |
|
| 49 | 12 | case 0xd7: |
|
| 50 | 10 | case 0xd8: |
|
| 51 | 8 | case 0xc7: |
|
| 52 | 6 | case 0xc8: |
|
| 53 | 18 | case 0xc9: return 'ext'; |
|
| 54 | } |
||
| 55 | |||
| 56 | 2 | return null; |
|
| 57 | 68 | })(); |
|
| 58 | |||
| 59 | 68 | return new self('Invalid map key type: expected int, str or bin but got '.(\is_null($type) ? \sprintf('0x%x', $code) : \sprintf('%s (0x%x)', $type, $code))); |
|
| 60 | } |
||
| 62 |
