ArgumentsResolver\ArgumentsResolver

Complexity

Total Complexity

8

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
B	resolve()	0	27	5
A	getParameters()	0	4	1
	match()	0	1	?

<?php

namespace ArgumentsResolver;

abstract class ArgumentsResolver
{
    /**
     * @var \ReflectionFunctionAbstract
     */
    protected $reflection;

    /**
     * @param mixed $function
     */
    public function __construct($function)
    {
        $this->reflection = $function instanceof \ReflectionFunctionAbstract
            ? $function
            : ReflectionFactory::create($function);
    }

    /**
     * Resolves function arguments.
     *
     * @param array $parameters
     *
     * @return array
     *
     * @throws UnresolvableArgumentException
     */
    public function resolve(array $parameters)
    {
        if (!$number = $this->reflection->getNumberOfParameters()) {
            return [];
        }

        $arguments = array_fill(0, $number, null);

        foreach ($this->getParameters() as $pos => $parameter) {
            $result = $this->match($parameter, $parameters);

            if ($result) {

The expression $result of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $arguments[$pos] = $result[1];
                unset($parameters[$result[0]]);
                continue;
            }

            if ($parameter->isDefaultValueAvailable()) {
                $arguments[$pos] = $parameter->getDefaultValue();
                continue;
            }

            throw new UnresolvableArgumentException($parameter);
        }

        return $arguments;
    }

    /**
     * Returns an array of reflection parameters.
     *
     * @return \ReflectionParameter[]
     */
    protected function getParameters()
    {
        return $this->reflection->getParameters();
    }

    /**
     * Returns the [key, value] pair if the parameter is matched or null otherwise.
     *
     * @param \ReflectionParameter $parameter
     * @param array                $parameters
     *
     * @return array|null
     */
    abstract protected function match(\ReflectionParameter $parameter, array $parameters);
}