Issues in Deals.php (master) - Issues in master - ryanwinchester/hubspot-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (318)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Resources/Deals.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace SevenShores\Hubspot\Resources;

use SevenShores\Hubspot\Exceptions\HubspotException;

class Deals extends Resource
{
    /**
     * @param array $deal Array of deal properties.
     * @return mixed
     * @throws HubSpotException
     */
    function create(array $deal)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal";

        $options['json'] = $deal;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $this->client->request('post', $endpoint, $options);
    }

    /**
     * @param int $id The deal id.
     * @param array $deal The deal properties to update.
     * @return mixed
     */
    function update($id, array $deal)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";

        $options['json'] = $deal;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $this->client->request('put', $endpoint, $options);
    }

    /**
     * Update a group of existing deal records by their dealId.
     *
     * @see https://developers.hubspot.com/docs/methods/deals/batch-update-deals
     *
     * @param array $deals The deals and properties.
     * @return \SevenShores\Hubspot\Http\Response
     */
    function updateBatch(array $deals)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/batch-async/update";

        $options['json'] = $deals;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $this->client->request('post', $endpoint, $options);
    }

    /**
     * @param array $params
     *
     * @return \Psr\Http\Message\ResponseInterface|\SevenShores\Hubspot\Http\Response
     * @throws \SevenShores\Hubspot\Exceptions\BadRequest
     */
    function getAll(array $params = []){

        $endpoint = "https://api.hubapi.com/deals/v1/deal/paged";

        $queryString = build_query_string($params);

        return $this->client->request('get', $endpoint, [], $queryString);
    }


    /**
     * @param int $id
     * @return mixed
     */
    function delete($id)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";

        return $this->client->request('delete', $endpoint);
    }

    /**
     * @param array $params Optional parameters ['limit', 'offset']
     * @return mixed
     */
    function getRecentlyModified(array $params = [])

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/recent/modified";
        $queryString = build_query_string($params);

        return $this->client->request('get', $endpoint, [], $queryString);
    }

    /**
     * @param array $params Optional parameters ['limit', 'offset']
     * @return mixed
     */
    function getRecentlyCreated(array $params = [])

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/recent/created";
        $queryString = build_query_string($params);

        return $this->client->request('get', $endpoint, [], $queryString);
    }

    /**
     * @param int $id
     * @return mixed
     */
    function getById($id)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";

        return $this->client->request('get', $endpoint);
    }

    /**
     * @param int $dealId
     * @param int|int[] $companyIds
     * @return mixed
     */
    function associateWithCompany($dealId, $companyIds)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/COMPANY";

        $queryString = build_query_string(['id' => (array)$companyIds]);

        return $this->client->request('put', $endpoint, [], $queryString);
    }

    /**
     * @param int $dealId
     * @param int|int[] $companyIds
     * @return mixed
     */
    function disassociateFromCompany($dealId, $companyIds)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/COMPANY";

        $queryString = build_query_string(['id' => (array)$companyIds]);

        return $this->client->request('delete', $endpoint, [], $queryString);
    }

    /**
     * @param int $dealId
     * @param int|int[] $contactIds
     * @return mixed
     */
    function associateWithContact($dealId, $contactIds)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/CONTACT";

        $queryString = build_query_string(['id' => (array)$contactIds]);

        return $this->client->request('put', $endpoint, [], $queryString);
    }

    /**
     * @param int $contactId
     * @param array $params Optional parameters ['limit', 'offset']
     * @return mixed
     */
    function associatedWithContact($contactId, $params = [])

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/associated/contact/{$contactId}/paged";

        $queryString = build_query_string($params);

        return $this->client->request('get', $endpoint, [], $queryString);
    }

    /**
     * @param int $dealId
     * @param int|int[] $contactIds
     * @return mixed
     */
    function disassociateFromContact($dealId, $contactIds)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/CONTACT";

        $queryString = build_query_string(['id' => (array)$contactIds]);

        return $this->client->request('delete', $endpoint, [], $queryString);
    }

    /**
     * @param string $objectType
     * @param int $objectId
     * @param array $params
     * @return \Psr\Http\Message\ResponseInterface|\SevenShores\Hubspot\Http\Response
     *
     * @see https://developers.hubspot.com/docs/methods/deals/get-associated-deals
     */
    public function getAssociatedDeals($objectType, $objectId, $params = [])
    {
        $endpoint = "https://api.hubapi.com/deals/v1/deal/associated/{$objectType}/{$objectId}/paged";

        $queryString = build_query_string($params);

        return $this->client->request('get', $endpoint, [], $queryString);
    }
}


1		<?php
2		namespace SevenShores\Hubspot\Resources;
3
4		use SevenShores\Hubspot\Exceptions\HubspotException;
5
6		class Deals extends Resource
7		{
8		/**
9		* @param array $deal Array of deal properties.
10		* @return mixed
11		* @throws HubSpotException
12		*/
13		function create(array $deal)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
14		{
15		$endpoint = "https://api.hubapi.com/deals/v1/deal";
16
17		$options['json'] = $deal;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
18
19		return $this->client->request('post', $endpoint, $options);
20		}
21
22		/**
23		* @param int $id The deal id.
24		* @param array $deal The deal properties to update.
25		* @return mixed
26		*/
27	View Code Duplication	function update($id, array $deal)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
28		{
29		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";
30
31		$options['json'] = $deal;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
32
33		return $this->client->request('put', $endpoint, $options);
34		}
35
36		/**
37		* Update a group of existing deal records by their dealId.
38		*
39		* @see https://developers.hubspot.com/docs/methods/deals/batch-update-deals
40		*
41		* @param array $deals The deals and properties.
42		* @return \SevenShores\Hubspot\Http\Response
43		*/
44		function updateBatch(array $deals)
		0 ignored issues – show Best Practice introduced 2018-11-27 14:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
45		{
46		$endpoint = "https://api.hubapi.com/deals/v1/batch-async/update";
47
48		$options['json'] = $deals;
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-11-27 14:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
49
50		return $this->client->request('post', $endpoint, $options);
51		}
52
53		/**
54		* @param array $params
55		*
56		* @return \Psr\Http\Message\ResponseInterface\|\SevenShores\Hubspot\Http\Response
57		* @throws \SevenShores\Hubspot\Exceptions\BadRequest
58		*/
59		function getAll(array $params = []){
		0 ignored issues – show Best Practice introduced 2017-04-07 12:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
60		$endpoint = "https://api.hubapi.com/deals/v1/deal/paged";
61
62		$queryString = build_query_string($params);
63
64		return $this->client->request('get', $endpoint, [], $queryString);
65		}
66
67
68		/**
69		* @param int $id
70		* @return mixed
71		*/
72		function delete($id)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
73		{
74		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";
75
76		return $this->client->request('delete', $endpoint);
77		}
78
79		/**
80		* @param array $params Optional parameters ['limit', 'offset']
81		* @return mixed
82		*/
83		function getRecentlyModified(array $params = [])
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
84		{
85		$endpoint = "https://api.hubapi.com/deals/v1/deal/recent/modified";
86		$queryString = build_query_string($params);
87
88		return $this->client->request('get', $endpoint, [], $queryString);
89		}
90
91		/**
92		* @param array $params Optional parameters ['limit', 'offset']
93		* @return mixed
94		*/
95		function getRecentlyCreated(array $params = [])
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
96		{
97		$endpoint = "https://api.hubapi.com/deals/v1/deal/recent/created";
98		$queryString = build_query_string($params);
99
100		return $this->client->request('get', $endpoint, [], $queryString);
101		}
102
103		/**
104		* @param int $id
105		* @return mixed
106		*/
107		function getById($id)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
108		{
109		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$id}";
110
111		return $this->client->request('get', $endpoint);
112		}
113
114		/**
115		* @param int $dealId
116		* @param int\|int[] $companyIds
117		* @return mixed
118		*/
119		function associateWithCompany($dealId, $companyIds)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
120		{
121		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/COMPANY";
122
123		$queryString = build_query_string(['id' => (array)$companyIds]);
124
125		return $this->client->request('put', $endpoint, [], $queryString);
126		}
127
128		/**
129		* @param int $dealId
130		* @param int\|int[] $companyIds
131		* @return mixed
132		*/
133		function disassociateFromCompany($dealId, $companyIds)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
134		{
135		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/COMPANY";
136
137		$queryString = build_query_string(['id' => (array)$companyIds]);
138
139		return $this->client->request('delete', $endpoint, [], $queryString);
140		}
141
142		/**
143		* @param int $dealId
144		* @param int\|int[] $contactIds
145		* @return mixed
146		*/
147		function associateWithContact($dealId, $contactIds)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
148		{
149		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/CONTACT";
150
151		$queryString = build_query_string(['id' => (array)$contactIds]);
152
153		return $this->client->request('put', $endpoint, [], $queryString);
154		}
155
156		/**
157		* @param int $contactId
158		* @param array $params Optional parameters ['limit', 'offset']
159		* @return mixed
160		*/
161		function associatedWithContact($contactId, $params = [])
		0 ignored issues – show Best Practice introduced 2017-06-20 08:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
162		{
163		$endpoint = "https://api.hubapi.com/deals/v1/deal/associated/contact/{$contactId}/paged";
164
165		$queryString = build_query_string($params);
166
167		return $this->client->request('get', $endpoint, [], $queryString);
168		}
169
170		/**
171		* @param int $dealId
172		* @param int\|int[] $contactIds
173		* @return mixed
174		*/
175		function disassociateFromContact($dealId, $contactIds)
		0 ignored issues – show Best Practice introduced 2016-06-04 02:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
176		{
177		$endpoint = "https://api.hubapi.com/deals/v1/deal/{$dealId}/associations/CONTACT";
178
179		$queryString = build_query_string(['id' => (array)$contactIds]);
180
181		return $this->client->request('delete', $endpoint, [], $queryString);
182		}
183
184		/**
185		* @param string $objectType
186		* @param int $objectId
187		* @param array $params
188		* @return \Psr\Http\Message\ResponseInterface\|\SevenShores\Hubspot\Http\Response
189		*
190		* @see https://developers.hubspot.com/docs/methods/deals/get-associated-deals
191		*/
192		public function getAssociatedDeals($objectType, $objectId, $params = [])
193		{
194		$endpoint = "https://api.hubapi.com/deals/v1/deal/associated/{$objectType}/{$objectId}/paged";
195
196		$queryString = build_query_string($params);
197
198		return $this->client->request('get', $endpoint, [], $queryString);
199		}
200		}
201

ryanwinchester / hubspot-php

Issues (318)

Security Analysis no request data

src/Resources/Deals.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like