DealProperties - Code Metrics - Inspection of "Create a deal property" - ryanwinchester/hubspot-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9f4de8...df05ba )

by Ryan

created 2017-06-23 20:51 UTC

DealProperties A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	14.52 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	9
loc	62
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	6	1
A	create()	0	8	1
A	update()	9	9	1

How to fix Duplicated Code

<?php

namespace SevenShores\Hubspot\Resources;

class DealProperties extends Resource
{

    /**
     * Get a Deal Property.
     *
     * Returns a JSON object representing the definition for a given deal property.
     *
     * @see http://developers.hubspot.com/docs/methods/deals/get_deal_property
     *
     * @param string $name The name of the property.
     * @return \SevenShores\Hubspot\Http\Response
     */
    function get($name)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/properties/named/{$name}";

        return $this->client->request('get', $endpoint);
    }

    /**
     * Create a deal property.
     *
     * Create a property on every deal object to store a specific piece of data. In the example below,
     * we want to store an invoice number on a separate field on deals.
     *
     * @see https://developers.hubspot.com/docs/methods/deals/create_deal_property
     *
     * @param array $property
     * @return \SevenShores\Hubspot\Http\Response
     */
    function create($property)

    {
        $endpoint = "https://api.hubapi.com/properties/v1/deals/properties/";

        $options['json'] = $property;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $this->client->request('post', $endpoint, $options);
    }

    /**
     * Update a deal property.
     *
     * Update a specified deal property.
     *
     * @see http://developers.hubspot.com/docs/methods/deals/update_deal_property
     *
     * @param string $name
     * @param array  $property
     * @return \SevenShores\Hubspot\Http\Response
     */
    function update($name, $property)

    {
        $endpoint = "https://api.hubapi.com/deals/v1/properties/named/{$name}";

        $property['name'] = $name;
        $options['json'] = $property;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return $this->client->request('put', $endpoint, $options);
    }

}


1		<?php
2
3		namespace SevenShores\Hubspot\Resources;
4
5		class DealProperties extends Resource
6		{
7
8		/**
9		* Get a Deal Property.
10		*
11		* Returns a JSON object representing the definition for a given deal property.
12		*
13		* @see http://developers.hubspot.com/docs/methods/deals/get_deal_property
14		*
15		* @param string $name The name of the property.
16		* @return \SevenShores\Hubspot\Http\Response
17		*/
18		function get($name)
		0 ignored issues – show Best Practice introduced 2016-07-20 22:27 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
19		{
20		$endpoint = "https://api.hubapi.com/deals/v1/properties/named/{$name}";
21
22		return $this->client->request('get', $endpoint);
23		}
24
25		/**
26		* Create a deal property.
27		*
28		* Create a property on every deal object to store a specific piece of data. In the example below,
29		* we want to store an invoice number on a separate field on deals.
30		*
31		* @see https://developers.hubspot.com/docs/methods/deals/create_deal_property
32		*
33		* @param array $property
34		* @return \SevenShores\Hubspot\Http\Response
35		*/
36		function create($property)
		0 ignored issues – show Best Practice introduced 2017-06-23 20:55 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
37		{
38		$endpoint = "https://api.hubapi.com/properties/v1/deals/properties/";
39
40		$options['json'] = $property;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-23 20:55 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
41
42		return $this->client->request('post', $endpoint, $options);
43		}
44
45		/**
46		* Update a deal property.
47		*
48		* Update a specified deal property.
49		*
50		* @see http://developers.hubspot.com/docs/methods/deals/update_deal_property
51		*
52		* @param string $name
53		* @param array $property
54		* @return \SevenShores\Hubspot\Http\Response
55		*/
56	View Code Duplication	function update($name, $property)
		0 ignored issues – show Best Practice introduced 2016-07-20 22:27 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
57		{
58		$endpoint = "https://api.hubapi.com/deals/v1/properties/named/{$name}";
59
60		$property['name'] = $name;
61		$options['json'] = $property;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-20 22:27 UTC by Report Bug Copy Issue Report `$options` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$options = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
62
63		return $this->client->request('put', $endpoint, $options);
64		}
65
66		}
67

ryanwinchester / hubspot-php

Push — master ( 9f4de8...df05ba )

DealProperties A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like