Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class Comments extends Resource |
||
| 6 | { |
||
| 7 | /** |
||
| 8 | * Get all comments. |
||
| 9 | * |
||
| 10 | * @param array $params Optional parameters ['limit', 'offset', 'portalId', 'state', 'contentId', 'reverse'] |
||
| 11 | * @return \SevenShores\Hubspot\Http\Response |
||
| 12 | */ |
||
| 13 | View Code Duplication | function all($params = []) |
|
|
|
|||
| 14 | { |
||
| 15 | $endpoint = 'https://api.hubapi.com/comments/v3/comments'; |
||
| 16 | |||
| 17 | $queryString = build_query_string($params); |
||
| 18 | |||
| 19 | return $this->client->request('get', $endpoint, [], $queryString); |
||
| 20 | } |
||
| 21 | |||
| 22 | /** |
||
| 23 | * Get information about a specific comment. |
||
| 24 | * |
||
| 25 | * @param string $id |
||
| 26 | * @return \SevenShores\Hubspot\Http\Response |
||
| 27 | */ |
||
| 28 | function getById($id) |
||
| 34 | |||
| 35 | |||
| 36 | } |
||
| 37 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.