AbstractImageOptimiserFactory - Code Metrics - rvdlee/zf-image-optimiser - Measure and Improve Code Quality continuously with Scrutinizer

AbstractImageOptimiserFactory A
last analyzed 2019-10-15 20:56 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
eloc	17
dl	0
loc	30
rs	10
c	1
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	28	6

<?php

namespace Rvdlee\ZfImageOptimiser\Factory\Adapter;

use Interop\Container\ContainerInterface;
use Zend\ServiceManager\Factory\FactoryInterface;
use Zend\Validator\ValidatorChain;

abstract class AbstractImageOptimiserFactory implements FactoryInterface
{
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /** @var array $config */
        $config = $container->get('config');

        $binaryOptions = [];
        if (isset($config['rvdlee']['zf-image-optimiser'][$requestedName]['binary-options'])) {
            $binaryOptions = $config['rvdlee']['zf-image-optimiser'][$requestedName]['binary-options'];
        }

        $validatorChain = [];
        if (isset($config['rvdlee']['zf-image-optimiser'][$requestedName]['validator-chain'])) {
            $validatorChainConfigs = $config['rvdlee']['zf-image-optimiser'][$requestedName]['validator-chain'];

            $validatorChain = new ValidatorChain();
            /** @var array $validatorChainConfig */
            foreach ($validatorChainConfigs as $validatorChainConfig) {
                if (class_exists($validatorChainConfig['name'])) {
                    $validatorConfig = isset($validatorChainConfig['options']) ? $validatorChainConfig['options'] : [];
                    $validator = new $validatorChainConfig['name']($validatorConfig);
                    $validatorChain->attach($validator);
                }
            }
        }

        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            $binaryOptions,
            $validatorChain
        ];
    }
}

1			<?php
2
3			namespace Rvdlee\ZfImageOptimiser\Factory\Adapter;
4
5			use Interop\Container\ContainerInterface;
6			use Zend\ServiceManager\Factory\FactoryInterface;
7			use Zend\Validator\ValidatorChain;
8
9			abstract class AbstractImageOptimiserFactory implements FactoryInterface
10			{
11			public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
12			{
13			/** @var array $config */
14			$config = $container->get('config');
15
16			$binaryOptions = [];
17			if (isset($config['rvdlee']['zf-image-optimiser'][$requestedName]['binary-options'])) {
18			$binaryOptions = $config['rvdlee']['zf-image-optimiser'][$requestedName]['binary-options'];
19			}
20
21			$validatorChain = [];
22			if (isset($config['rvdlee']['zf-image-optimiser'][$requestedName]['validator-chain'])) {
23			$validatorChainConfigs = $config['rvdlee']['zf-image-optimiser'][$requestedName]['validator-chain'];
24
25			$validatorChain = new ValidatorChain();
26			/** @var array $validatorChainConfig */
27			foreach ($validatorChainConfigs as $validatorChainConfig) {
28			if (class_exists($validatorChainConfig['name'])) {
29			$validatorConfig = isset($validatorChainConfig['options']) ? $validatorChainConfig['options'] : [];
30			$validator = new $validatorChainConfig['name']($validatorConfig);
31			$validatorChain->attach($validator);
32			}
33			}
34			}
35
36			return [
			0 ignored issues – show Bug Best Practice introduced 2019-10-13 09:59 UTC by Report Bug Copy Issue Report The expression `return array($binaryOptions, $validatorChain)` returns the type `array<integer,Zend\Valid...datorChain\|array\|mixed>` which is incompatible with the return type mandated by `Zend\ServiceManager\Fact...ryInterface::__invoke()` of `object`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
37			$binaryOptions,
38			$validatorChain
39			];
40			}
41			}

rvdlee / zf-image-optimiser

AbstractImageOptimiserFactory A last analyzed 2019-10-15 20:56 UTC

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like

AbstractImageOptimiserFactory A
last analyzed 2019-10-15 20:56 UTC