DoctrineDataFixtureModule\Service\FixtureFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	5
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	canCreate()	0	3	1
A	getOptions()	0	8	2
A	__invoke()	0	3	1

<?php

namespace DoctrineDataFixtureModule\Service;

use Interop\Container\ContainerInterface;
use Zend\ServiceManager\Factory\FactoryInterface;

/**
 * Factory for Fixtures
 *
 * @license MIT
 * @link    www.doctrine-project.org
 * @author  Martin Shwalbe <martin.shwalbe@gmail.com>
 * @author  Rob van der Lee <r.vdlee@salesupply.com>
 */
class FixtureFactory implements FactoryInterface
{
    /**
     * @param ContainerInterface $container
     * @param string $requestedName
     * @return bool
     */
    public function canCreate(ContainerInterface $container, $requestedName)

The parameter $container is not used and could be removed.

    {
        return class_exists($requestedName);
    }

    /**
     * @param ContainerInterface $container
     * @param string $requestedName
     * @param array|null $options
     * @return array|object
     * @throws \Psr\Container\ContainerExceptionInterface
     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        return $this->getOptions($container, 'fixtures');

The expression return $this->getOptions($container, 'fixtures') returns the type array which is incompatible with the return type mandated by Zend\ServiceManager\Factory\FactoryInterface::__invoke() of object.

    }

    /**
     * @param ContainerInterface $container
     * @param $key
     * @return array
     * @throws \Psr\Container\ContainerExceptionInterface
     * @throws \Psr\Container\NotFoundExceptionInterface
     */
    public function getOptions(ContainerInterface $container, $key)

The parameter $key is not used and could be removed.

    {
        $options = $container->get('config');
        if (!isset($options['doctrine']['fixture'])) {
            return array();
        }
        
        return $options['doctrine']['fixture'];
    }
}