Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class ThreemaGateway_Option_AllowGet |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Renders the allow get debug setting. |
||
| 15 | * |
||
| 16 | * Basically it just hides the setting if the debug mode of XenForo is disabled. |
||
| 17 | * |
||
| 18 | * @param XenForo_View $view View object |
||
| 19 | * @param string $fieldPrefix Prefix for the HTML form field name |
||
| 20 | * @param array $preparedOption Prepared option info |
||
| 21 | * @param bool $canEdit True if an "edit" link should appear |
||
| 22 | * |
||
| 23 | * @return XenForo_Template_Abstract Template object |
||
| 24 | */ |
||
| 25 | public static function renderOption(XenForo_View $view, $fieldPrefix, array $preparedOption, $canEdit) |
||
| 39 | } |
||
| 40 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.