Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class ThreemaGateway_ControllerAdmin_Login extends XFCP_ThreemaGateway_ControllerAdmin_Login |
|
|
|
|||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Passes the provider ID to the TFA model to enable customized behaviour. |
||
| 15 | * |
||
| 16 | * @return XenForo_ControllerResponse_View |
||
| 17 | */ |
||
| 18 | public function actionTwoStep() |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @return XenForo_Model_Tfa |
||
| 42 | */ |
||
| 43 | protected function _getTfaModel() |
||
| 47 | } |
||
| 48 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.